From patchwork Sat Dec 16 04:01:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam James X-Patchwork-Id: 179798 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp24461dyi; Fri, 15 Dec 2023 20:03:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFi4URpps9fqA1pJ1rK4W3YPE3iDo/GHKAJUxJQwNPFXrrdNbEQsy5WqXyz8HjKh2uEious X-Received: by 2002:a05:622a:54c:b0:425:9561:4308 with SMTP id m12-20020a05622a054c00b0042595614308mr20138222qtx.122.1702699435738; Fri, 15 Dec 2023 20:03:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702699435; cv=pass; d=google.com; s=arc-20160816; b=qfeHCZMDuRcn+7xCPRYBxvwUln3rlAeYJGKRh0ZDHBfVune4INIZk5lHxGVbm8jINl kL10Hb7LX46RX3Dxq1hv1SGkSVUQHqzIVEiRZL8tXRGephFTRXxF6Kp9mbztCmeU/aRF H/j6/JKvZ7IWHZuvmdX1vJfj4Ulndhj5ziOOgvz1S4YesXHOAGmVWvr24Qar6yBSr28a Sf1D6RVAd/RaZa7eUjcAZHcdx4wmNILiMGXaFStp/9UL2vjF+jJo/z0raGReIyDKRnr8 8m0q+5pWCTmhqLDd5d5ezpcFNmqC2O8tojHNSaykxbAVtYgzbpYXcqRyZVkm3yiFiX2w dvBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to; bh=IXgjzmyt9kGE1FbsvHcsF1uSYy160EhffkP9Lt/+gfc=; fh=8q0FNsHanCJPI6EPxbmjnCgcUOgjtP8i5rHqen9ihv0=; b=ENJZsrNpti292XarFE+EVrHFRJHiVzTcaRRd074+sMWU+9BP8iYrFbmaL0XLsXb0mi vrIOV3wljQMagCuPAUJvARRNEnRHQUurIoZ+5KA655AVDqpmDtRf1eIQXFL3Ib0U/1jL deZnshRNEDlLdb3bysrC4/HDZReE6qEtUN50IwoKFrL0jA3EWiRSvsr4yKSwm1RLAGLA X4qzImeOB8lRoTbG4O8DWj43f6touxzX/+OAXu3/JibcMPINhNR7ehLwwoPRp5039Vl6 oTtw9GEOGDXRbNrqznms0gFhe/8CBT/O5J8KK3cWruYKniJgXbvZTDlxTp+Kj6rfaxRF nDaw== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gentoo.org Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id bn3-20020a05622a1dc300b00423d64d4491si19973862qtb.71.2023.12.15.20.03.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 20:03:55 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=gentoo.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1CBB83875DF5 for ; Sat, 16 Dec 2023 04:03:34 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 1E9AC3847738 for ; Sat, 16 Dec 2023 04:02:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E9AC3847738 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E9AC3847738 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702699379; cv=none; b=dEF8DHPMlhJP9uQX6KPBSAaI1F7zLTQ4yNjuGdJ1edyfom0XlXYiuC54L0scB6C6uZROcRRHhfFcC/zOaz9vTi9pCHf5p411Y+jsAvPsULSXhZo/wbWAas1Dl0qrFvGjhzsysUhBCk9xTnoWP6nndPWRIMMP/vkyD0sJB2NH2Nk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702699379; c=relaxed/simple; bh=oQ+NxnJqUXqvalnWeGmfe/2ZNP6nBB+MxigoOdis0Xo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=SbLx7efhHb2CPqdTYnxpTwSqVB/lwdOZ8BNOXpih0zJOsxcear1q9HvS0+JrfSe3dfbyEA1OAZgh8QOfJNeY7j86Vk/1gvbZa8Yer7h+YQt+UB2f6to3r+gY+OgeCR+wvsrEaKOp3k+R+2Z/bMHAjwURxGr4S33xcIirxqrOLvI= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: binutils@sourceware.org Cc: nickc@redhat.com, Sam James Subject: [2.41 PATCH 07/10] ld: ld-lib.exp: log failed dump.out contents for debugging Date: Sat, 16 Dec 2023 04:01:30 +0000 Message-ID: <20231216040239.1981071-8-sam@gentoo.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231216040239.1981071-1-sam@gentoo.org> References: <20231216040239.1981071-1-sam@gentoo.org> MIME-Version: 1.0 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785409763435910560 X-GMAIL-MSGID: 1785409763435910560 If we're using dump_prog in a test which fails, log the dump.out contents to ld.log to aid debugging. This avoids needing to ask reporters to manually run e.g. `objdump` commands when making bug reports. PR30722 * ld/testsuite/lib/ld-lib.exp: Log failed dump.out contents to aid debugging. Approved-by: Nick Clifton Signed-off-by: Sam James (cherry picked from commit 646657284f6b62a71a6869826e951b3def4d73a6) --- ld/testsuite/lib/ld-lib.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp index 918464069a9..aca303e0728 100644 --- a/ld/testsuite/lib/ld-lib.exp +++ b/ld/testsuite/lib/ld-lib.exp @@ -640,7 +640,7 @@ proc run_ld_link_tests { ldtests args } { remote_upload host "dump.out" if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then { - verbose "output is [file_contents "dump.out"]" 2 + verbose -log "output is [file_contents "dump.out"]" 2 set failed 1 remote_file build delete "dump.out" remote_file host delete "dump.out" @@ -1067,7 +1067,7 @@ proc run_cc_link_tests { ldtests } { } if { [regexp_diff "dump.out" "$srcdir/$subdir/$dumpfile"] } then { - verbose "output is [file_contents "dump.out"]" 2 + verbose -log "output is [file_contents "dump.out"]" 2 set failed 1 break }