From patchwork Thu Nov 16 06:23:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mengqinggang X-Patchwork-Id: 165703 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b909:0:b0:403:3b70:6f57 with SMTP id t9csp3018117vqg; Wed, 15 Nov 2023 22:23:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcLWnBU4VOI6wFk8UO6sDQjlX6X3YIC2HoPV6MWQMoBAjU9ORF9IywjL0WENACaqEsn0vI X-Received: by 2002:a05:620a:17a7:b0:77a:470c:36a2 with SMTP id ay39-20020a05620a17a700b0077a470c36a2mr8449830qkb.42.1700115812225; Wed, 15 Nov 2023 22:23:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1700115812; cv=pass; d=google.com; s=arc-20160816; b=y24RGKGpeK2bXY0r//oY/82lhfzWWIE8czP3nujDOQAx5N0NoQ81oBQ3JqFc07nz4r shibKKg/xjPh7F6v9CiZHYN7dwvyKRFdingnOYAhdaicqMY7udJiVWrg0Uz9WXaSOfpY g2MCAp654EaYzHiUIHzKkwTnOXxRuz0kDbBqaUKmMuAeAeSYIo20ofmFG9ot17X+l3Mg shiv0v7+DQ8YOs86HWOo8MM5xBgsz1o//LJklYbLDUNUaKi545snu1v7VNz0ktHox2E6 ajxmC09Fyc9T210t3FGYCZXIUk/kjmCz+i0o/I9lz3ZMFluj1A5zmr5rExOhZDJpXjaY mXsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to; bh=xtRqma/XTXGwmCUDZNtBY/l4QermuSuNaSHiQ8bV3KU=; fh=E++1HYE07Ug0Tb3mwOoH2gQvrrmpXVdxZHa97F1+u1A=; b=sZpHNse45a3lrvY6kUJA4bn4hiLHPg+RJabQMw/Jpgabg/PupVgzQBzfxPid8s+HA/ p1DW+KYrkJfflL+14e7KCNxKPDXMGxiphm7rI5XUxNQT9Qrq3YM9iWOLiSYDlylPok14 G+3F8DeoC4NQK5R5LY3g+NRDMxykMLjTcrgmCQO5Pw8jN7TRF8uwmrcKmEqk/74f9+2p qu/RtYKfMOLZDpG3jih3LyP4vZa0bgWEPVvhmElWPwEhXeqMds1ywld50CmmOqEavrJi yjZfgEJOMRkkSa73JxGoBZf29VtgccmfkPwsmWW6UZ6L9Ps39HF+Y/Pa387L5BoYHnt8 gysA== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id or1-20020a05620a618100b007789c2585f0si11133559qkn.418.2023.11.15.22.23.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 22:23:32 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06AD53857B88 for ; Thu, 16 Nov 2023 06:23:32 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 79F51385829D for ; Thu, 16 Nov 2023 06:23:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79F51385829D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 79F51385829D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700115807; cv=none; b=i3ALKeFqQGyHNi1M4WFK73kwQJjXhAzxhY2qsh7Tdvlf+gcrhUvvgHBDLqLNo+B6f/QaJ3ePMjyWm+5XwOXKq0Nsw+EyuN1QuWDkrUJEG46FDXt+oU7CFokSRq/oJZ/1R4xf567EHCOPNqNSah8N0EG78n3jtW6fFgI/ciXdbiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700115807; c=relaxed/simple; bh=4j3p0xeD6mMjLDYw46ZGuQKhIB3oZpRISDx9vPgHVIo=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=oZwbdSImRjHupovJ5aNvNlD3USCmrINhk5oJsvkUDZkZRlri38PrScerUBKUsHKSicgaArbFh/Unn/il5+nZIXfgfF1CCDUyFSydns03n85blBjrh5+aURA5YBQCrh6GU/AvbBs7wt/bkD279bXaYHuy6hrXYqr4sC5EoZmSPNE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.2.6.5]) by gateway (Coremail) with SMTP id _____8BxNuhctVVlQHk6AA--.61544S3; Thu, 16 Nov 2023 14:23:24 +0800 (CST) Received: from 5.5.5 (unknown [10.2.6.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxndxOtVVlfNJDAA--.16902S3; Thu, 16 Nov 2023 14:23:23 +0800 (CST) From: mengqinggang To: binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, xry111@xry111.site, i.swmail@xen0n.name, maskray@google.com, mengqinggang Subject: [PATCH v1 1/6] LoongArch: Fix ld --no-relax bug Date: Thu, 16 Nov 2023 14:23:02 +0800 Message-Id: <20231116062307.3292483-2-mengqinggang@loongson.cn> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20231116062307.3292483-1-mengqinggang@loongson.cn> References: <20231116062307.3292483-1-mengqinggang@loongson.cn> MIME-Version: 1.0 X-CM-TRANSID: AQAAf8AxndxOtVVlfNJDAA--.16902S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7Zr15uF4rJryfWr4xCw45urX_yoW8GrW8pa 4furyrJF4rCFn3WwnrJrWUuF4DJry8Kr12ya43t3s7CF4DCFy5XF4rAryIgFWDG3WIgrW8 Zr10g347uFn7AabCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUk2b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxU7MmhUUUUU X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1782700637822401395 X-GMAIL-MSGID: 1782700637822401395 When ld --no-relax, pcalau12i + ld.d still can be relaxed. --- bfd/elfnn-loongarch.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c index 18ad3cc91ca..1162cb35cd6 100644 --- a/bfd/elfnn-loongarch.c +++ b/bfd/elfnn-loongarch.c @@ -3996,29 +3996,22 @@ loongarch_elf_relax_section (bfd *abfd, asection *sec, loongarch_relax_align (abfd, sec, sym_sec, info, rel, symval); break; case R_LARCH_DELETE: - if (info->relax_pass == 1) + if (1 == info->relax_pass) { loongarch_relax_delete_bytes (abfd, sec, rel->r_offset, 4, info); rel->r_info = ELFNN_R_INFO (0, R_LARCH_NONE); } break; case R_LARCH_PCALA_HI20: - if (info->relax_pass == 0) - { - if (i + 4 > sec->reloc_count) - break; - loongarch_relax_pcala_addi (abfd, sec, rel, symval); - } + if (0 == info->relax_pass && (i + 4) <= sec->reloc_count) + loongarch_relax_pcala_addi (abfd, sec, rel, symval); break; case R_LARCH_GOT_PC_HI20: - if (local_got) + if (local_got && 0 == info->relax_pass + && (i + 4) <= sec->reloc_count) { - if (i + 4 > sec->reloc_count) - break; if (loongarch_relax_pcala_ld (abfd, sec, rel)) - { - loongarch_relax_pcala_addi (abfd, sec, rel, symval); - } + loongarch_relax_pcala_addi (abfd, sec, rel, symval); } break; default: