From patchwork Tue Oct 24 16:02:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Mezentsev X-Patchwork-Id: 157615 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2043558vqx; Tue, 24 Oct 2023 09:02:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6oXXMTldnhTTc9TM88XDLCwLsmJQyuspd1N3X+nyBi/rnW+a1xAstMQBmnBvWNFJBayxp X-Received: by 2002:ac8:7f0b:0:b0:417:fe9c:6dce with SMTP id f11-20020ac87f0b000000b00417fe9c6dcemr15993947qtk.25.1698163350908; Tue, 24 Oct 2023 09:02:30 -0700 (PDT) ARC-Seal: i=3; a=rsa-sha256; t=1698163350; cv=pass; d=google.com; s=arc-20160816; b=qrhI0WqOTAD02fLhEuqDp8BTbc57cyU3R5lCLHUl6r0yHd0MDSdFsDbXAzpihMiWCY yIWDaCMnCOErJs0+M6UYQVZsd3UQl3fOSXLMG3gVe14BvrpbdAKbgAKTOeHlHoihXsVY ZGscN+9SZENbkBmy3DfYMgy4iWu9hdk1NZVaOMVjqDpeBoUkBjoQZRpJ4a7YonISCCV8 MbUPC7G3yljmhO9MzM0ew4uMg5bk66s8gYC4l9iyuPaTPga+S/lHw9GTp1QHtJhUuPZO FTkcSQwFaiVAMr5SWSriQDhXN6EiFf6ZFJVuNXI/TbW2ZouVzGFFza3JM+o6UVQibfhV MnIA== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=LJbrn6Om2w449evJu4cBlJQ+L99fFszZRRdeI6YSxOY=; fh=rGgRskdXqkw/EDUeDqnE3q/qQuWE7ZzID6eKNBELT+8=; b=u2qpMHnnGISe4Bx5ycWtaLLZPc+ujvAeCQCalj0pYP4ctAR5YgANe5UpNtrsU5rHas KVOdsII42uwrR/RRZQDCIFpKj7xxvMC0Bogjs4rcSg801qdNlkgx12s8kp+X/cAIvmZg pIqPcwNS+USAUNBHJ4XSm8e3gnRIWsififxq/VdMq45gSRETETlVQZmvWSHrH7srSPqR qVh8ej9AP9Tu4S7vej0CGCWS0y4r0CDDnnZD4Dvnz8N9Hy1Pz5xds/WrhgvphExYbZnC Sd4lpx9+noXq6lUEcXtjqjdxGhplOqQPslqIo69Lz2k6m6OeINqsH4VN6psRjNxmlKZN 82MQ== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=sSW4gawl; dkim=pass header.i=@oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=sHTgrQaN; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id q4-20020a05622a030400b004198a7c49dbsi7286129qtw.494.2023.10.24.09.02.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 09:02:30 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2023-03-30 header.b=sSW4gawl; dkim=pass header.i=@oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=sHTgrQaN; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 910A53858CDB for ; Tue, 24 Oct 2023 16:02:29 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 03E233858C36 for ; Tue, 24 Oct 2023 16:02:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 03E233858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 03E233858C36 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698163344; cv=pass; b=pTJLJ2X2zZesgicR0jQhUULWHHU2TUg5rx1FfqB9g/nBNBw//8PlyZl61LlphuAmSj9vrvZXuBhPVYIrWhexp3rLUj3cRdUZqp0Fx5PtJ8bnLVKHk8/iuDp+hoB2HrohMZf94NsDcifQVOeOTMo00BqkjqZ03vpUCj2gF8Ak2s4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698163344; c=relaxed/simple; bh=UbGaXyTduUBKRQ9wntyCGYKCimqi6cubuDWmcDlMq+Y=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-Id: MIME-Version; b=hDL7QD/S67eUKIBDBNurc0uT/Qy+oRYpd+WPzb7q8SSZ4Wt9t0OVBygNryrLZ8KSj8UHwwrEUeh1s7w8xr4TcduiSrj6v/D1v9t7UCxGxXtM6CypH4fpw5y8oz+eEN9XIa7PWJWnycMo51Lbl6Shd1O5Ijh4yWPp0ZZNAxSTgvs= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39OCJYsN014306 for ; Tue, 24 Oct 2023 16:02:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=LJbrn6Om2w449evJu4cBlJQ+L99fFszZRRdeI6YSxOY=; b=sSW4gawllaDPTYnO+9qi28xYyPnN9fQ8Z7ulaW9XASog0B6zFL575iN2gBG2UTqHkK1q sw1I89vP/+4monLERqvt6SyrNLAru0FQrC//8GVcdUuJws8K+xYd/65qYcmKGpRqVoZd OshnyiK6PTkCwMdr8Jl/O/QgC+lKIk8KD1x7/9wJItA4NiP0H6SBr2hkJyJ/HFtEW5ff krv5QbxKcNHt7G5UdPHNg13Ms9sMJZFOKYuj4l8u0Qy6NGsWWk2n3g3fajUwqMlf3NgT JBXa4UzrU+67JNtmJHbqgDSgffDelYVcBcFCBjGwNjpUV9UtqjdevlZc14sI0iXiZOkb wQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tv6pcwtm5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 24 Oct 2023 16:02:19 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39OF95Wm014204 for ; Tue, 24 Oct 2023 16:02:18 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3tvbfjq345-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 24 Oct 2023 16:02:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oRNN8/JtH4xOWkDYodGd35Sa7OkC/dk7A8wu5so6ZywSNKq3uCeqDhdubMbmkNiwOGYJWmcajd9uJm/KLliaahBsay4PMtSTojZ4ZWafM+yhtq78slPhr6aF7bdYXeq8ca3L5DT75sLjco7mQPjiVSJUshZiIkENASX9wgS4FfokQiMgchzpkEdOSBQ4vPxKDSTXzv6i7Ppy4o8G/Hd8NULTyZ2K8GWHsxfNhnlDhonty+PeWKWi8gNrh0VMbb06htnwNPtqAh64ux5qT/jkRxp5YPhYAUhV0qAJi4tXWL97wqtrYr6MlW4N1fxQqMdZ7gT12ZrcC6VWskTVg3pJRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LJbrn6Om2w449evJu4cBlJQ+L99fFszZRRdeI6YSxOY=; b=OQscRVXDPhlaIk8i4vZP6LJgi193WylJxnNE/a939Og6NesEh1n9DjUsgURnOktGVLL/wAhTEX10RVNWaendaVxgJl9tX9QG0W9imEJnRI2noy6nfrvFmEO+9qBbzGBBWBj7CxzOiFKUeXKF06k9+F5E46s9CM5NOSxg70okIdx1k1TU+kgYoAJCWscIPvqITRpL7HgVys0fMKN0jwEDCWL67F0r3VJ+Gdc8b9ZMpEHhK3t6i+1GYYG/nGcPMJBtZXMnAIZGlNE8EBUin02Lvsst+4K8OoaFQf5UVOT2Xcd6lRuIGUNzcvADXt0aNjU9oKt2Yx4Xl79TZyOkNn6Xwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJbrn6Om2w449evJu4cBlJQ+L99fFszZRRdeI6YSxOY=; b=sHTgrQaNr7ZmJk3SBBiggetayE0HSnrkRX0mhlXiaP14oeHyQJOcH4DU3+/bKwVfMPNhqGn5HuZ7tPm7Cr24z0xCSUEQ8EJGDo0GG01GfrejyatpiU8RzM2SvOskJQDqB90KHtzC4KGxwVdiDkMEesnh5j15dzTB+FJNcM6/Rdg= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by DM4PR10MB6136.namprd10.prod.outlook.com (2603:10b6:8:b8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Tue, 24 Oct 2023 16:02:13 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::5fee:1f9c:2b03:26e5]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::5fee:1f9c:2b03:26e5%4]) with mapi id 15.20.6907.028; Tue, 24 Oct 2023 16:02:13 +0000 From: vladimir.mezentsev@oracle.com To: binutils@sourceware.org Cc: Vladimir Mezentsev Subject: [PATCH] gprofng: Fix -Wformat= warnings Date: Tue, 24 Oct 2023 09:02:06 -0700 Message-Id: <20231024160206.3818478-1-vladimir.mezentsev@oracle.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: BYAPR01CA0028.prod.exchangelabs.com (2603:10b6:a02:80::41) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|DM4PR10MB6136:EE_ X-MS-Office365-Filtering-Correlation-Id: 4506361d-8c87-4517-146a-08dbd4aa962f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3SUHSRABVDkGYKVnJolAHzrqB46/Lk903f1rydAgZdj83Fg1F5cYLSlukKqY7NrF2AM6A4XSI6lyp5KJSrmnqbgGPo6Tvfh6QJQCPFbkzSZIJWHn6jxS+oi/HpkTuzhCySkr/y5UPz/Ym7KJYXU3wKQxneVK3hlEm4xrXNYTW34llTaPoi55TAVQ83I8YBCNnWVQCb1gJfAGrEMIez95CvBUZuVKm850GOUylUtAiQ5yeK1YKOua1BNfE9IpgzoCPmx819xgwm6YZ2VO1TVT+PinZ55IjggxwECaJSTK4foFhQVA3H37E+uYFJeo92rGZ1+RlN7tglX2+B7Q2ekoNqrSKR/TJs6pDbHHJ0Ps+Ud5bmTbFvmo716SLr23Czi916WFL0A50FCEn3b17Jx/LGH8calrZlG70m/Ekia7YFhG0Wl4WG3P8dBZXN0Kcg1vi9OFHkSroeeM97YzJw0+9+3NR+hJFo5kzLq7vXrCMvrErTldNnqsweCBOU81Ha7efWjGM7bx4KTIJN3zn3qEhENsuvXDFvxceDbkm6FVjL+H8a6MA2f4Qzv5b11utAiZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(396003)(136003)(346002)(39860400002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(2616005)(1076003)(38100700002)(107886003)(83380400001)(316002)(8676002)(4326008)(30864003)(6486002)(66946007)(66476007)(66556008)(6916009)(478600001)(36756003)(86362001)(4001150100001)(6512007)(6506007)(41300700001)(9686003)(5660300002)(8936002)(6666004)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cxP/kwR7mA5+Sxwb0mXoXPxUKApkmKXB+n+d45cHnvRCErTjKOPgnoH/d4le6JPXNGfDc5mUo89ULifL/lg7BRB7vRBz9nmGbOHb0mhAimw2aqo4REWPuJZryNIqziI29nQ56qaqU53gdlQ5tziLUkPyJS5PU2nOAb12CeBw5f46QijQEWaUmiznyeSpSliqCvE8xEDjKNgFpnjB5Gq7s50XBBTTQ68oF2fin3UDPbDzkMVDzj99SiHp3TO4cxKMwNYBJqpUNH4Wt4spzzVPLQFTqyEagpNiW1outaF8V5pzLRCIM8dAolWSFCXBbCFs74tfxF/T8j6lLUfY+1WdMb7+C400OFPi31a7Dtwr2gadcc5NXKEY3Ib7XSaM8SCHvYBqeCpt8P8JLBM0ofRyp/dy4Ol8urEBJjAu+VLacNFdlXDEdDfTLkqpLsWak4JtXBVFCwYtzZRnSN5A3U2QPFijOO+dYVIH6q1QLpsh3SnG5ZcssFvwLI8WfdBSqys/yMDni/JLOf4GD1AVcB22os0j3waWXhX4EvwY2gdle2J6ZJ8Td16DCsdaNcoaPOiyF4eIFbVsS8BEQXGnrL5Qh7+DO19GE3KUsmdCfIivtPx3CW25LiYlyubZ93x+lxyzamnZU2bgdPmUoxZET3Feyi1D/g8LYzAYM3Jj67A4LazA4cymhN27QIBc+9h3hl2w9k+cNY6UpDxsR+5TAeArv8wEVKyBeUzsqFCHB2k4cblf39lNyb7m266Yd4XkyPvB1Kx7mHfNo22vvu0DRThtviWsRgGT+yHxnVBuInqzFF8EykYOQLlbtylNb45XmtE41k10ZheXx/l4MvxKa8XIXdGkimYxVjTIBMqsaOrJ3zykzCwurV9lsDYZ6vAgZSy6ALAu9zQs4QDtU78ZH1smCVBZC46qUIuh2SRP3N0NYyRxzmVY2wIGxIpkExxoF/rAmRvJrO2eWlwL3CYlY0XMll5X2V9YBPN2tB1Kz6LuXHJQ85zcDmtv5HekXENl04gFGrnh6UZ+T2ooA+mRrOq/pLGme4yAp4hR/UdNyuz6fkkMxeuYbv4wwdpnFRPfRqXVx2v2JEOy2QhTKDEW0AOSvlTG3SNvuuLycBb/BIEOr0F42cCTomLaUf7fWDh1syFavJdutRHNYMFyrZz+t4lspwc0XEqnlbOTHCZhFOEqP2hCX+Zilwo7M1cqH1xDd6Qmb0QYvAfrSwGUGd6agUq8nlLDuxxVSMGBvkQBz+WKk7K1OuqVV/E9wIbftak/3bkxoz2jJO1tsxXn+XOiht4laOfVui+/498Cm5HzTPYum3BIyzMY64veYGsSk/5TEmmMqoMz/DQXAoY14dAPJfevh1SAu+ItOvK+QW30N0TfGidhITRaFjd9qq+iU2VaSI1AXIe6tt0DPCM85qL+S/fJLxyWS/MyeLY4x/2v4ERkZUzI3KLJYwdXNmdRlqc1xhVhQnZFGpAN8/FuwDhpTtaz71t6XZlsisG9cvsHBkG8xysyqbAHOU3DhJ/dKTWN41Wc04UU5qfUcetaYgqSzPg2wsb0UhIJxIvTCRV/cmsWsWpXhMf8dd2arEl3wh97ZJK5AnLxmb42J4YffRyjx54r27CVO12hUVoyuv7IOWCO3LQ= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: mRkCo84euxYTUXhZE+h4LAHOr+LvH6ERB5RzAvZ9YKfV7VFO3NW7UtQb50ocSYmJ7GEpjtWVLlb+TUWwHlPjKW93+bm7ZOoSi7fxph+8PYxc5Wvd/QjvrTV0PGGWfSMa11UDg9QqzlRqg+BpCzrVt5fuH9zuKhRZzsgfz4kd6r2EztnVjtyhWOC6dF0/V+oMC8RYsgZos1+RZbaTQa9hi3aePr6DMBmX4Oad8eUy1BUYuONHvGTCkuwTbP/jX6/2XpTZmNVji+5qsgv+tOWaSu/QZG6leriS2ouOaF173sry/pBEu1ApMN72tnC9sQ4G+/qtQUVkClWDSq1cnly9q/VC2dX3sDKkqTO2eIMGYYI9x4cuz7x/NE3KF8fa/gmyrPArqM/wd201FCyw84a4D4eJLgh3qo/J5s2WkU13/I5hawnUgrXl8FZWlNvMecjdAIN58Er8xY+SKGM/rdsSVMvj/Pb6tVmgvH6GXByT/Jl1o8ANvLRVlukGfz6H9wpiELegQsvsaHHoG5WgAQ+2cyWNaa+RoW9FOhRSgZPnOqHpskk8iViT5NeN/LKIAYJteUppO3aPgoEa+mlXEVH3KppzsdDE+mIuoK1zq0UjpEt8c7ZiwLDL1r3+Uy43C5EiIWBi2JqWbORL4ZZSrIhSZLR6ovBA9fRt/r2rhofDANtrJw7h9UotgpVlAK56tFkuLjOcdMCkxYi2uKZO05W6HHmGHQxGFnIuKqWsMz1WamcY7spH2hgPiQ16bvBVI59FEXt7m5mffq3BX7W4vFYchQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4506361d-8c87-4517-146a-08dbd4aa962f X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 16:02:13.5586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eHgqcQvSZJf76iW0EdrGJK9jvOR64Cyv3e/lIvMN0BTnkSPd8gb5L3HHvnJHvNBfnh9EHBfWTaVDW58r9fUPImngWM5pwA55q/Y+Ojm8OiY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6136 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-24_16,2023-10-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001 definitions=main-2310240138 X-Proofpoint-GUID: Guc8EyKTWV8kFFQtnYj7X7jkz8HXbUcV X-Proofpoint-ORIG-GUID: Guc8EyKTWV8kFFQtnYj7X7jkz8HXbUcV X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780653333817578331 X-GMAIL-MSGID: 1780653333817578331 From: Vladimir Mezentsev Added format attribute to several gprofng functions. Fixed -Wformat= warnings. gprofng/ChangeLog 2023-10-23 Vladimir Mezentsev * libcollector/heaptrace.c: Fixed -Wformat= warnings. * libcollector/hwprofile.c: Likewise. * libcollector/iolib.c: Likewise. * libcollector/iotrace.c: Likewise. * libcollector/jprofile.c: Likewise. * libcollector/profile.c: Likewise. * libcollector/synctrace.c: Likewise. * src/ClassFile.cc: Likewise. * src/SourceFile.cc: Likewise. * libcollector/libcol_util.h: Added format attribute. * src/Emsg.h: Likewise. * src/collector_module.h: Likewise. * src/data_pckts.h: Define fld_sizeof. --- gprofng/libcollector/heaptrace.c | 29 +++++++---- gprofng/libcollector/hwprofile.c | 81 +++++++++++++++++++----------- gprofng/libcollector/iolib.c | 2 +- gprofng/libcollector/iotrace.c | 37 +++++++++----- gprofng/libcollector/jprofile.c | 10 ++-- gprofng/libcollector/libcol_util.h | 3 +- gprofng/libcollector/profile.c | 23 ++++++--- gprofng/libcollector/synctrace.c | 23 ++++++--- gprofng/src/ClassFile.cc | 2 +- gprofng/src/Emsg.h | 3 +- gprofng/src/SourceFile.cc | 6 ++- gprofng/src/collector_module.h | 11 ++-- gprofng/src/data_pckts.h | 1 + 13 files changed, 149 insertions(+), 82 deletions(-) diff --git a/gprofng/libcollector/heaptrace.c b/gprofng/libcollector/heaptrace.c index b51ab330ba6..4c1b6b3b0f5 100644 --- a/gprofng/libcollector/heaptrace.c +++ b/gprofng/libcollector/heaptrace.c @@ -24,6 +24,7 @@ #include "config.h" #include +#include #include "gp-defs.h" #include "collector.h" @@ -151,26 +152,34 @@ open_experiment (const char *exp) module_interface.description); /* Record Heap_packet description */ - Heap_packet *pp = NULL; collector_interface->writeLog (" \n", HEAP_PCKT); collector_interface->writeLog (" \n", - &pp->comm.lwp_id, sizeof (pp->comm.lwp_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Heap_packet, comm.lwp_id), + fld_sizeof (Heap_packet, comm.lwp_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.thr_id, sizeof (pp->comm.thr_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Heap_packet, comm.thr_id), + fld_sizeof (Heap_packet, comm.thr_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.cpu_id, sizeof (pp->comm.cpu_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Heap_packet, comm.cpu_id), + fld_sizeof (Heap_packet, comm.cpu_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.tstamp, sizeof (pp->comm.tstamp) == 4 ? "INT32" : "INT64"); + (int) offsetof (Heap_packet, comm.tstamp), + fld_sizeof (Heap_packet, comm.tstamp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.frinfo, sizeof (pp->comm.frinfo) == 4 ? "INT32" : "INT64"); + (int) offsetof (Heap_packet, comm.frinfo), + fld_sizeof (Heap_packet, comm.frinfo) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->mtype, sizeof (pp->mtype) == 4 ? "INT32" : "INT64"); + (int) offsetof (Heap_packet, mtype), + fld_sizeof (Heap_packet, mtype) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->size, sizeof (pp->size) == 4 ? "UINT32" : "UINT64"); + (int) offsetof (Heap_packet, size), + fld_sizeof (Heap_packet, size) == 4 ? "UINT32" : "UINT64"); collector_interface->writeLog (" \n", - &pp->vaddr, sizeof (pp->vaddr) == 4 ? "UINT32" : "UINT64"); + (int) offsetof (Heap_packet, vaddr), + fld_sizeof (Heap_packet, vaddr) == 4 ? "UINT32" : "UINT64"); collector_interface->writeLog (" \n", - &pp->ovaddr, sizeof (pp->ovaddr) == 4 ? "UINT32" : "UINT64"); + (int) offsetof (Heap_packet, ovaddr), + fld_sizeof (Heap_packet, ovaddr) == 4 ? "UINT32" : "UINT64"); collector_interface->writeLog (" \n"); collector_interface->writeLog ("\n"); return COL_ERROR_NONE; diff --git a/gprofng/libcollector/hwprofile.c b/gprofng/libcollector/hwprofile.c index 3ca89d1ceb6..092d665e618 100644 --- a/gprofng/libcollector/hwprofile.c +++ b/gprofng/libcollector/hwprofile.c @@ -25,6 +25,7 @@ #include #include #include +#include #include #include #include @@ -823,66 +824,90 @@ hwclogwrite0 () collector_interface->writeLog ("\n", module_interface.description); /* Record Hwcntr_packet description */ - Hwcntr_packet *pp = NULL; collector_interface->writeLog ("\n", HW_PCKT); collector_interface->writeLog (" \n", - &pp->comm.lwp_id, sizeof (pp->comm.lwp_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Hwcntr_packet, comm.lwp_id), + fld_sizeof (Hwcntr_packet, comm.lwp_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.thr_id, sizeof (pp->comm.thr_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Hwcntr_packet, comm.thr_id), + fld_sizeof (Hwcntr_packet, comm.thr_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.cpu_id, sizeof (pp->comm.cpu_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Hwcntr_packet, comm.cpu_id), + fld_sizeof (Hwcntr_packet, comm.cpu_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.tstamp, sizeof (pp->comm.tstamp) == 4 ? "INT32" : "INT64"); + (int) offsetof (Hwcntr_packet, comm.tstamp), + fld_sizeof (Hwcntr_packet, comm.tstamp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.frinfo, sizeof (pp->comm.frinfo) == 4 ? "INT32" : "INT64"); + (int) offsetof (Hwcntr_packet, comm.frinfo), + fld_sizeof (Hwcntr_packet, comm.frinfo) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->tag, sizeof (pp->tag) == 4 ? "INT32" : "INT64"); + (int) offsetof (Hwcntr_packet, tag), + fld_sizeof (Hwcntr_packet, tag) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->interval, sizeof (pp->interval) == 4 ? "INT32" : "INT64"); + (int) offsetof (Hwcntr_packet, interval), + fld_sizeof (Hwcntr_packet, interval) == 4 ? "INT32" : "INT64"); collector_interface->writeLog ("\n"); if (hwcdef_has_memspace) { /* Record MHwcntr_packet description */ - MHwcntr_packet *xpp = NULL; collector_interface->writeLog ("\n", MHWC_PCKT); collector_interface->writeLog (" \n", - &xpp->comm.lwp_id, sizeof (xpp->comm.lwp_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, comm.lwp_id), + fld_sizeof (MHwcntr_packet, comm.lwp_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->comm.thr_id, sizeof (xpp->comm.thr_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, comm.thr_id), + fld_sizeof (MHwcntr_packet, comm.thr_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->comm.cpu_id, sizeof (xpp->comm.cpu_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, comm.cpu_id), + fld_sizeof (MHwcntr_packet, comm.cpu_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->comm.tstamp, sizeof (xpp->comm.tstamp) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, comm.tstamp), + fld_sizeof (MHwcntr_packet, comm.tstamp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->comm.frinfo, sizeof (xpp->comm.frinfo) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, comm.frinfo), + fld_sizeof (MHwcntr_packet, comm.frinfo) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->tag, sizeof (xpp->tag) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, tag), + fld_sizeof (MHwcntr_packet, tag) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->interval, sizeof (xpp->interval) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, interval), + fld_sizeof (MHwcntr_packet, interval) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->ea_vaddr, sizeof (xpp->ea_vaddr) == 4 ? "UINT32" : "UINT64"); + (int) offsetof (MHwcntr_packet, ea_vaddr), + fld_sizeof (MHwcntr_packet, ea_vaddr) == 4 ? "UINT32" : "UINT64"); collector_interface->writeLog (" \n", - &xpp->ea_paddr, sizeof (xpp->ea_paddr) == 4 ? "UINT32" : "UINT64"); + (int) offsetof (MHwcntr_packet, ea_paddr), + fld_sizeof (MHwcntr_packet, ea_paddr) == 4 ? "UINT32" : "UINT64"); collector_interface->writeLog (" \n", - &xpp->pc_vaddr, sizeof (xpp->pc_vaddr) == 4 ? "UINT32" : "UINT64"); + (int) offsetof (MHwcntr_packet, pc_vaddr), + fld_sizeof (MHwcntr_packet, pc_vaddr) == 4 ? "UINT32" : "UINT64"); collector_interface->writeLog (" \n", - &xpp->pc_paddr, sizeof (xpp->pc_paddr) == 4 ? "UINT32" : "UINT64"); + (int) offsetof (MHwcntr_packet, pc_paddr), + fld_sizeof (MHwcntr_packet, pc_paddr) == 4 ? "UINT32" : "UINT64"); collector_interface->writeLog (" \n", - &xpp->ea_pagesz, sizeof (xpp->ea_pagesz) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, ea_pagesz), + fld_sizeof (MHwcntr_packet, ea_pagesz) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->pc_pagesz, sizeof (xpp->pc_pagesz) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, pc_pagesz), + fld_sizeof (MHwcntr_packet, pc_pagesz) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->ea_lgrp, sizeof (xpp->ea_lgrp) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, ea_lgrp), + fld_sizeof (MHwcntr_packet, ea_lgrp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->pc_lgrp, sizeof (xpp->pc_lgrp) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, pc_lgrp), + fld_sizeof (MHwcntr_packet, pc_lgrp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->lgrp_lwp, sizeof (xpp->lgrp_lwp) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, lgrp_lwp), + fld_sizeof (MHwcntr_packet, lgrp_lwp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->lgrp_ps, sizeof (xpp->lgrp_ps) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, lgrp_ps), + fld_sizeof (MHwcntr_packet, lgrp_ps) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->latency, sizeof (xpp->latency) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, latency), + fld_sizeof (MHwcntr_packet, latency) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &xpp->data_source, sizeof (xpp->data_source) == 4 ? "INT32" : "INT64"); + (int) offsetof (MHwcntr_packet, data_source), + fld_sizeof (MHwcntr_packet, data_source) == 4 ? "INT32" : "INT64"); collector_interface->writeLog ("\n"); } } diff --git a/gprofng/libcollector/iolib.c b/gprofng/libcollector/iolib.c index 9de481430de..96fdd258fd0 100644 --- a/gprofng/libcollector/iolib.c +++ b/gprofng/libcollector/iolib.c @@ -640,7 +640,7 @@ remapBlock (DataHandle *hndl, unsigned iflow, unsigned ichunk) hrtime_t teo = __collector_gethrtime (); double deltato = (double) (teo - tso) / 1000000.; (void) CALL_UTIL (snprintf) (errmsg, sizeof (errmsg), - " t=%d, %s: open-retries=%lu, %3.6f ms.; remap\n", + " t=%ld, %s: open-retries=%d, %3.6f ms.; remap\n", (unsigned long) __collector_thr_self (), hndl->fname, iter, deltato); __collector_log_write ("%s\n", diff --git a/gprofng/libcollector/iotrace.c b/gprofng/libcollector/iotrace.c index 81c844048d9..7ed9c99126b 100644 --- a/gprofng/libcollector/iotrace.c +++ b/gprofng/libcollector/iotrace.c @@ -25,6 +25,7 @@ #include #include #include +#include #include // create() and others are defined in fcntl.h. @@ -305,32 +306,42 @@ open_experiment (const char *exp) collector_interface->writeLog (" \n", module_interface.description); /* Record IOTrace_packet description */ - IOTrace_packet *pp = NULL; collector_interface->writeLog (" \n", IOTRACE_PCKT); collector_interface->writeLog (" \n", - &pp->comm.lwp_id, sizeof (pp->comm.lwp_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, comm.lwp_id), + fld_sizeof (IOTrace_packet, comm.lwp_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.thr_id, sizeof (pp->comm.thr_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, comm.thr_id), + fld_sizeof (IOTrace_packet, comm.thr_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.cpu_id, sizeof (pp->comm.cpu_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, comm.cpu_id), + fld_sizeof (IOTrace_packet, comm.cpu_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.tstamp, sizeof (pp->comm.tstamp) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, comm.tstamp), + fld_sizeof (IOTrace_packet, comm.tstamp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.frinfo, sizeof (pp->comm.frinfo) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, comm.frinfo), + fld_sizeof (IOTrace_packet, comm.frinfo) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->iotype, sizeof (pp->iotype) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, iotype), + fld_sizeof (IOTrace_packet, iotype) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->fd, sizeof (pp->fd) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, fd), + fld_sizeof (IOTrace_packet, fd) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->nbyte, sizeof (pp->nbyte) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, nbyte), + fld_sizeof (IOTrace_packet, nbyte) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->requested, sizeof (pp->requested) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, requested), + fld_sizeof (IOTrace_packet, requested) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->ofd, sizeof (pp->ofd) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, ofd), + fld_sizeof (IOTrace_packet, ofd) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->fstype, sizeof (pp->fstype) == 4 ? "INT32" : "INT64"); + (int) offsetof (IOTrace_packet, fstype), + fld_sizeof (IOTrace_packet, fstype) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->fname, "STRING"); + (int) offsetof (IOTrace_packet, fname), "STRING"); collector_interface->writeLog (" \n"); collector_interface->writeLog ("\n"); return COL_ERROR_NONE; diff --git a/gprofng/libcollector/jprofile.c b/gprofng/libcollector/jprofile.c index 4bec99950fc..130da19c060 100644 --- a/gprofng/libcollector/jprofile.c +++ b/gprofng/libcollector/jprofile.c @@ -28,7 +28,7 @@ #include #include #include /* MAXPATHLEN */ - +#include #include #include @@ -628,8 +628,8 @@ jvmti_ThreadStart (jvmtiEnv *jvmti_env, JNIEnv* jni_env, jthread thread) group_name, parent_name, (unsigned long) tid, - thread, - jni_env + (unsigned long) thread, + (unsigned long) jni_env ); TSD_Entry *tsd = collector_interface->getKey (tsd_key); if (tsd) @@ -648,8 +648,8 @@ jvmti_ThreadEnd (jvmtiEnv *jvmti_env, JNIEnv* jni_env, jthread thread) SP_JCMD_JTHREND, (unsigned) (hrt / NANOSEC), (unsigned) (hrt % NANOSEC), (unsigned long) tid, - thread, - jni_env + (unsigned long) thread, + (unsigned long) jni_env ); TSD_Entry *tsd = collector_interface->getKey (tsd_key); if (tsd) diff --git a/gprofng/libcollector/libcol_util.h b/gprofng/libcollector/libcol_util.h index bb9411493f6..c21b4a46c4b 100644 --- a/gprofng/libcollector/libcol_util.h +++ b/gprofng/libcollector/libcol_util.h @@ -38,7 +38,8 @@ extern void __collector_libscf_funcs_init(); /* ------- functions from libcol_util.c ----------------- */ extern void * __collector_memcpy (void *s1, const void *s2, size_t n); -extern int (*__collector_sscanfp)(const char *restrict s, const char *restrict fmt, ...); +extern int (*__collector_sscanfp)(const char *restrict s, const char *restrict fmt, ...) + __attribute__ ((format (scanf, 2, 3))); extern char * __collector_strcat (char *s1, const char *s2); extern char * __collector_strchr (const char *s1, int chr); extern size_t __collector_strlcpy (char *dst, const char *src, size_t dstsize); diff --git a/gprofng/libcollector/profile.c b/gprofng/libcollector/profile.c index 4819d832b31..02c3e669bd2 100644 --- a/gprofng/libcollector/profile.c +++ b/gprofng/libcollector/profile.c @@ -27,6 +27,7 @@ #include "config.h" #include +#include #include #include #include @@ -181,22 +182,28 @@ open_experiment (const char *exp) module_interface.description); /* Record Profile packet description */ - ClockPacket *cp = NULL; collector_interface->writeLog (" \n", CLOCK_TYPE); collector_interface->writeLog (" \n", - &cp->lwp_id, sizeof (cp->lwp_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (ClockPacket, lwp_id), + fld_sizeof (ClockPacket, lwp_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &cp->thr_id, sizeof (cp->thr_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (ClockPacket, thr_id), + fld_sizeof (ClockPacket, thr_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &cp->cpu_id, sizeof (cp->cpu_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (ClockPacket, cpu_id), + fld_sizeof (ClockPacket, cpu_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &cp->tstamp, sizeof (cp->tstamp) == 4 ? "INT32" : "INT64"); + (int) offsetof (ClockPacket, tstamp), + fld_sizeof (ClockPacket, tstamp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &cp->frinfo, sizeof (cp->frinfo) == 4 ? "INT32" : "INT64"); + (int) offsetof (ClockPacket, frinfo), + fld_sizeof (ClockPacket, frinfo) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &cp->mstate, sizeof (cp->mstate) == 4 ? "INT32" : "INT64"); + (int) offsetof (ClockPacket, mstate), + fld_sizeof (ClockPacket, mstate) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &cp->nticks, sizeof (cp->nticks) == 4 ? "INT32" : "INT64"); + (int) offsetof (ClockPacket, nticks), + fld_sizeof (ClockPacket, nticks) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n"); collector_interface->writeLog ("\n"); return COL_ERROR_NONE; diff --git a/gprofng/libcollector/synctrace.c b/gprofng/libcollector/synctrace.c index 565afbe742f..4c4d80dcb24 100644 --- a/gprofng/libcollector/synctrace.c +++ b/gprofng/libcollector/synctrace.c @@ -26,6 +26,7 @@ #include #include #include /* sem_wait() */ +#include #include #include #include @@ -252,22 +253,28 @@ open_experiment (const char *exp) collector_interface->writeLog (" \n", module_interface.description); /* Record Sync_packet description */ - Sync_packet *pp = NULL; collector_interface->writeLog (" \n", SYNC_PCKT); collector_interface->writeLog (" \n", - &pp->comm.lwp_id, sizeof (pp->comm.lwp_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Sync_packet, comm.lwp_id), + fld_sizeof (Sync_packet, comm.lwp_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.thr_id, sizeof (pp->comm.thr_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Sync_packet, comm.thr_id), + fld_sizeof (Sync_packet, comm.thr_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.cpu_id, sizeof (pp->comm.cpu_id) == 4 ? "INT32" : "INT64"); + (int) offsetof (Sync_packet, comm.cpu_id), + fld_sizeof (Sync_packet, comm.cpu_id) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.tstamp, sizeof (pp->comm.tstamp) == 4 ? "INT32" : "INT64"); + (int) offsetof (Sync_packet, comm.tstamp), + fld_sizeof (Sync_packet, comm.tstamp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->comm.frinfo, sizeof (pp->comm.frinfo) == 4 ? "INT32" : "INT64"); + (int) offsetof (Sync_packet, comm.frinfo), + fld_sizeof (Sync_packet, comm.frinfo) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->requested, sizeof (pp->requested) == 4 ? "INT32" : "INT64"); + (int) offsetof (Sync_packet, requested), + fld_sizeof (Sync_packet, requested) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n", - &pp->objp, sizeof (pp->objp) == 4 ? "INT32" : "INT64"); + (int) offsetof (Sync_packet, objp), + fld_sizeof (Sync_packet, objp) == 4 ? "INT32" : "INT64"); collector_interface->writeLog (" \n"); collector_interface->writeLog ("\n"); diff --git a/gprofng/src/ClassFile.cc b/gprofng/src/ClassFile.cc index 0f1d468c967..d59c9630ef1 100644 --- a/gprofng/src/ClassFile.cc +++ b/gprofng/src/ClassFile.cc @@ -1594,7 +1594,7 @@ ClassFile::get_disasm (uint64_t inst_address, uint64_t end_address, { append_msg (CMSG_ERROR, GTXT ("Cannot disassemble class file %s (%s), implausible size = %lld"), get_name (), dbeFile->get_location (), - (end_address - start_address)); + (long long) (end_address - start_address)); inst_size = 0; return NULL; } diff --git a/gprofng/src/Emsg.h b/gprofng/src/Emsg.h index bed664baa2b..9dbaceab11e 100644 --- a/gprofng/src/Emsg.h +++ b/gprofng/src/Emsg.h @@ -105,7 +105,8 @@ public: Vector *msgs; void remove_msg (Emsg *msg); Emsg *get_error (); - Emsg *append_msg (Cmsg_warn w, const char *fmt, ...); + Emsg *append_msg (Cmsg_warn w, const char *fmt, ...) + __attribute__ ((format (printf, 3, 4))); void append_msgs (Vector *lst); }; diff --git a/gprofng/src/SourceFile.cc b/gprofng/src/SourceFile.cc index 35629cccd54..f3809c8d9aa 100644 --- a/gprofng/src/SourceFile.cc +++ b/gprofng/src/SourceFile.cc @@ -135,7 +135,8 @@ SourceFile::readSource () DbeLine *p = v->get (i); if (p->lineno >= srcLines->size ()) append_msg (CMSG_ERROR, GTXT ("Wrong line number %d. '%s' has only %d lines"), - p->lineno, dbeFile->get_location (), srcLines->size ()); + (int) p->lineno, dbeFile->get_location (), + (int) srcLines->size ()); } delete v; } @@ -167,7 +168,8 @@ SourceFile::find_dbeline (Function *func, int lineno) if (dbeLine == NULL) append_msg (CMSG_ERROR, GTXT ("Wrong line number %d. '%s' has only %d lines"), - lineno, dbeFile->get_location (), lines->size ()); + (int) lineno, dbeFile->get_location (), + (int) lines->size ()); } else { diff --git a/gprofng/src/collector_module.h b/gprofng/src/collector_module.h index 07bf362ddb7..67dcad643ed 100644 --- a/gprofng/src/collector_module.h +++ b/gprofng/src/collector_module.h @@ -53,7 +53,8 @@ typedef struct CollectorUtilFuncs char *(*fgets)(char *s, int n, FILE *stream); FILE *(*fopen)(const char *filename, const char *mode); pid_t (*vfork)(); - int (*fprintf)(FILE *stream, const char *format, ...); + int (*fprintf)(FILE *stream, const char *format, ...) + __attribute__ ((format (printf, 2, 3))); void (*free)(void *ptr); int (*fstat)(int fd, struct stat *buf); int (*getcontext)(ucontext_t *ucp); @@ -82,7 +83,8 @@ typedef struct CollectorUtilFuncs int (*setenv)(const char *name, const char *value, int overwrite); int (*sigfillset)(sigset_t *set); int (*sigprocmask)(int how, const sigset_t *set, sigset_t *oldset); - int (*snprintf)(char *str, size_t size, const char *format, ...); + int (*snprintf)(char *str, size_t size, const char *format, ...) + __attribute__ ((format (printf, 3, 4))); int (*stack_getbounds)(); char *(*strchr)(const char *name, int c); int (*strcmp)(const char *s1, const char *s2); @@ -168,12 +170,13 @@ typedef struct CollectorInterface CollectorModule (*registerModule)(struct ModuleInterface*); const char *(*getParams)(); const char *(*getExpDir)(); - int (*writeLog)(char *format, ...); + int (*writeLog)(char *format, ...) __attribute__ ((format (printf, 1, 2))); FrameInfo (*getFrameInfo)(CollectorModule modl, HiResTime ts, int mode, void *arg); FrameInfo (*getUID)(CM_Array *arg); FrameInfo (*getUID2)(CM_Array *arg, FrameInfo uid); int (*getStackTrace)(void *buf, int size, void *bptr, void *eptr, void *arg); - int (*writeMetaData)(CollectorModule modl, char *format, ...); + int (*writeMetaData)(CollectorModule modl, char *format, ...) + __attribute__ ((format (printf, 2, 3))); /* writeDataRecord ensures that the header is filled in, and then calls writeDataPacket */ int (*writeDataRecord)(CollectorModule modl, struct Common_packet *pckt); diff --git a/gprofng/src/data_pckts.h b/gprofng/src/data_pckts.h index 484edae9edb..eecd4e905f3 100644 --- a/gprofng/src/data_pckts.h +++ b/gprofng/src/data_pckts.h @@ -51,6 +51,7 @@ typedef uint32_t Size_type; /* size_t for 32 bit apps */ #define SP_FAILED_UNWIND_MARKER ((uint64_t)(-3)) #define PROFILE_BUFFER_CHUNK 16384 +#define fld_sizeof(t, f) (sizeof (((t *)0)->f)) typedef enum {