[v2] GAS/MIPS: Add mips16-e-irix.d testcase

Message ID 20231009070931.3437078-1-yunqiang.su@cipunited.com
State Accepted
Headers
Series [v2] GAS/MIPS: Add mips16-e-irix.d testcase |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

YunQiang Su Oct. 9, 2023, 7:09 a.m. UTC
  The Irix 5 and 6 assemblers set the type of any common symbol and
any undefined non-function symbol to STT_OBJECT.  The symbol "g1"
in the testcase 'mips16-e' is an example.

We add this testcase with helping of ${imips} variable,  so that
we can run this test for Irix triples, and run mips16-e on other
mips platforms.

gas/ChangeLog:
	* testsuite/gas/mips/mips.exp: Add imips to mips16-e,
	so that Irix can use different testcase.
	* gas/mips/mips16-e-irix.d: New file.
---
 gas/testsuite/gas/mips/mips.exp        |  2 +-
 gas/testsuite/gas/mips/mips16-e-irix.d | 50 ++++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 1 deletion(-)
 create mode 100644 gas/testsuite/gas/mips/mips16-e-irix.d
  

Comments

Nick Clifton Nov. 10, 2023, 2:21 p.m. UTC | #1
Hi YunQiang Su,

> The Irix 5 and 6 assemblers set the type of any common symbol and
> any undefined non-function symbol to STT_OBJECT.  The symbol "g1"
> in the testcase 'mips16-e' is an example.
> 
> We add this testcase with helping of ${imips} variable,  so that
> we can run this test for Irix triples, and run mips16-e on other
> mips platforms.
> 
> gas/ChangeLog:
> 	* testsuite/gas/mips/mips.exp: Add imips to mips16-e,
> 	so that Irix can use different testcase.
> 	* gas/mips/mips16-e-irix.d: New file.
  Approved and applied.  Thank you for submitting this patch.

Cheers
   Nick
  

Patch

diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
index 91cf8b11077..96f7c554eeb 100644
--- a/gas/testsuite/gas/mips/mips.exp
+++ b/gas/testsuite/gas/mips/mips.exp
@@ -1242,7 +1242,7 @@  if { [istarget mips*-*-vxworks*] } {
 
     run_dump_test "comdat-reloc"
 
-    run_dump_test "${tmips}mips${el}16-e"
+    run_dump_test "${tmips}mips${el}16-e${imips}"
     run_dump_test "${tmips}mips${el}16-f"
 
     run_dump_test "elf-consthilo"
diff --git a/gas/testsuite/gas/mips/mips16-e-irix.d b/gas/testsuite/gas/mips/mips16-e-irix.d
new file mode 100644
index 00000000000..52459cb97f7
--- /dev/null
+++ b/gas/testsuite/gas/mips/mips16-e-irix.d
@@ -0,0 +1,50 @@ 
+#objdump: -rst --special-syms -mips16
+#name: MIPS16 reloc
+#as: -32 -mips16
+#source: mips16-e.s
+
+# The Irix 5 and 6 assemblers set the type of any common symbol and
+# any undefined non-function symbol to STT_OBJECT, 'g1' here.
+# See `mips_frob_symbol` in tc-mips.c.
+
+# Check MIPS16 reloc processing
+
+.*: +file format elf32-bigmips
+
+SYMBOL TABLE:
+0+0000000 l    d  \.text	0+0000000 \.text
+0+0000000 l    d  \.data	0+0000000 \.data
+0+0000000 l    d  \.bss	0+0000000 \.bss
+0+0000000 l    d  foo	0+0000000 foo
+0+0000000 l    d  \.reginfo	0+0000000 \.reginfo
+0+0000000 l    d  \.MIPS\.abiflags	0+0000000 \.MIPS\.abiflags
+0+0000000 l    d  \.(mdebug|pdr)	0+0000000 \.mdebug|\.pdr
+0+0000000 l    d  \.gnu\.attributes	0+0000000 \.gnu\.attributes
+0+0000002 l       \.text	0+0000000 0xf0 l1
+0+0000004 l       \.text	0+0000000 0xf0 \.L11
+0+0000000       O \*UND\*	0+0000000 g1
+
+
+RELOCATION RECORDS FOR \[foo\]:
+OFFSET +TYPE +VALUE
+0+0000000 R_MIPS_32         l1
+0+0000004 R_MIPS_32         l1
+0+0000008 R_MIPS_32         \.L1.*1
+0+000000c R_MIPS_32         \.L1.*1
+0+0000010 R_MIPS_32         g1
+0+0000014 R_MIPS_32         g1
+
+
+Contents of section \.text:
+ 0000 65006500 65006500 65006500 65006500  .*
+Contents of section \.reginfo:
+ 0000 00010000 00000000 00000000 00000000  .*
+ 0010 00000000 00000000                    .*
+Contents of section \.MIPS\.abiflags:
+ .*
+ .*
+Contents of section foo:
+ 0000 00000000 00000008 00000000 00000003  .*
+ 0010 00000000 00000008 00000000 00000000  .*
+Contents of section \.gnu\.attributes:
+ .*