From patchwork Wed Aug 23 14:39:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Iannetta X-Patchwork-Id: 136685 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp507373vqm; Wed, 23 Aug 2023 07:43:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmzd+Zg9W5w9ROZ3c29dtOV2T7ln1OkRhEDRfJP+Od3Xfn9xCaG3Xh5oRU/4AWnL9WQK6v X-Received: by 2002:a17:906:20d5:b0:9a1:eb67:c0cc with SMTP id c21-20020a17090620d500b009a1eb67c0ccmr1100138ejc.34.1692801807594; Wed, 23 Aug 2023 07:43:27 -0700 (PDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id x9-20020a170906b08900b0099414f17dc4si9866238ejy.431.2023.08.23.07.43.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 07:43:27 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="EgMKi/8H"; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 309A33839DE2 for ; Wed, 23 Aug 2023 14:42:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 309A33839DE2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1692801729; bh=djY3ffdxzs1pey+SI3c+aiEIymRJ3WuS+/JUxOnZ8To=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=EgMKi/8HZgBwNu64o4cpAZ9QGxOXEpB0RRqEDLFCxJvEPp8brMgFUSMqtRD5CvJdf n4yTSsAkqkGCZKgtbCXi403fGcXczsTtnfah86QXUgtnTVx5Cit+/Z/FXYIJIu0vW9 7nJBFQ0P0TPz8z2pXobhOFOLa7zn8c9y0h18VA6E= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from smtpout140.security-mail.net (smtpout140.security-mail.net [85.31.212.143]) by sourceware.org (Postfix) with ESMTPS id C9DCF385735A for ; Wed, 23 Aug 2023 14:39:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C9DCF385735A Received: from localhost (localhost [127.0.0.1]) by fx403.security-mail.net (Postfix) with ESMTP id B56839B8CD9 for ; Wed, 23 Aug 2023 16:39:40 +0200 (CEST) Received: from fx403 (localhost [127.0.0.1]) by fx403.security-mail.net (Postfix) with ESMTP id 896339B9AA4 for ; Wed, 23 Aug 2023 16:39:40 +0200 (CEST) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-mr2fra01lp0103.outbound.protection.outlook.com [104.47.25.103]) by fx403.security-mail.net (Postfix) with ESMTPS id D946E9B9D0A for ; Wed, 23 Aug 2023 16:39:39 +0200 (CEST) Received: from MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:33::22) by PR0P264MB2949.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1d4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Wed, 23 Aug 2023 14:39:39 +0000 Received: from MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM ([fe80::aeb6:2f26:45ff:5461]) by MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM ([fe80::aeb6:2f26:45ff:5461%6]) with mapi id 15.20.6699.026; Wed, 23 Aug 2023 14:39:39 +0000 X-Virus-Scanned: E-securemail Secumail-id: <663f.64e61a2b.d8d51.0> ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jCfPivLqrfBfXEfzaXaiGpuD7ActEFCOxqOxtL0UxedcyPObBXKAHhS+En96Z7VoE2OEkVYMfnvC8mA62sUTg73Jbnk4blYN5UB32Ii6bWCdm/DcWoCYoIvZP5/O5O0YIsW58oM+lODfIAK+FZvQg/IStH6RwwevqxTSj+bLchVlQIcYpWNI8yU5UhOrCJFK4KIAitvXavcYE+1sU+Hgbg14RLkwBEX0jUQ30dCcyiYKnRdQJFh3mG2kVf8JX2CBvIoicemr2T93Mu/Qz8buwIcZ0mZWJv+r1vqXwqyxLLdkJhSvN9pILLGdP4rFxQKpIo4wTDVayAg8vVMl2PBkzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=djY3ffdxzs1pey+SI3c+aiEIymRJ3WuS+/JUxOnZ8To=; b=GMNX5vKt77SYPAoZKrHmUFy8nZYl9rBHxGBdb+OKl6wnT4E5QYllE7N/70UiO5tRAEIwpgKCAj5cnKzIyhdiT/1gRRCRzSvA6WSdjLr2qiiHP/2/SiYlyvZpd3UqHMCTOOQ3TvsnpeE+NG2j6AATPIqOg73deT9ZPetw0i0qftXDr/3rzXIanF6lwEKDVz0Wp+8tFr0LE3msQtLX9YpPIhK+vHE/KTCrX6w4HEy58Z0DCtaVv50u2PpATW7DjAXNjZnnEmeU5fZpU59/0OU/d5UwZhvdr9WBjWy8URCNncJ4ffCnOQEnNdN+JJwDVFKoON0i+JgJsCdERjDfkevegg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kalrayinc.com; dmarc=pass action=none header.from=kalrayinc.com; dkim=pass header.d=kalrayinc.com; arc=none To: binutils@sourceware.org Cc: Paul Iannetta Subject: [PATCH 2/4] kvx: fix handling of STB_GNU_UNIQUE symbols Date: Wed, 23 Aug 2023 16:39:21 +0200 Message-ID: <20230823143923.10105-3-piannetta@kalrayinc.com> X-Mailer: git-send-email 2.35.1.500.gb896f729e2 In-Reply-To: <20230823143923.10105-1-piannetta@kalrayinc.com> References: <20230823143923.10105-1-piannetta@kalrayinc.com> X-ClientProxiedBy: AM0PR08CA0007.eurprd08.prod.outlook.com (2603:10a6:208:d2::20) To MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:33::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MR1P264MB2482:EE_|PR0P264MB2949:EE_ X-MS-Office365-Filtering-Correlation-Id: 01bb4497-3a8d-4109-4858-08dba3e6c7ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IyvxH0BhNzR0K2tuJvAb+eggCVDmAqMf5MMoSJLWPx7yOHamdeu4QphOcVzYqBdrZhWEVsaNqBy9lB97PuPnrhnwH8B3+xlYUgQBv3G3bQUipsHxEgvZPm0OJQpmu1Cc//EUe6CKVeAJvkDnRCn9yUjAwZ3bAa+d7p0HcYDFs86Ymt1UjZ1DWdp1MKi2oVH+uJVjmfaI2FHa/KWoQwuyneNqIdZeFEUVZE30PCM21rVung6EY+XwPHBy4tvWwzdcjLT3hfriWb5r/S2JjwTu9FoEUywqTNh2YgXuM1qq/90XeJD8LfAO/g4uXH6dih6hvIDSNGRuXh8ayfz34y6GCocgrAryshKMPjk0kBqGgTh4ROt6yvsh0wgIhyhP6xNMCr6jy5TwE3Q9F7RhkCxporL58yLGIfF60CMM0SjYSXzm0xvvXyIDxg2yZRtPgyDpnRbZn17Z6PIR3OWGdmA1UXUdvukCoyeGrPg1tFQ1rAkiF8d/kUMAPMIt6WWR56iOi3PlfjvWd2zrX5o5M5SXkPBxcRCAM3t8DD0jPIxKy3eHCvyrl7EF2DqoDDWh7PyJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(346002)(136003)(396003)(376002)(451199024)(186009)(1800799009)(2906002)(6506007)(38100700002)(6486002)(83380400001)(5660300002)(26005)(86362001)(8676002)(2616005)(107886003)(8936002)(4326008)(316002)(66556008)(66946007)(6512007)(6916009)(66476007)(478600001)(6666004)(36756003)(41300700001)(1076003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yZy0TBGBRCet7ej/i1BhgvVrpHuYumgYXAZnD5YpdgNUoqyiDY4djRhjItFRP718nU7tcfZiE5qL3aXwRPS84IbS6wOWTAWcKl/xRIl23qFpZZfRo6CTP7Hcts4xNMamSJIrTHbkUdyQ8twOTIK3mpLrzH0PVKaf1F/wSU/7bGRxUT5spvrKC8iBYsApBwJKhA3vy+exp9BbX3c+hQe/5BfYjAEfgEkabFAi5zJ4tbr92+KU+okLGc7UlYRqy+Oc9tDRag+H0IUH61cM8LH32W/laZ+iD9zYwROu4UqPziHydtKEMa1ZNDSp2Rvd66LYXyvCeHASotm83VaabU7UUSpZ4PYrI+ZUBWMXBz8jPSs0Ps3x52+arbG7ephriHOC8OM7xY5DnT6zD9Hw1fJVpnoAFLbagshFGg+GrriVzFU4SJjcL3stMCsOROk7Dg+BKuSyvXIxkHjLc6ZIXHLfv6fYxcsPqf3UgiRyaLaOjdHsko74+1R06itZgfO0hDyMSJlT3SbUjaOyj86n5O91poekO5ix0VRKqRxm4nGK33Cs7xRS7QdfEJ610Jed+9QM/LkRjtERtNequ3MGRyvYk80QmvZUxQPXvUw6kb1LE4aBuTcV5VK9xj/3RAbY6bXgSTWC0cVxUPseCeccod/T8i7u0thV74EUjimbWo2OTXsBfXY0s+FAvhWNnHfctYFI0GOgtRJ+zkRJRrZq5swwoG5bwmT24SSHkaj/m8KPtdVE5qiq2EFPuwSDH9HwBcRpMCS0lXiz/ed8qCgkIFPMYPW94mGAACQUF4bhnuIvLG+bVbVkwOvFX/VrHkXHeXI52lGFQEjeZe8syF5Llyje2ErXdttKQ+knufpBZG8uVqF3QHalIjFFuKyMFmaDtZMyR28P2C53UIFj3Bw7B4B9EnyPJR0NCOuSILETLc80XMY0DXKWr6gTRt01oq/AVlaS /+SiU2VZRC5j7B2L9hNa4nA6E/vTq6MQR/5mMeqncg1cMEUdXEH53ElvjDXEUKvYF8XLO9WYWVePofyYOCzIGtziN7OP33NKlTFAzPyCJQ6lOeODei+e7o7IIkTsWsaciUTfICtugKPDokYxw4+Xdq9ZwtLZnGxmYFfcAZusciZVNpQwVLz2Jej9IV8Ns8ika3uZGmDe8jozxwkDmUmuyiS8AxWgUm+x4vjwLEbawOc2Nx99KDDsqCMF9pNb7XUTwZNKzXfycA/QSEg88OQ6nbkMj9X2k3GBymExCAyXHYcWFkvhVLYv2zXNX7h0HhMkDIEs9Q6S6Wk/4JpHYbkxXYznKMmO5fQ/R6jOsGL/9q/aAkJe6USBbCLdlwwEUaKg9jbb6cbYTts8PniuKYgr5oIsRisAp62HF7fY2JQOC4S7tCLMLDkt3VtGtpa24tEqcEPysn/hP2YgI1E+kDhDBiGRzHSyxXpw4JG/GWFmNxsWR1mfUCUsN0ca42TSQg9JzEGgkdCrJe58i9RZhivp3NQ2Lf3IPUDfW77sMf8HvCG8a491P6/4J2M6/jPfgkI8ZaK41CwDAwAOq0Ask6kgDbmzmhTrbdcy4Uy0+S1ZWp+21Ho3LUVVUaVFP4c6jRREDFmvVWOXRx6mbiAIBpVmzw== X-OriginatorOrg: kalrayinc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01bb4497-3a8d-4109-4858-08dba3e6c7ad X-MS-Exchange-CrossTenant-AuthSource: MR1P264MB2482.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2023 14:39:39.1843 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8931925d-7620-4a64-b7fe-20afd86363d3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B1rqglQOHtu18OozgYJpwxLsNiZatykS23lx4BBQJUyyqSi9nw4Cik7iZVZN3h9YdRtXvJUilc/EPM8ChLQylA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR0P264MB2949 X-ALTERMIMEV2_out: done X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Paul Iannetta via Binutils From: Paul Iannetta Reply-To: Paul Iannetta Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775031348252658953 X-GMAIL-MSGID: 1775031348252658953 When processing a STB_GNU_UNIQUE symbol we did not update has_gnu_osabi correctly. gas/ChangeLog: 2023-08-23 Paul Iannetta * config/tc-kvx.c (kvx_end): Do not write to e_ident. (kvx_type): Properly handle STB_GNU_UNIQUE symbols. --- gas/config/tc-kvx.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/gas/config/tc-kvx.c b/gas/config/tc-kvx.c index c5c8312922f..be8bc7da923 100644 --- a/gas/config/tc-kvx.c +++ b/gas/config/tc-kvx.c @@ -2205,7 +2205,6 @@ void kvx_end (void) { int newflags; - Elf_Internal_Ehdr *i_ehdrp; if (!env.params.core_set) env.params.core = kvx_core_info->elf_core; @@ -2218,10 +2217,6 @@ kvx_end (void) bfd_set_private_flags (stdoutput, newflags); - i_ehdrp = elf_elfheader (stdoutput); - i_ehdrp->e_ident[EI_ABIVERSION] = env.params.abi; - i_ehdrp->e_ident[EI_OSABI] = env.params.osabi; - cleanup (); if (inside_bundle && insncnt != 0) @@ -2277,7 +2272,10 @@ kvx_type (int start ATTRIBUTE_UNUSED) type = BSF_ELF_COMMON; else if (strcmp (typename, "gnu_unique_object") == 0 || strcmp (typename, "STB_GNU_UNIQUE") == 0) - type = BSF_OBJECT | BSF_GNU_UNIQUE; + { + elf_tdata (stdoutput)->has_gnu_osabi |= elf_gnu_osabi_unique; + type = BSF_OBJECT | BSF_GNU_UNIQUE; + } else if (strcmp (typename, "notype") == 0 || strcmp (typename, "STT_NOTYPE") == 0) ;