From patchwork Thu Aug 10 18:48:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Mezentsev X-Patchwork-Id: 134150 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp615884vqi; Thu, 10 Aug 2023 11:48:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJnzd36k/pg3DEfWhaLRG/ENZh/Vebj1KhW6V3LYzjpZoiflMz9G03mQOJzh86026o0ygt X-Received: by 2002:a05:6402:6c9:b0:51e:1643:5ad0 with SMTP id n9-20020a05640206c900b0051e16435ad0mr3099985edy.8.1691693329539; Thu, 10 Aug 2023 11:48:49 -0700 (PDT) Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id d5-20020a056402000500b005234f7441fdsi1958158edu.322.2023.08.10.11.48.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 11:48:49 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Sgrp+Olt; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B11E3857709 for ; Thu, 10 Aug 2023 18:48:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B11E3857709 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1691693328; bh=wzPV6zmVIS/oiB6r7nnDW2pztLH8Wz7bX8K9opOtZWw=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Sgrp+OltbMYiXLtMZav1QpRToqUqmCxdtjXiXUC9U5vFOlfqbMwOUBYTPM8UFRfdg E8hKzeNlfo8WxsQso6H8uPz1J56BrTAcBGLO1dw9ITrX5cUtA8wkph2j34PX/aOUxy wk000qH/L+e6hN1Is9hGt1gzW1N4bQcsrRSwTTVM= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 393403858C78 for ; Thu, 10 Aug 2023 18:48:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 393403858C78 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37AIcN49023313 for ; Thu, 10 Aug 2023 18:48:38 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s9e1ubu7e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 10 Aug 2023 18:48:38 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37AHgjBw018462 for ; Thu, 10 Aug 2023 18:48:38 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2177.outbound.protection.outlook.com [104.47.59.177]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3s9cv9e82e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 10 Aug 2023 18:48:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g5U6vbdvRu2MSEfyTJtfCeLYPudCCMKDxOaMEy2PoUGpc+2uUF739Pb5st2+7QYS9tGnBhBg8pJm14k9viwXGB8Zew2Y+HVLYL/ZoOArTCfqxsP9QAmbbFHzG3R4s33PqVa8SNhIJxwzwUwOdEZFDF2j7SzqztZ0j+BE3BFKrq1QMg1LJGExfJYjbQxJRq6VsbhK8KmvrGttC5caP69g91KQNDeXeRLZ2or2S4U6BBxu5sgDwCmNXtKDcYMPtg7Vd72P+26wX/sOKQlm0mTzmx8OmjG4mny7O1jBp2LV+9Vd6sIdnzhGt5Dg1OIx6MXzfP/UwtvRtPID9Akxx/reUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wzPV6zmVIS/oiB6r7nnDW2pztLH8Wz7bX8K9opOtZWw=; b=RXk5bznLqRo98R48TRGvEih3knndyTXTyUnzrANMD7DIXUtgdRIFlSxtPhAPxOaxnC+LwtyNQYooys28YlNgyqu7HASApgj7PiXKrLysK1pksRlS/+Ps+MzH2niCrsys7QidiMVms5KqCU9Mg7+ec0dzM1OAYHedJx3x9zFM6ycZ+0TnhwVUOtbiIjhij8DYAMuuuZ4Ki7gl5g79r2x2JQJJOXaAQ3Rpx2KoeQBYU4VtxdMY+6ki3cUvRThMT8A407JH6hlK4yQS03i3Yejtf5Uui4hmUVLZbzOq1V3RN0hGvC/grqzQzC8/N1NFqDiiWLlcLm+nlX42g1CMy7uGYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by BLAPR10MB4930.namprd10.prod.outlook.com (2603:10b6:208:323::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.30; Thu, 10 Aug 2023 18:48:36 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::a15b:c87d:10e3:5765]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::a15b:c87d:10e3:5765%7]) with mapi id 15.20.6652.029; Thu, 10 Aug 2023 18:48:35 +0000 To: binutils@sourceware.org Cc: Vladimir Mezentsev Subject: [PATCH 1/2] gprofng: fix typos in get_realpath() and check_executable() Date: Thu, 10 Aug 2023 11:48:28 -0700 Message-Id: <20230810184828.3014191-1-vladimir.mezentsev@oracle.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: BYAPR02CA0064.namprd02.prod.outlook.com (2603:10b6:a03:54::41) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|BLAPR10MB4930:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f68f876-7178-4535-e307-08db99d26704 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZnPDH6rFSR8oh/LQWrCX3wQTU1Gn3S4IT5or2lKBE26GM2TCr0saFYiWo0Odpc3HZov3AndkilV6C+kYvSjHo5h5qMHpbkrAx30jMEyIwWUj7ChbhZfFB0YKSGLW8KQ79yvF0tqerYk6zdrEhPDD+7OrNVVWUWPSFzKfDwcHV5Jy/63NHefZ/SuPGhT1YTv2pd9dnzuTyd3JvW+3cwn4elkntQwPwvMqvz2MAMxTxYI56DIFpeyWG8Bo1bOLpWLkkd+Xt/jsgAmkGg9QUgrwK8kNRpuTbcVIibs7MQFlUNRoxvBUg55UIjw68qnBSDLvdLXFt1ScwgHhlXYLXa3o3Qaeh2iI837CaYyESTRt2wX8/QlqwDIl9nLrO+SKTQ5ttrAmYkcOjML4sLtA8l+bOfDwSU/+VJ1MZJi8z/8HE2kLo9LPgqKETNQNVMDT/41QzQQniJp4NaNKR+QLYxLfzYbgcrvhwGiSpRXOd98Wb8rrv+VJ57bPJ29AWaVPWvXC9oNMsblMgEH4EiHEcdP0nY44D4KqwgmSro9a3iEKZYf/H/ybPFGDXp5oduQPxlS9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(366004)(376002)(346002)(396003)(136003)(451199021)(186006)(1800799006)(66946007)(66556008)(6506007)(6916009)(66476007)(107886003)(1076003)(6666004)(478600001)(36756003)(86362001)(83380400001)(2616005)(6512007)(41300700001)(9686003)(6486002)(2906002)(316002)(4326008)(8936002)(5660300002)(8676002)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Qd+v3dWuNc8haxa9QLnjRyLG6ipBhEKOvLVe2ub6zWcldTy1drha6l1e0hQUQj4o9pjaJxkRoBqeexr0idK/FrR8bklMLNiBF1xW+goLiQWzydE2donifU9jNn75ysLtoAqH3kkqMkC8hDRLNF37PZhcZ+6Ew68KTu+AvPJa+ksOuqDm04qIy72rLgwi9LiZ4jQAt2Wq/gnOkcKDNNw/+oRSoEpbiCsVRh/m9Ufn224dy1M3/U4u6jOsnf/mNOuwPTKVx4ckJWWuWHOi/eRz3zyeQWqAewZBTIP+gA15dfi3imL4gZGZI59adxPpv8Qs2tPEJwg1QKdSfVHGn98mO4I1wSElwNMhdIF40033Olzn3mWAaBDOtt6O1h9ABAnGvmd7kkOh29BVYxyQvftxED3kXAD5fs2nDue6aWBcrJp755ejaA+RoDdhsLqCVA76FHfyoUOwU5p8eOjRuwtSNXiEasKjm/ITHhSb6eqJKMpB/9OKFd+Uq2840D6sS9ZO2hP4Q/xfi90AmUj0xc9clGlILCOaEFM+/rKcRfMhSGA6pk12xm+h9tBQc6OLamHuwfrfpKjmkk/bgj3Nk56oWXVIjw4U7bK9XXTYmvfX1KXseOyLdQCC48+Kh3LLyey1NqQNB5NKGc0f2p2LKUeenX7Q7mkaq2Ym5RjRhZ2uLsShCB3kr9hq06nkr/EgX76uynyU46QmEfDlijckC2D8B8UR/mfFLcOhVVohg+UmXNx+rIKuprjsO0Oyq3AkDDyMVyncEpxsKxvK8eLpSqFxVCVJ18w9bdMEnxlju9YpojNPW6xb7cU/V1E8pmpTVFzJv8G3ZdDVl/0Ex8t3kH/80c/H+rzw65HJMTVu8kMoxLRpRnEG68a98IFLvOVa1OU00KDwDRXo1d3i7n7pO7+4dNI0PFmHE1q23pkZfcM8roNnCdnpaDkXG5wDNrGQhcAxWjVN+A0IhX9qBk1lmY0bs2TGKfVytNwOxrZgCUO7+GgeVewOksm/NvzzsSNK998g3jtNqttVM7DsOUR1mrDl/war/F81Uni9slUv8OaY9wKPot00aUIPAi7pgJkc/d+QqEyloDjRMmWu65RUYPvlzO1fT68KeY4kzw3TBsv2T7pdMWXJS68qSZS2VUX+gIN6fTx/o6dsyPvflULJrRfc3XYCRgiT11XMyV7HEgl1qKMelyubJbyIKmDUXG1VjtJv/Xysqyabov8GFFoMu2bqUj68SL0JlgYTyd9HcRGlDPptD0tMAOtHym9xqadR5jnf9R+BnIdF13CBtKZgxO508QD7ZaE4SeZWgTCjhe0IF4BkNBpgD3QoIZWZLpJU020M+dgcJBtLwiQlD+AUZ6p02qSai4ma/GQWkSS3qGhUprlNWXF6Rre3MUTIuy41M287t8gzhh8bQWpypitVqeBpCRkPUSxuTqSt1lJRTBTruHitskfjoL1OQ8PIfNvsoLsq7iypf/MGTteKduzkpfuWFThafcd/ES9dQU1eRlOc77iA/f16U9jMRaYmqvFYBJJqYRKbJhxUPX1Izc0P//ZbeSSZ1DIMMdwUdgAl9yJS+SfsT1qeRgdW5uYBCBxGjajEj9ITF3KpCwMj+XG69hJzGGauwkYGgtRluzUkDqhOOLA= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: yEyf6oiubH82TEF4ke+hYnuGe3nEiNG0Ff4M7cbjwIEj2xgGrIwEIsT4FjrE9GIaATx1PprwVOgX31ATGeV6a56pcc/gSlzRt5kw2PAmA+kQr5B72dUsHuc8/Wh+OThub8bPTqc83/Ev3waYjCquVJOWvyLxrDl6tZEdfMk5wMgsxmCKlvqBpB/A/Xs3G/s1czLQIW1CAteO8q1QrnEcvahZs4zHJKn0s6OYJn/BwVLR5Y5pcaimUKe/B2KiL/6dQJ728TJH2mhQj3+FuSjb+mv49GbH8CDwR3FM1rSGTNH+8y8GO2mGZn2IxObwE9QibePlFkJAKJMwgpJchfzQDdx7jxbNgOkq9Jx1T/bkYCIk6coLnW0QSA02YjXluda84tJZ5TzoyhFvHZX+8fFZAztpygTfI0XEilb2nleCraxvk9xlKdnqH1ecd1MrvmAfMI3Tj0gj/okxKWlUr/G8cdCtpq4ycjVKTEkIT6DLHWYuro5ZgTJNlXXWHOUiyTrr/Gn87b5QqYlXimgYNQuV65nJblfelQOW5LAbtniOI46JeMawfHlugcAZ3ZdgHFaZ9ijwXrBH+WKowF1mSUNFXSFKW+DTNXmqX2yVi4D4LNo4sJ9kSWSHRr1qVpFwjZ+deyp0SsHQf3tsZbNHbtQ33Ne9xmMqDX74zJmoAf212n9h8XxTT+1xTtmogYG46znzxp3oJS2vtZR89UT/Hi67qoSdiIUHG/shDx6pX3bKbmpivEKnf/YDgRSqZyOwuXoN X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f68f876-7178-4535-e307-08db99d26704 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Aug 2023 18:48:35.5434 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7ZVZofiBcwYZedT4NEPBO1jHU6O/hQJ41hWGF0bMo06/1z1O4/04DJGL5FjmddKOhvMqMqiSpmQ4b6Ir/rAi6FMl+SCVBbg/FAQcCuJEnHw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4930 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-10_14,2023-08-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308100162 X-Proofpoint-GUID: uKbr-Er4xF1fHs5SpmhnyLTcQaOoKMTP X-Proofpoint-ORIG-GUID: uKbr-Er4xF1fHs5SpmhnyLTcQaOoKMTP X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Vladimir Mezentsev via Binutils From: Vladimir Mezentsev Reply-To: vladimir.mezentsev@oracle.com Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773869024589285863 X-GMAIL-MSGID: 1773869024589285863 From: Vladimir Mezentsev gprofng/ChangeLog 2023-08-09 Vladimir Mezentsev * src/Application.cc (Application::get_realpath): Fix typo. * src/checks.cc (collect::check_executable): Likewise. --- gprofng/src/Application.cc | 3 ++- gprofng/src/checks.cc | 9 ++------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/gprofng/src/Application.cc b/gprofng/src/Application.cc index 84660646263..07e93c46945 100644 --- a/gprofng/src/Application.cc +++ b/gprofng/src/Application.cc @@ -100,7 +100,8 @@ Application::get_realpath (const char *_name) { if (path != s) { - char *nm = dbe_sprintf (NTXT ("%.*s/%s"), (int) (path - s - 1), path, _name); + char *nm = dbe_sprintf (NTXT ("%.*s/%s"), (int) (s - path), + path, _name); exe_name = realpath (nm, NULL); free (nm); if (exe_name) diff --git a/gprofng/src/checks.cc b/gprofng/src/checks.cc index 4524611956d..094c3bbc60a 100644 --- a/gprofng/src/checks.cc +++ b/gprofng/src/checks.cc @@ -261,7 +261,7 @@ collect::check_executable (char *target_name) { // not found, look on path char *exe_name = get_realpath (target_name); - if (access (exe_name, X_OK) == 0) + if (access (exe_name, X_OK) != 0) { // target can't be located // one last attempt: append .class to name, and see if we can find it @@ -293,13 +293,8 @@ collect::check_executable (char *target_name) return EXEC_OK; // do not by pass checking architectural match collect::Exec_status exec_stat = check_executable_arch (elf); - if (exec_stat != EXEC_OK) - { - delete elf; - return exec_stat; - } delete elf; - return EXEC_OK; + return exec_stat; } collect::Exec_status