From patchwork Fri Jul 28 15:20:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam James X-Patchwork-Id: 127697 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp508476vqg; Fri, 28 Jul 2023 08:21:09 -0700 (PDT) X-Google-Smtp-Source: APBJJlG0J7Gz+bjpRsecD3dWib1IhoI4jnqfu7Nb92hcs4LxhumI1ivCTguTD5mh0l/GBx+xFvZ4 X-Received: by 2002:a50:fa8d:0:b0:522:38cb:d8cb with SMTP id w13-20020a50fa8d000000b0052238cbd8cbmr1826790edr.20.1690557669689; Fri, 28 Jul 2023 08:21:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690557669; cv=none; d=google.com; s=arc-20160816; b=Vl40Xkh2wyYlxfwLCvpqHB2X76etBG4MucnDn5Acs82Mc0bZ2Axf9HilMvq5h8XEoi 8qohF9ncmXDxqr9j0e7clQlO4pZzEilL+Rmfseg/PoamcNn/OtQyvrB2Oojl50ER3h/+ 64TTtwt0fNj2698FBdukmAm6KG1ZX6/VjJb9r0yKJ8vFj5hh1pAJBXM1iY22ei5nAZzJ QRs4C+RKo35jdKK1M0VSg8hsApVh4Z9DDxFdtspOYWMjHZl1HGiaeVk6k3twrb95ZekJ so0BsA1rhuKeBljtvsuHrHvMgUy4GXEAQ1KTwfv6r+YCQmRe3/QedP2IFYAq73ELNFiP seqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=1tMn15YXeE+Os7ccEqKEWDIZrckI1rfP4ttHnX3dTdk=; fh=E2XOPncxGgHRMl5NZJaaKAP+TF6eOXmlKkE2kckcvEw=; b=qfC959+B4duIoWB/3ny5Znwgi1cFkcTFL+0t4shnx+NVoKiLXbfAeLuy3aYyD9DCPr I2ILQkAGa1sxrNNQ7Tu0DGEedMeam0Nni9nHrZao9WgvVgH3N1ddLQWE7S1g+tk1yYnC dpjf4bANaBzufgEmuCwhKlNwdsLVqQlTAx3i7AewFMJI7Z4AvlJVhhNpSq+eXcO9bnJT 4PjYxsDN9OcQtL3YwHPP49wvidoDUOwkdopWulHl2QSekiNv9J8DFy/CUrDJsaDC5omH gFI6FiRGvfgEdR4GNjAFijnVcNbcOIkF01RnvcXCo2vtZbUTv6d33XlFJAIewby4n2Ey nD9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=xUK9N3hT; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id h7-20020aa7de07000000b00521a9ae22adsi2746856edv.104.2023.07.28.08.21.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 08:21:09 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=xUK9N3hT; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 77DB73858431 for ; Fri, 28 Jul 2023 15:21:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 77DB73858431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690557666; bh=1tMn15YXeE+Os7ccEqKEWDIZrckI1rfP4ttHnX3dTdk=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=xUK9N3hTjOQaot6AfJ0r5RKPz1nBn0JGC78Udznlnp+w4p/s78rTCHnLkgFYFD3EZ IAmsyBpOED/Is/qJjK28zcn9wJZ+MTKeGQNxKcp9FZKmeELvtaMdXgnYbYD49vFM/w ADGprRNDehCr7s6TJSEnf6VuuBF/SqhpDpSUsjxQ= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 3725A3858D20 for ; Fri, 28 Jul 2023 15:20:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3725A3858D20 To: binutils@sourceware.org Cc: nickc@redhat.com, Sam James Subject: [PATCH] ld: Fix test failures with --enable-textrel-check=error Date: Fri, 28 Jul 2023 16:20:34 +0100 Message-ID: <20230728152042.401562-1-sam@gentoo.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Sam James via Binutils From: Sam James Reply-To: Sam James Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772678199224653285 X-GMAIL-MSGID: 1772678199224653285 Tested with the following: * --enable-textrel-check=error * --enable-warn-execstack=yes * --enable-warn-rwx-segments=yes * --enable-default-execstack=no in preparation for hopefully toggling these in Gentoo Hardened at least. This is similar in nature to 0ab7005043ee404dabfd690952efc25c399995ae and 340640f710e690b37c885166949595cde5f827b2. This fixes the following test failures: * FAIL: ld-x86-64/pr18801a * FAIL: ld-x86-64/pr18801b * FAIL: ld-x86-64/ifunc-textrel-1a * FAIL: ld-x86-64/ifunc-textrel-1b * FAIL: ld-i386/pr18801a * FAIL: ld-i386/pr18801b * FAIL: ld-i386/ifunc-textrel-1a * FAIL: ld-i386/ifunc-textrel-1b Signed-off-by: Sam James --- ld/testsuite/ld-i386/ifunc-textrel-1a.d | 2 +- ld/testsuite/ld-i386/ifunc-textrel-1b.d | 2 +- ld/testsuite/ld-i386/pr18801a.d | 2 +- ld/testsuite/ld-i386/pr18801b.d | 2 +- ld/testsuite/ld-x86-64/ifunc-textrel-1a.d | 2 +- ld/testsuite/ld-x86-64/ifunc-textrel-1b.d | 2 +- ld/testsuite/ld-x86-64/pr18801a.d | 2 +- ld/testsuite/ld-x86-64/pr18801b.d | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ld/testsuite/ld-i386/ifunc-textrel-1a.d b/ld/testsuite/ld-i386/ifunc-textrel-1a.d index 15f545db03d..aad77e7d230 100644 --- a/ld/testsuite/ld-i386/ifunc-textrel-1a.d +++ b/ld/testsuite/ld-i386/ifunc-textrel-1a.d @@ -1,4 +1,4 @@ #source: ../ld-x86-64/ifunc-textrel-1.s #as: --32 -#ld: -m elf_i386 -pie +#ld: -m elf_i386 -pie -z notext #warning: GNU indirect functions with DT_TEXTREL may result in a segfault at runtime; recompile with -fPIE diff --git a/ld/testsuite/ld-i386/ifunc-textrel-1b.d b/ld/testsuite/ld-i386/ifunc-textrel-1b.d index 6e4a67c48f0..bf0f2ac5df9 100644 --- a/ld/testsuite/ld-i386/ifunc-textrel-1b.d +++ b/ld/testsuite/ld-i386/ifunc-textrel-1b.d @@ -1,4 +1,4 @@ #source: ../ld-x86-64/ifunc-textrel-1.s #as: --32 -#ld: -m elf_i386 -shared +#ld: -m elf_i386 -shared -z notext #warning: GNU indirect functions with DT_TEXTREL may result in a segfault at runtime; recompile with -fPIC diff --git a/ld/testsuite/ld-i386/pr18801a.d b/ld/testsuite/ld-i386/pr18801a.d index 73cb5d17beb..b1ef145a882 100644 --- a/ld/testsuite/ld-i386/pr18801a.d +++ b/ld/testsuite/ld-i386/pr18801a.d @@ -1,4 +1,4 @@ #source: pr18801.s #as: --32 -#ld: -m elf_i386 -pie +#ld: -m elf_i386 -pie -z notext #warning: GNU indirect functions with DT_TEXTREL may result in a segfault at runtime; recompile with -fPIE diff --git a/ld/testsuite/ld-i386/pr18801b.d b/ld/testsuite/ld-i386/pr18801b.d index 0bf7fb729cb..983346ca248 100644 --- a/ld/testsuite/ld-i386/pr18801b.d +++ b/ld/testsuite/ld-i386/pr18801b.d @@ -1,4 +1,4 @@ #source: pr18801.s #as: --32 -#ld: -m elf_i386 -shared +#ld: -m elf_i386 -shared -z notext #warning: GNU indirect functions with DT_TEXTREL may result in a segfault at runtime; recompile with -fPIC diff --git a/ld/testsuite/ld-x86-64/ifunc-textrel-1a.d b/ld/testsuite/ld-x86-64/ifunc-textrel-1a.d index 64a1e7021fd..667366091b9 100644 --- a/ld/testsuite/ld-x86-64/ifunc-textrel-1a.d +++ b/ld/testsuite/ld-x86-64/ifunc-textrel-1a.d @@ -1,4 +1,4 @@ #source: ifunc-textrel-1.s #as: --64 -defsym __x86_64__=1 -#ld: -m elf_x86_64 -pie +#ld: -m elf_x86_64 -pie -z notext #warning: GNU indirect functions with DT_TEXTREL may result in a segfault at runtime; recompile with -fPIE diff --git a/ld/testsuite/ld-x86-64/ifunc-textrel-1b.d b/ld/testsuite/ld-x86-64/ifunc-textrel-1b.d index aeb31fdb3dc..f7b8e02a72c 100644 --- a/ld/testsuite/ld-x86-64/ifunc-textrel-1b.d +++ b/ld/testsuite/ld-x86-64/ifunc-textrel-1b.d @@ -1,4 +1,4 @@ #source: ifunc-textrel-1.s #as: --64 -defsym __x86_64__=1 -#ld: -m elf_x86_64 -shared +#ld: -m elf_x86_64 -shared -z notext #warning: GNU indirect functions with DT_TEXTREL may result in a segfault at runtime; recompile with -fPIC diff --git a/ld/testsuite/ld-x86-64/pr18801a.d b/ld/testsuite/ld-x86-64/pr18801a.d index 2b4159d3044..61f9d991185 100644 --- a/ld/testsuite/ld-x86-64/pr18801a.d +++ b/ld/testsuite/ld-x86-64/pr18801a.d @@ -1,4 +1,4 @@ #source: pr18801.s #as: --64 -#ld: -melf_x86_64 -pie +#ld: -melf_x86_64 -pie -z notext #warning: GNU indirect functions with DT_TEXTREL may result in a segfault at runtime; recompile with -fPIE diff --git a/ld/testsuite/ld-x86-64/pr18801b.d b/ld/testsuite/ld-x86-64/pr18801b.d index 34dab1aa6cb..967a339f90b 100644 --- a/ld/testsuite/ld-x86-64/pr18801b.d +++ b/ld/testsuite/ld-x86-64/pr18801b.d @@ -1,4 +1,4 @@ #source: pr18801.s #as: --64 -#ld: -melf_x86_64 -shared +#ld: -melf_x86_64 -shared -z notext #warning: GNU indirect functions with DT_TEXTREL may result in a segfault at runtime; recompile with -fPIC