From patchwork Mon Jul 3 10:50:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YunQiang Su X-Patchwork-Id: 115305 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp428578vqx; Mon, 3 Jul 2023 03:51:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlHgtPU9RCnwsV/Zze4M7W6lTvoRMAcpm+rpdsRxeO8t5ZxYxx3WXQqDETGFazTSzUfC7gAZ X-Received: by 2002:a17:906:5e44:b0:987:783f:449a with SMTP id b4-20020a1709065e4400b00987783f449amr5829653eju.11.1688381465758; Mon, 03 Jul 2023 03:51:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1688381465; cv=pass; d=google.com; s=arc-20160816; b=BeARBl3UEIWMo821Qe0J6SO0lVRopElBc2KjA3Zv9wbkNFMgHBVN/vU4H24Us43pu6 bgj/03uCLhcU5RWzAlUiA3Cnr9XaF/hujXNqLHZhReONV+fCcEIOXBFMK6CGT4rzvii6 0fu/X3q4+7VtKwHWNgs9E3NDRGyVU4WrM8YFMpx9XspnT9rn+aBn5AOr6fg3DkYNoLGQ MzyS6TVBn6s067LFeecKucS+7sirIqn7/INQ7ADaZDuZxckZdMlQb+cFh5bOdZFqKhQ8 phUVbwWWIGIQebY0xjHkGvkPzOY6iP1vEckwsVCz3MNaZvHVJbOXqL27J5RIZ2SQdo0z +yOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dmarc-filter:delivered-to; bh=L1I8NgdloLdNAvWWuWe8U7Jp8Yj0blX9lIZEdeTaJqM=; fh=j7jXDC/uFDGL8cxf6cfXp7wjPYpkTHIAVhaTd8yNQ1g=; b=EglRgv4AoxjxANd/qjz62hyg7DFx/OP33OSHjzSO5FkWNVJ/P2gzxnLgBqxRxoFMQh qlrxhaD2dz867/nTmcrDieVYTEtszHFwMEDvrAWS9+4G/Du8/CVautr6+NzjBncZmo16 LUrTwa7zmEVc7gmicU+pLtAgVMEwF5Zs1Iz8G9SN+bA7wjLDb9lVOfTJ3tNc++OMPema 9FEeKQH/MfM+Arwxx5NPSbb14DmbKdso9GWWRgr+kNpiaBdb/iDkAreomTZYUeTGNI+1 NlEmQh7MBugzx/LFVHM1lZ/0G6l1o0nDVi6qGdXpwES/avvWRwB+q+68CMqzeaE34Tp/ KFJQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cipunited.onmicrosoft.com header.s=selector1-cipunited-onmicrosoft-com header.b=LIN0d7wD; arc=pass (i=1 spf=pass spfdomain=cipunited.com dkim=pass dkdomain=cipunited.com dmarc=pass fromdomain=cipunited.com); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id t13-20020a170906268d00b00992aea2c6a6si4829356ejc.977.2023.07.03.03.51.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 03:51:05 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@cipunited.onmicrosoft.com header.s=selector1-cipunited-onmicrosoft-com header.b=LIN0d7wD; arc=pass (i=1 spf=pass spfdomain=cipunited.com dkim=pass dkdomain=cipunited.com dmarc=pass fromdomain=cipunited.com); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BF9933858022 for ; Mon, 3 Jul 2023 10:51:03 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2131.outbound.protection.outlook.com [40.107.255.131]) by sourceware.org (Postfix) with ESMTPS id 0AFA23858D1E for ; Mon, 3 Jul 2023 10:50:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AFA23858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cipunited.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cipunited.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CDixQRmnzihs599SyxR6+fttSktF04JxQTHpAiugtnIYz7x/CtsM/79xag/2uxoJAlKaJAYCcDqhEK1gY78X19u3Ujg/ZMiH9gUV1hdO6oFV3+T+Ejx9RTwfQv7sYgK3QvnbkDMwihmhNRpxBTpRf8gcaYKQDgRhi+bniinH+86r2tq7dYbxPFG6j53dgyAk9Bt7UvtWOPW+88b5xPkGFro+SUSdfijLMw/7PjqRxugqtXHAep1DeKh4hNIQ46BKGtddwcUXyUJ3UoT+XmFUim7T/qNIgFg502Nrz+NfUVmTb8bH3tZz2611/tCIxfZHfUVPZZ5O68OssasP1axy1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L1I8NgdloLdNAvWWuWe8U7Jp8Yj0blX9lIZEdeTaJqM=; b=eB/ry2N6PndBlnveviBcYGSbb0SDyvyOy9pZYoLaQ28DUsZQs6bDfIs/QPaKAbYsLpCxq5h+WDcSwDDTxoxpaiFKXGz5he1z1ihXI5Wn7ryTNBCDxcs9hzQ68akMK32s5b8UWsunmECvWWnPST5b59yJlTMd4mUAxHAztehuo1Y43RdXzrKG1aC4WVYYg9hXDdICYYyQrscnYMI0D80S+ozsh7xv2k/swpGarZR+jzP62XSGaPQwxnl6/S0RUtGQNJLQNlizAG2KEHInoxu2ikdwqO4lS84vP2u+4yJjkUVYboRWzoMeftvnME53KtsFHnzEF6K/SM0fpyZ/YqnFEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cipunited.com; dmarc=pass action=none header.from=cipunited.com; dkim=pass header.d=cipunited.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipunited.onmicrosoft.com; s=selector1-cipunited-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L1I8NgdloLdNAvWWuWe8U7Jp8Yj0blX9lIZEdeTaJqM=; b=LIN0d7wDEYVrolznBewv1TDFoJSOpSqw4+s46B1bfUIaYp2OQXRO6sXuIuSGhTNamMiRgobjnx1sXJ9yaOcAmG7F2egFMv4/Pfl93M+sol/OVrJ+PgWX9JIYBZ+PkRnQ4qPS6wYIsu1ra+GttiNxmhw698LQtsyDKK4BY//6mJY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cipunited.com; Received: from TYZPR04MB6117.apcprd04.prod.outlook.com (2603:1096:400:25a::9) by PSAPR04MB4422.apcprd04.prod.outlook.com (2603:1096:301:2b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 10:50:50 +0000 Received: from TYZPR04MB6117.apcprd04.prod.outlook.com ([fe80::d2b4:bc09:619a:118c]) by TYZPR04MB6117.apcprd04.prod.outlook.com ([fe80::d2b4:bc09:619a:118c%6]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 10:50:50 +0000 From: YunQiang Su To: binutils@sourceware.org Cc: macro@orcam.me.uk, YunQiang Su Subject: [PATCH v2] MIPS: Don't move __gnu_lto_slim to .scommon Date: Mon, 3 Jul 2023 18:50:34 +0800 Message-Id: <20230703105034.3163572-1-yunqiang.su@cipunited.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230703103647.3162351-1-yunqiang.su@cipunited.com> References: <20230703103647.3162351-1-yunqiang.su@cipunited.com> X-ClientProxiedBy: SG2PR06CA0181.apcprd06.prod.outlook.com (2603:1096:4:1::13) To TYZPR04MB6117.apcprd04.prod.outlook.com (2603:1096:400:25a::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR04MB6117:EE_|PSAPR04MB4422:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a1e6463-2f72-44da-ec82-08db7bb35d84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zhsujo90PCFsB7fHn3TJVVB2lGVtt7yCOGdVFw+rjTIvDQjkG797aROxUIqPjyN5NgOOimfhuNDRbpy2Z5aZi5CH0EGQvYPxndakyFigK723956QKoDuk09tMcn22gkIwV49QnztmTd5JDUhs9QYRT2XDaMvOlE4zqiXMbx6rY6x4nuVXhoLw8y+TMkumbptW/UT6zlT6o/h0TWm1ggrjobrOHcGJlGeyQqqw+3qURiaGl59GMlLEZ30PV7pzqkwyETFtWV2VyFn562cjpoPVpLmsP8HUYzrA6OP4neVi/F2PMEJmrHEsRNRbbVbrOKdFKrC1f2Ml6z/NmA11aYOc82FGOPwfgh3TlNP8Liar2vASXID9os58dDvbqzal9US24OkTr9DJdLD8qDnNj0Bplzz3wUHBx0WORL9Vsoww4jst6jJg6nBwSwH7YpE9iAgUHoo3PkSL0sRMqTXsx4Z+aEkagoq5obNAW4akLl8QX8LaRZw5HoZtxxD8b3vMcP0Ie27M03oizr3Vz/aEcdxkpaeuyCpQ2F1QSwAKul41qLvx2oiiwQl4wBqNxekuKyARkg90H5Cs6w4ZYA3UUa8t26sqNFXrivF2M7nB5te9WYPsvj+b2i3Z6XL2mIHzS+h+rih7kswH/39b0csgMJ33A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR04MB6117.apcprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(396003)(376002)(39830400003)(346002)(451199021)(4744005)(2906002)(41300700001)(5660300002)(8936002)(8676002)(36756003)(86362001)(186003)(2616005)(478600001)(107886003)(26005)(6506007)(6512007)(1076003)(6666004)(6486002)(52116002)(316002)(6916009)(4326008)(66476007)(66556008)(66946007)(38100700002)(38350700002)(83380400001)(142923001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: beIBMaQd/owzHsdtu5AI/LqZZgb9yQcb5JVElX6LS1AF1HXh+qwO3xb8DqCI1id/qWsaNd9LeAVOrg1vkit2f94bOWsdZkMJ7nzdpVTpFsRfSJBmXJt+Fi/WQ/m5xK7aiAZ3+jx2EVFrxf9xDM/Ra431pG39ZjdHiLbMtTYw7YInqrcNt/xf7a7P2HkNT3/qu//4K24jnmInrzCdLgmWocK+hBNWNk2r8r3ROMk9p/5hk34JI9hbL/b0m8DJi1MIQkVUumT7Cpp4y3BX2maoINsrukW/d9DiI8xckXLVE9PWNTCvYkXbw2Mymwxb60gHRtmxW0gSPouXIaw0tsVy1jVRJQA2oJuKlrmGPlDFOW9iLvSHON8PVZDQNZuF5m2Gym5vVTR59Ba+dUIDEwpIdTOhpsFTzVV3415JbiwMSNrB6Zu0YRJ3MzB3wZ15Ilcj+RiWGHKYmU2qQP1qsSHw32WhUCLp/HmQq1Kxh5D07ksaBshdWBkmK4o0NmcbIPgpb/6CwVLCkhwPbphW7S1RvvTll8FpIAPNFqGIhfwPlxs85uzq07X7pTFrEZLZO9TYFt2CcP0io4dMsV0VGcY1aUpAZizdcFQv9rNtPrQHGLbLM18D/ZjFIKpc8KHJWkz8Lu3qKK5RaGlSyLFWVos8cRAy2jKogk3aGx8L4SCqW4LbA5MSf5hhgAWwjt1fB+ficCGBy/rqxBy7manEIm+fE0NyM9ks/BBp+tedE85cZXtaMyHI+IIfhhWCKD31q0IxRpKeJ47TakEeFGaqXjgGrVNCpOqrD0w6bAoevJe7dyJHgL7gncrLGpZYLzEmUY7o2yhKuwUDe4KOmPHRZmQrGc/b2fZs/Z9kuGaK61SGMUY76eJWGAJnoLixHXh2oljuqvMiw9BtXpkLdAe6hW5Yi6f+9Dzc37HQFHhnxCaK+0GgR2Gj8LTiDTXQj1sSTxLK7dFZU58VmdGukDWFtkuVLAy1hzwlXqE4j/Akg1Xz8Zaoe66kELKgYcqNwB8OpqQbntFEE2LZuwGxgZp97NEx7YHwCV2GAEKGWMBtlJre4VNcqzHA0gGYs8vrAAPbKg7vWv81hrWCToi5pEcue7Qbz9P9s4jUE2qdXfp35VlSTUck39WUCiY4y2EwriLtgT61FRV9/jk3c5r5V68Yph7ujn9JhGQKvcrzo6VE5q52xMoGvQiarWgJRQEbc8zymsvvpF62g4WG1DUT5JO4uL1tupRkWclbziieHNzWUZJzW7DBSQ5HOtsgGIxgWowu7Pqo98o/CJFbN99hSC0De366pLFkfwprediZt69F4HThB3IxIKyB2PINBd8X5d6XOgsEDJvFRqiQbK9BXBAUzgu4In5xhhysYQSfvei7GZrbe/ew5qeuxZw1qd2Tvfzx6QBPxdgKv4lFrzIvb1wh4oCcjqdbh+fGsA46thojwfj2q+No84H0y86oath+slzflxOTzaG5DYUBPtfXmpKtK6BmaypLvJjjxeYnf7wOlygmundpirqbkPRr/AYcNZiHpdUU2dz+hC2AP+3b3Fk8EO3S4fsFRyrvsOmWkk3MxJDWcuEyZH9tuYrCMi1WSgs8V/zTypk6dHAfV9/HBNQY5shkeQ== X-OriginatorOrg: cipunited.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a1e6463-2f72-44da-ec82-08db7bb35d84 X-MS-Exchange-CrossTenant-AuthSource: TYZPR04MB6117.apcprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 10:50:50.3215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e31cf5b5-ee69-4d5f-9c69-edeeda2458c0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mLL2L+JGLQbEqP94DszTAlYRbCwXsakecP0wE8mewkWtSqCx6qy8/DVIOdcqKCE6rc5zV8fgNojlzyIVa76BK9OlHjcQw4CGQ2REtKC1cc4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR04MB4422 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770396284112301759?= X-GMAIL-MSGID: =?utf-8?q?1770396284112301759?= The LTO plugin doesn't expect __gnu_lto_slim is marked as COMMOM or moved .scommon section. Let's skip __gnu_lto_slim when detect symbols to be moved to .scommon. This patch can fix testcase: PR ld/15323 (3) PR ld/15323 (4) for MIPS. --- bfd/elfxx-mips.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/bfd/elfxx-mips.c b/bfd/elfxx-mips.c index 71f2dc9d779..63742de009c 100644 --- a/bfd/elfxx-mips.c +++ b/bfd/elfxx-mips.c @@ -7861,6 +7861,10 @@ _bfd_mips_elf_add_symbol_hook (bfd *abfd, struct bfd_link_info *info, switch (sym->st_shndx) { case SHN_COMMON: + /* __gnu_lto_slim shouldn't mark as COMMON and move to .scommon: + lto plugin doesn't expect so. */ + if (strcmp (*namep, "__gnu_lto_slim") == 0) + break; /* Common symbols less than the GP size are automatically treated as SHN_MIPS_SCOMMON symbols. */ if (sym->st_size > elf_gp_size (abfd)