[COMMITTED] libsframe: use appropriate data types for args of sframe_encode

Message ID 20230627195126.1955051-10-indu.bhagat@oracle.com
State Accepted
Headers
Series [COMMITTED] libsframe: use appropriate data types for args of sframe_encode |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Indu Bhagat June 27, 2023, 7:51 p.m. UTC
  include/
	* sframe-api.h (sframe_encode): Use of uint8_t is more
	appropriate.
libsframe/
	* sframe.c (sframe_encode): Likewise.
---
 include/sframe-api.h | 2 +-
 libsframe/sframe.c   | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)
  

Patch

diff --git a/include/sframe-api.h b/include/sframe-api.h
index 46614925c68..9cb2db0edb9 100644
--- a/include/sframe-api.h
+++ b/include/sframe-api.h
@@ -202,7 +202,7 @@  sframe_fre_get_ra_mangled_p (sframe_decoder_ctx *dctx,
 /* Create an encoder context with the given SFrame format version VER, FLAGS
    and ABI information.  Sets errp if failure.  */
 extern sframe_encoder_ctx *
-sframe_encode (unsigned char ver, unsigned char flags, int abi,
+sframe_encode (uint8_t ver, uint8_t flags, uint8_t abi_arch,
 	       int8_t fixed_fp_offset, int8_t fixed_ra_offset, int *errp);
 
 /* Free the encoder context.  */
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index b885e3df5ec..40927f06933 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -1248,10 +1248,11 @@  sframe_encoder_get_funcdesc_at_index (sframe_encoder_ctx *encoder,
 }
 
 /* Create an encoder context with the given SFrame format version VER, FLAGS
-   and ABI information.  Sets errp if failure.  */
+   and ABI information.  Uses the ABI specific FIXED_FP_OFFSET and
+   FIXED_RA_OFFSET values as provided.  Sets errp if failure.  */
 
 sframe_encoder_ctx *
-sframe_encode (unsigned char ver, unsigned char flags, int abi_arch,
+sframe_encode (uint8_t ver, uint8_t flags, uint8_t abi_arch,
 	       int8_t fixed_fp_offset, int8_t fixed_ra_offset, int *errp)
 {
   sframe_header *hp;