From patchwork Tue Jun 13 08:07:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mengqinggang X-Patchwork-Id: 107171 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp377103vqr; Tue, 13 Jun 2023 01:07:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5DBD3wr4OO9NBHFKbOyxw+AgHHKf9RtWpTIU5mf2+dhsUZfD/VQxPNpXsKWu/P0oICw6OO X-Received: by 2002:a17:907:7e8c:b0:94a:653b:ba41 with SMTP id qb12-20020a1709077e8c00b0094a653bba41mr11431532ejc.15.1686643654281; Tue, 13 Jun 2023 01:07:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686643654; cv=none; d=google.com; s=arc-20160816; b=Yj496pQDf3a30SFe9QEN2W5Kg3xFyl4gB7/Buy+nes1LfDk4pN/AXoFWgLBAqrunGs eFBKQLCvPYrAX2WiSr1XgCaJWB9o2xk/OLCgVTKzaDJPZsKPcnm9luPo+8aeRRckiSVh mvyoqYiAalUx5BL2PFjNiTe1hoQr9T1KgxC9tgy42yolnD1CJq52v4VqNGbKQH9eQ6kC MAz+/Yu7Ue6HdQUlRll5/pOPFk+cC5S08NWeSOVAZQctJ8CX7eGMspdQXEbOuwXg8qCT 3CyXNoypVzSfanImkm5dca3ajD7Tu8qcoJCiu46FUDmPA1D98YmGYmtuOA/z8QoM7Qdk r7oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dmarc-filter :delivered-to; bh=22VfwLwWqyXR3HtDEFSgbUTdgkdWjHPspDBrevLP0qg=; b=F3c7HEaI9zr37VzuodBITY8McsJjbwJSXIStv1QZP0SHSr3rFDfeYQAAoqcwX1r8xN gxF76cvaOekS9dJE9Mx9+FFGZjey7pR4jDntr5fQt+yhGnCNx004ylZs94PREcdqh+fM ppiE+xoA3sVk1pDSVdB62A8kMUYIiRdVYr3yvpF5PPbTdSqdQDb90iRzoP9F0mr8ixSu SHmzNNB3/0Lb2qVreiflAzwO7tGjFxM9iMkAJGk9lvSlPtKFjUS5oW+XLHZp1nY+T9Jf Rulbyw1qvqjnCoOqMI0YSZwUChcLR6OLZuMeH1pAmlIQgHBfZ33iYaYMfkRbM6tl80XN vRmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id j15-20020a170906410f00b00965cf1a3f5esi5276854ejk.121.2023.06.13.01.07.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 01:07:34 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 408073858404 for ; Tue, 13 Jun 2023 08:07:33 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 67D833858D32 for ; Tue, 13 Jun 2023 08:07:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 67D833858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.2.5.5]) by gateway (Coremail) with SMTP id _____8Dxi+q6I4hkT4QEAA--.9425S3; Tue, 13 Jun 2023 16:07:23 +0800 (CST) Received: from 5.5.5 (unknown [10.2.5.5]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxJeSyI4hkMa4YAA--.5222S2; Tue, 13 Jun 2023 16:07:22 +0800 (CST) From: mengqinggang To: binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, i.swmail@xen0n.name, mengqinggang Subject: [PATCH] LoongArch: Fix ld "undefined reference" error with --enable-shared Date: Tue, 13 Jun 2023 16:07:12 +0800 Message-Id: <20230613080712.1651120-1-mengqinggang@loongson.cn> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-CM-TRANSID: AQAAf8AxJeSyI4hkMa4YAA--.5222S2 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7ZF15ur1xWryDZw1ruryUurX_yoW8tF47p3 yay3W5KryrXrn5AryDZ398ZrnxG34xKr12qFWSvF1xC3yDJ3ZxXr109r90gF4qka1kWFW2 gFn5Jw13ZF4kZ3XCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUk2b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6x kF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUrNtxDUUUU X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768574056766815865?= X-GMAIL-MSGID: =?utf-8?q?1768574056766815865?= Because _bfd_read_unsigned_leb128 is hidden visibility, so it can't be referenced out of shared object. The new function loongarch_get_uleb128_length just used to call _bfd_read_unsigned_leb128. bfd/ChangeLog: * elfxx-loongarch.c (loongarch_get_uleb128_length): New function. * elfxx-loongarch.h (loongarch_get_uleb128_length): New function. gas/ChangeLog: * config/tc-loongarch.c (md_apply_fix): Use loongarch_get_uleb128_length. --- bfd/elfxx-loongarch.c | 7 +++++++ bfd/elfxx-loongarch.h | 2 ++ gas/config/tc-loongarch.c | 2 +- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/bfd/elfxx-loongarch.c b/bfd/elfxx-loongarch.c index ac644fff2f6..cb312c46bb2 100644 --- a/bfd/elfxx-loongarch.c +++ b/bfd/elfxx-loongarch.c @@ -1944,3 +1944,10 @@ loongarch_write_unsigned_leb128 (bfd_byte *p, unsigned int len, bfd_vma value) while (len); return p; } + +int loongarch_get_uleb128_length (bfd_byte *buf) +{ + unsigned int len = 0; + _bfd_read_unsigned_leb128 (NULL, buf, &len); + return len; +} diff --git a/bfd/elfxx-loongarch.h b/bfd/elfxx-loongarch.h index cb02af4fe73..627c5db7bcc 100644 --- a/bfd/elfxx-loongarch.h +++ b/bfd/elfxx-loongarch.h @@ -44,6 +44,8 @@ bfd_elf64_loongarch_set_data_segment_info (struct bfd_link_info *, int *); bfd_byte * loongarch_write_unsigned_leb128 (bfd_byte *p, unsigned int len, bfd_vma value); +int loongarch_get_uleb128_length (bfd_byte *buf); + /* TRUE if this is a PLT reference to a local IFUNC. */ #define PLT_LOCAL_IFUNC_P(INFO, H) \ ((H)->dynindx == -1 \ diff --git a/gas/config/tc-loongarch.c b/gas/config/tc-loongarch.c index c55d4ee234a..88c5282918e 100644 --- a/gas/config/tc-loongarch.c +++ b/gas/config/tc-loongarch.c @@ -1381,7 +1381,7 @@ md_apply_fix (fixS *fixP, valueT *valP, segT seg ATTRIBUTE_UNUSED) case BFD_RELOC_LARCH_SUB_ULEB128: { unsigned int len = 0; - _bfd_read_unsigned_leb128 (NULL, (bfd_byte *)buf, &len); + len = loongarch_get_uleb128_length ((bfd_byte *)buf); bfd_byte *endp = (bfd_byte*) buf + len -1; /* Clean the uleb128 value to 0. Do not reduce the length. */ memset (buf, 0x80, len - 1);