From patchwork Wed Jun 7 00:12:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 104157 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp3751704vqr; Tue, 6 Jun 2023 17:12:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6i89LkvXvw5c4GNoNhLayTN9E59pQ+BOoiUYnMW/JwhlTeBhy8qctdlFRA5ToMnvbyniPC X-Received: by 2002:a05:6402:185:b0:514:a157:c1b0 with SMTP id r5-20020a056402018500b00514a157c1b0mr3180736edv.10.1686096757905; Tue, 06 Jun 2023 17:12:37 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e19-20020a056402089300b0051497c93ab9si7039637edy.530.2023.06.06.17.12.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 17:12:37 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=DrXIxGeE; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8DBB0385840D for ; Wed, 7 Jun 2023 00:12:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8DBB0385840D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686096756; bh=qmD1WDExPVBlAYHJSZhwFS8U8oWaGsEHdqCCV78dEbM=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=DrXIxGeEw16KmUQt8weLJBp1eXHAFzYiSwHiVRR8mrbDlRkQS2zpWOpYM9HHoRGAJ L7ZH8KUlj2+NlE1Npjy3cVIs+WzfEIU7im8zCP1BddUQLGDHT8fFrLuLh82PdU+fEu h8G+sWw5qwjClWB3UQJREZBa4OP4IPQQ1EHTXMoY= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 8273F3858D38 for ; Wed, 7 Jun 2023 00:12:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8273F3858D38 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 356IZ6e5004751 for ; Wed, 7 Jun 2023 00:12:27 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r2a6u0hsp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 07 Jun 2023 00:12:27 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 356NBo8R037502 for ; Wed, 7 Jun 2023 00:12:26 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2046.outbound.protection.outlook.com [104.47.57.46]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3r2a6ghk6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 07 Jun 2023 00:12:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LCk+SZiKua5wVw1G6LAyQ2XBDG2BWBx826+N0QU56uqz+e+M3Xcy6V2VJf5qjcy5RsiJP27jvIit84GTIT+DzzNmXWF/gapyYjmRCAvmHrmfWvewPxYY/cEkk4IEPgyXP0uUMsPVQUFD41aWIb7HP/5IQWlVRMC6bPIVTTZGyAuOrnP01+LadBU2hKFAZ2YDNZTRSdNTJyIvTSdHV3ztpGRSePBVB18LPhNHJCfpP15qH4TdbbIvd2nuxPv6nTIlkxdt3z4OHpzhxvjgfjNyI2iw66theH86FVHBX8058DLWeUTIpknNK+k7AJEnWfcf6mZVHADV4MQQXhuqe4v2dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qmD1WDExPVBlAYHJSZhwFS8U8oWaGsEHdqCCV78dEbM=; b=GEkn8tGRU+sCahiRsQrWUaEu3kfI4M6Ucy/esqxo2dmm78/GsMkB4eKC9bRk/yyF8au7aMuHCMFQtUl5jXUgC4iMsukNwT8h3CicPYA+afNkIFGgIEsKuuC8qAQt/MHMWaROU8wbllyj/ZbSh+O8DXtom1dFXnbNXtwAXx6rr9h0Jfp9gtJ6gHXKoMZVzuLTM2sgkwrsUlUBE4UniiGF7/38iwveW31gPg+XoUW11kcLbt0kMKWcZQ2Iwoc5b7mmU5d0dmppPU0Wn4mz8RzanshNUafzpXiigZ9GpvQ4WX0wLZAhUlGGIkHVLKpbk2i0gOE0d3iImzvu/V1lQfPQCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SA3PR10MB6972.namprd10.prod.outlook.com (2603:10b6:806:31f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.27; Wed, 7 Jun 2023 00:12:24 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6455.028; Wed, 7 Jun 2023 00:12:24 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED] libsframe: fix cosmetic issues and typos Date: Tue, 6 Jun 2023 17:12:19 -0700 Message-Id: <20230607001219.1262641-1-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 X-ClientProxiedBy: MW4PR03CA0209.namprd03.prod.outlook.com (2603:10b6:303:b8::34) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SA3PR10MB6972:EE_ X-MS-Office365-Filtering-Correlation-Id: d0258761-840d-457e-ff5e-08db66ebdeb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nP71YDd1h6+J1cvtDHZXM/AOkd1bQL5rcNrM2q5ljlHGx77bHtdyPwvYxGmNpaDJInpGopw4vYVoGGTg7Bv/DcXMMOtb5vGREJbTGClLeOSbbm7kvwh5MXjU9yBem4NdJUE0u9HbNYhuSBXCGFxJGF8plP5yd1yXAaPUSm8PSrCBlI50Xn1OiPmQ70EV5oL4Rwwo2eeG7PT+fLMOMHh9+ds0V2fymHdAjPQ1s6Se/J9GiF9yAZ85UDWNdg8g8Bxb3q/5iVIxWP26+dSpINRKY6FUQqWN56QPgecX34FmHWVwIJzgz5+7fRwgVf4oaMhtVozGcUjPnpoSUdZHdKAZ30Ts+SdCwyHSjOBdm8luhFzDMgONmCQT06QoX2LW+xuuDgM3GbAAm+JKYKNBSOeGoMhcEpcclkuZfPMBzM6cMFmztfStaTWB3nqs6bIejPcJ7paCb2/2HX0/5WIbjscQYxS+8D3gIrpUsBJbf6LJpXksS/Ap+5QU7PdYclpeNeG/SRNMYPPZq869ij2dJnNxWG1pmHk2VgYvDBDAVBzZ2fZlw/58yO1EuYp6bf318SK1JqVxWxFT+sN4EDKX8gyD15jwnYKrzAvSHMK8c2T9Wkk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(376002)(366004)(39860400002)(136003)(396003)(451199021)(8936002)(83380400001)(8676002)(66476007)(36756003)(4326008)(41300700001)(38100700002)(316002)(26005)(1076003)(6666004)(6506007)(107886003)(66556008)(66946007)(44832011)(6486002)(5660300002)(6916009)(2906002)(6512007)(478600001)(2616005)(86362001)(186003)(2004002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VxRFA0+ovOBJJHKS6SwGJTCnB3AV04rM4N9RMSRMrlgYp6AZNYyV+LzQXwt69w9LrBepSroS12+c10Z4NT9o+s/Y0IFk3seYf+nd347KBGBWW14j0L2XWeTfl9jGAOQSwlTl3DBPd5bJ3UHX8qnLL+PCgD+qxswi3Nawsxp09zlqZeGheSCs6DStYyJlMXP5oELiVD2m8JpOtnkMLVmRw76fCvpw//XWzQuqyzQx9c06xV4PYg4KtkOWwrFxXbXSeMoojSeMLzpWeTuW2BWDgShkJRQOXST50IaoAb49ryWTbD2Ep5/WpXmd+kAQBF2zNF9xU3dXCQDn3maD504vVl0S3Q/UZDH20NVdqipL8MUrWXYeTnfBdOFjGrEw/TL+4KiidBdjCgSaaHdmdvAfR8MeKNoAYmYdAUkK3pFQJ1AbKCXyuurYGhx6LC3NLvp1Nn4XaV43p0lR+7UC7Y3pgbmhfcrBZvYgqsNK8+FkQCx31vaLuS3PbhSSrrBmF+wgTdC5kt8daK/sTRsoQMAG3mXeEzGNsza9QoTYbtAv5qYw8gLyC62T391EDA/KN8JZkCn1sRA7GpmvaCi71vNzucg4C+zH4e2LbxV3adwVGXg/nZnrRWUPwY840980dDP3TmW/nh51ACYGDBM7HBiJ50AKtcOd8YMWSiGTqUcnjDhCfB6OgxL0JN1Z/DCsJ7JZBY+OQ/9IEt45TAXm5yF0Nv73OzjT10yXuHKYylXIbcojlD5ua50dfiA91i+lQa5ao+CgtQ/8KTll734v0JN6oJ1z3dpAAKkb6dQQKqh2qdTBVBzOqXTZsi9A8besRVoKgTi3y64f+WpS5/NmUmHrlxPY2TfkPc3UK51huRGeGs3n5ROx33NCBU30N/Yb/Ji9p+BmeEbNwCxWgYpbCnHRzuy2MiBGSLiNi+th2QihVFoPuLW0zD2GVWS5WcJMqJZ/Xm8ltKK/nF+ljTMWY4hmfSTFXZAG8GylMW2vw13KA22tIDQ3xGjOu7Ck7RH20QHXtcPvCm8PsSdZlbHTx7p7elgQldX1Deqn9yXW8Shk+OxAjk5jQgw46MGzBTMuKLLyd2/a5Q1Pwg3/ihKrNBereZ8YD1Srlnzo/6nEoRp0zkr0H+p6n+V9/m1YjFG/7pJ+RglE7Do8ooYpz18bBnYk+0SxmWqqs68lAC2ZJQ3hgtW3jGyTpCnF9vZThR9jJ2efXHjhFoo+G3JcLYlRdAkGdl2qXRvOOfrUeZgdu0PG/pIOfs40zV5PoiiVPa1GjeSMwbdLOPJer/pqsW4HWkJG2/b6a2eCGLaiCIJaeYeKfBc69U1WpunrE5QYLkTU94jFe4mwnLGx+yE4q/ZWjydJb87nPHcIZ+b3kp6MtgW/lMRK6Ksr5W1/sW9wq5TcdvO5QQiZbbfOPckF5wQolzWmH4BgQqYNl5zoxMEyo+xUtbXD0+mMzM+qLoLv/bnFVC8Ko3fxk2LpeMsJiyPeH/f++2XWtpNcVx8wE5gro8vuhd4wLeY+Pv+vtqhwniLPiW9d20K6a6gyrHIrFQRb7Ak0XTcNWs7cfx6fWnk4WiEJOvz8m+mSLq2kGYCR5Re0XQoF X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TUEsSxX5CceAHBUOq+RkkRb1kT74PiKEqIDH0MxB8OLtuweryBryKzU69dFEkZnT+WgwKQz4tvtYBJNMEozaIbYbypSg/xghKEefSzwkSGZZNiMJ/2z/CzUXFrZu4dhtu8Bx00wla5E1JvY2hQjCgtreBGe1LqaR3KO66FUxknpjN/+JhNtFqSfN6zHqTwoC1T+eGtEzjPnbQu/aVZYJ0mDnLvhIAN/TLlMrlox5nrm/UKDttBjsqgER0EzfR4udfYR33Wi9i67qULifys6SxXllUSHsgAnqF0AM5BEv7j7uevbMs94Ya2kBnMPqkyBRXwIj/ancirO81yx0sIcveaUviMb7cscNdHOo1CCornBmBCxHHP2MOTvqixf/9jVJB6/kTTEZi41JwnPdU9dnlpmVtFaI3vNf/qk9jl9WEN9ZnfhNz77U8pqD8PBUDEAIVMcl6vFKtsq9S4RcoiAA/6Pg0yASIfpNJQvxn4xEg6NlZ22jrVmSMqRA38vAtNROqW1gOvvx41XyRZb3Ic9FkBHdrqiTd92rDE4bnTG4oRb8WaK8v9N/LehRYFQ9/TepqZMTHtT0CS9cGOtGeND297LtHN6ym3w46fiv5fX5boVpENQUpWVEzEhNRsXXTKRzcMslthjScnjJVM93ho5udAYdzh31KH9NvQzDFrMgYRATa2/gxgGduxxmWXHkpMhx7/Gf846e7rQxyzsMspt/OELCmacNdUbIPlm1mY2qf7mI4W3hUr5JfZ2+gysL5Pc2 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0258761-840d-457e-ff5e-08db66ebdeb8 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 00:12:24.5040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GgiKSUk/SVjwOdTujAbQ6D7lxey0/V+dCOn+qa3R9Ma8sp6DD76Q1TH4nPW0WVGUhhree7Wnbn90irCuTOaG0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR10MB6972 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-06_18,2023-06-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306060203 X-Proofpoint-GUID: Ev-vF-BFheB8E-6_miQS0nrPdUgwPxmv X-Proofpoint-ORIG-GUID: Ev-vF-BFheB8E-6_miQS0nrPdUgwPxmv X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768000594318700197?= X-GMAIL-MSGID: =?utf-8?q?1768000594318700197?= include/ * sframe-api.h (sframe_decoder_get_num_fidx): Use extern. libsframe/ * sframe-dump.c (dump_sframe_func_with_fres): Fix line length. * sframe.c (sframe_frame_row_entry_copy): Likewise. (sframe_decode_fre_start_address): Use the intended type uint32_t. --- include/sframe-api.h | 2 +- libsframe/sframe-dump.c | 5 +++-- libsframe/sframe.c | 5 +++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/sframe-api.h b/include/sframe-api.h index 3245bc8ac90..df1f5ccef4c 100644 --- a/include/sframe-api.h +++ b/include/sframe-api.h @@ -122,7 +122,7 @@ sframe_decoder_get_abi_arch (sframe_decoder_ctx *dctx); /* Return the number of function descriptor entries in the SFrame decoder DCTX. */ -unsigned int +extern unsigned int sframe_decoder_get_num_fidx (sframe_decoder_ctx *dctx); /* Get the fixed FP offset from the decoder context DCTX. */ diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c index 77aa87d67a1..6d266392cd7 100644 --- a/libsframe/sframe-dump.c +++ b/libsframe/sframe-dump.c @@ -2,7 +2,7 @@ Copyright (C) 2022-2023 Free Software Foundation, Inc. - his file is part of libsframe. + This file is part of libsframe. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -134,7 +134,8 @@ dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx, char temp[100]; - printf ("\n %-7s%-8s %-10s%-10s%-13s", "STARTPC", fde_type_marker, "CFA", "FP", "RA"); + printf ("\n %-7s%-8s %-10s%-10s%-13s", + "STARTPC", fde_type_marker, "CFA", "FP", "RA"); for (j = 0; j < num_fres; j++) { sframe_decoder_get_fre (sfd_ctx, funcidx, j, &fre); diff --git a/libsframe/sframe.c b/libsframe/sframe.c index b05fed97e61..a7615329767 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -667,7 +667,8 @@ sframe_fre_get_ra_mangled_p (sframe_decoder_ctx *dctx ATTRIBUTE_UNUSED, } static int -sframe_frame_row_entry_copy (sframe_frame_row_entry *dst, sframe_frame_row_entry *src) +sframe_frame_row_entry_copy (sframe_frame_row_entry *dst, + sframe_frame_row_entry *src) { int err = 0; @@ -711,7 +712,7 @@ sframe_decode_fre_start_address (const char *fre_buf, else if (fre_type == SFRAME_FRE_TYPE_ADDR4) { uint32_t *uit = (uint32_t *)fre_buf; - int32_t tmp = 0; + uint32_t tmp = 0; memcpy (&tmp, uit, addr_size); saddr = (uint32_t)tmp; }