diff mbox series

[COMMITTED] libsframe: fix cosmetic issues and typos

Message ID 20230607001219.1262641-1-indu.bhagat@oracle.com
State Accepted
Headers
Series [COMMITTED] libsframe: fix cosmetic issues and typos |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Indu Bhagat June 7, 2023, 12:12 a.m. UTC 
  include/
	* sframe-api.h (sframe_decoder_get_num_fidx): Use extern.
libsframe/
	* sframe-dump.c (dump_sframe_func_with_fres): Fix line length.
	* sframe.c (sframe_frame_row_entry_copy): Likewise.
	(sframe_decode_fre_start_address): Use the intended type uint32_t.
---
 include/sframe-api.h    | 2 +-
 libsframe/sframe-dump.c | 5 +++--
 libsframe/sframe.c      | 5 +++--
 3 files changed, 7 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/include/sframe-api.h b/include/sframe-api.h
index 3245bc8ac90..df1f5ccef4c 100644
--- a/include/sframe-api.h
+++ b/include/sframe-api.h
@@ -122,7 +122,7 @@  sframe_decoder_get_abi_arch (sframe_decoder_ctx *dctx);
 
 /* Return the number of function descriptor entries in the SFrame decoder
    DCTX.  */
-unsigned int
+extern unsigned int
 sframe_decoder_get_num_fidx (sframe_decoder_ctx *dctx);
 
 /* Get the fixed FP offset from the decoder context DCTX.  */
diff --git a/libsframe/sframe-dump.c b/libsframe/sframe-dump.c
index 77aa87d67a1..6d266392cd7 100644
--- a/libsframe/sframe-dump.c
+++ b/libsframe/sframe-dump.c
@@ -2,7 +2,7 @@ 
 
    Copyright (C) 2022-2023 Free Software Foundation, Inc.
 
-   his file is part of libsframe.
+   This file is part of libsframe.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -134,7 +134,8 @@  dump_sframe_func_with_fres (sframe_decoder_ctx *sfd_ctx,
 
   char temp[100];
 
-  printf ("\n    %-7s%-8s %-10s%-10s%-13s", "STARTPC", fde_type_marker, "CFA", "FP", "RA");
+  printf ("\n    %-7s%-8s %-10s%-10s%-13s",
+	  "STARTPC", fde_type_marker, "CFA", "FP", "RA");
   for (j = 0; j < num_fres; j++)
     {
       sframe_decoder_get_fre (sfd_ctx, funcidx, j, &fre);
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index b05fed97e61..a7615329767 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -667,7 +667,8 @@  sframe_fre_get_ra_mangled_p (sframe_decoder_ctx *dctx ATTRIBUTE_UNUSED,
 }
 
 static int
-sframe_frame_row_entry_copy (sframe_frame_row_entry *dst, sframe_frame_row_entry *src)
+sframe_frame_row_entry_copy (sframe_frame_row_entry *dst,
+			     sframe_frame_row_entry *src)
 {
   int err = 0;
 
@@ -711,7 +712,7 @@  sframe_decode_fre_start_address (const char *fre_buf,
   else if (fre_type == SFRAME_FRE_TYPE_ADDR4)
     {
       uint32_t *uit = (uint32_t *)fre_buf;
-      int32_t tmp = 0;
+      uint32_t tmp = 0;
       memcpy (&tmp, uit, addr_size);
       saddr = (uint32_t)tmp;
     }