diff mbox series

[COMMITTED] libsframe: avoid using magic number

Message ID 20230601173312.3176329-1-indu.bhagat@oracle.com
State Unresolved
Headers
Series [COMMITTED] libsframe: avoid using magic number |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Indu Bhagat June 1, 2023, 5:33 p.m. UTC 
  Define a new constant for the maximum number of stack offsets handled in
libsframe, and use it.  Note that the SFrame format does not define such
a constant (limit).  This is an implmentation-defined constant in
libsframe.

include/
	* sframe-api.h (MAX_NUM_STACK_OFFSETS): New definition.
libsframe/
	* sframe.c (sframe_fre_sanity_check_p): Use it.
---
 include/sframe-api.h | 5 ++++-
 libsframe/sframe.c   | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/include/sframe-api.h b/include/sframe-api.h
index 405e30c27e8..3245bc8ac90 100644
--- a/include/sframe-api.h
+++ b/include/sframe-api.h
@@ -31,7 +31,10 @@  extern "C"
 typedef struct sframe_decoder_ctx sframe_decoder_ctx;
 typedef struct sframe_encoder_ctx sframe_encoder_ctx;
 
-#define MAX_OFFSET_BYTES (SFRAME_FRE_OFFSET_4B * 2 * 3)
+#define MAX_NUM_STACK_OFFSETS	3
+
+#define MAX_OFFSET_BYTES  \
+  ((SFRAME_FRE_OFFSET_4B * 2 * MAX_NUM_STACK_OFFSETS))
 
 /* User interfacing SFrame Row Entry.
    An abstraction provided by libsframe so the consumer is decoupled from
diff --git a/libsframe/sframe.c b/libsframe/sframe.c
index 97b49106e39..a97c64f7a9b 100644
--- a/libsframe/sframe.c
+++ b/libsframe/sframe.c
@@ -299,7 +299,7 @@  sframe_fre_sanity_check_p (sframe_frame_row_entry *frep)
     return false;
 
   offset_cnt = sframe_fre_get_offset_count (fre_info);
-  if (offset_cnt > 3)
+  if (offset_cnt > MAX_NUM_STACK_OFFSETS)
     return false;
 
   return true;