From patchwork Thu Jun 1 06:16:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 101754 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp83234vqr; Wed, 31 May 2023 23:16:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6MHWDiUXG5w6Vf1UbRUUf7u8ozBfmcUNzBGI8Soz1ZUr+hSvqowUXhwtcp6/k+WgkyX96m X-Received: by 2002:aa7:d396:0:b0:510:d6b3:a1c2 with SMTP id x22-20020aa7d396000000b00510d6b3a1c2mr5261676edq.27.1685600192910; Wed, 31 May 2023 23:16:32 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id g2-20020a50ee02000000b0050be10bf71asi8312967eds.69.2023.05.31.23.16.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 23:16:32 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=d2PuIgYD; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 87F6B3858035 for ; Thu, 1 Jun 2023 06:16:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87F6B3858035 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685600191; bh=2jo2C1rXzbS+kh9/xhSR6oQ07as9U0QNqH5FXODFKPg=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=d2PuIgYDvEOGbE8gtvghQFDiIYauDROjbq6PbsDNmSWeJI/qxrbpN+x9Fisztfybg uOTwmGEIndMw86hNBPNmddvtpPme+0tQdWx1Ebu7xXJlbShlte1O0OydydM8prD9Ct dhVBsCl48G1FHWuHl7jjbso3F89/7mDzwCOoNeqY= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id D491B3858423 for ; Thu, 1 Jun 2023 06:16:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D491B3858423 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3514A4eF031546 for ; Thu, 1 Jun 2023 06:16:21 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3qvhj4yw3h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 01 Jun 2023 06:16:20 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3514hfWj003689 for ; Thu, 1 Jun 2023 06:16:20 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3qv4yebc52-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 01 Jun 2023 06:16:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CXuS8UQTgPDspijF6ZclTZvvzcM0sewPsjhI92o85uEQzZvKrOqsGyaXHFp6q7OgHFGWY7qUeUUCTrt3Av1lqGffYBVO7GWMJ/NiiyGyAXC4uWHujAaBt/hW8GGeUeqX9MvUju/gn0P9Xrvw/ZefTndOSU9Sk9fQerZpKWhNsQbi0bVCjwhyNxovwVMNoOEvtc22byJBl0rwF8yd1aZrVm1NxaQEo8EhJsxauwxYefPcQm6S70xNWbk5+vj5JpJqD7Xoih3Xx1oUQtQD4YoYGS1G+qe6/tezlk1wp5O/OFG2JqBhAsrrNBH5hO/F0lgNCQG0PgnxE9FVydnyVA/UqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2jo2C1rXzbS+kh9/xhSR6oQ07as9U0QNqH5FXODFKPg=; b=RrGr0F7X7VdkGU5eIdn9+3CrFPxHhTxfA6mWCXoevUxqHcGfNTwfZSH2ufUGrMRFYS2lEOCczUnAOFK0D56rlIFBOyYy5OXGs+PPlewXtZjbHbXVcjIQTIkC8NreJo1cGCdy4FU6CiJk1esb3lenYiYyhAUzeB98s4g66awDMt1378oxhK9WEjCoihjimvP+jSD25cRa/q/bYBkctu05KZMfoPB6AAahy5YQ6LtxntejXGZ5l08SYpmuqbPVVx8EVDRjCM3zDLfTckbkV2vj3UKDV03Js0RhOlZ6GQ2h4FZ4dMLvrVoyuHhK5OhietTWNuxJvQAOuQ6OL/NjsqqxFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by IA1PR10MB6757.namprd10.prod.outlook.com (2603:10b6:208:42f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.24; Thu, 1 Jun 2023 06:16:17 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6411.025; Thu, 1 Jun 2023 06:16:17 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [COMMITTED] libsframe: minor fixups in flip_fre related functions Date: Wed, 31 May 2023 23:16:10 -0700 Message-Id: <20230601061610.2614564-1-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 X-ClientProxiedBy: MW4PR04CA0331.namprd04.prod.outlook.com (2603:10b6:303:8a::6) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|IA1PR10MB6757:EE_ X-MS-Office365-Filtering-Correlation-Id: 6dce5e5a-6aa2-4390-2a31-08db6267b5c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: k40oyi+tEcq+mFVteiIfjU7AunXvQUWdh5kBUf3DhCIg80jbk4B6oVSrJ9Vrf1CI8iVkMFNS/JvpEb1TQO16ntv6OADLJ+DflN8p5vXLYaBa0fCzC0B/5VrbsKSAy7gqt2T4MQ4Iu2rVS0jNcT1WidkkwYLPS5Jlg183ICpfCempGVQUNEC3yvx+kDi4IzCLBd7e+ty77EYmXcL3uzQcZWHfGpQV6jTQffANxzTcjy2kFMdvka6rnAsqCBRK+avIKrUbE8n2jhssvs20VarRA14cAES/3RVk0nPvDVNx+qtSidg/FOtlNxokx/c1n56cG4oHaix9kBVetUhOJziSu0XeYT1VaAuB5BDgl+b/FrdNqq1niPue98PlPtQvlfeEIz7lEYI/jF2u3wS0vbBEVSDm2ceTb87U1b86WPnDWAGeXcArzDj2H4TOkVlYjtK52nJUcbX1Qfypbf0lNDS5izUYP2mpkzVZj+aIpNAmmojnrx+9pyKYxt38oVbBgcFRbPmCkQpPLbgi1lZ82FdA262oGokG5/b3XXNk1DDAcjvAqIPCuwurj5SPRpCC8yTF X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(376002)(396003)(366004)(39860400002)(451199021)(6666004)(107886003)(6512007)(83380400001)(1076003)(6486002)(26005)(6506007)(186003)(36756003)(2616005)(38100700002)(478600001)(316002)(41300700001)(4326008)(66556008)(66476007)(66946007)(6916009)(44832011)(8936002)(8676002)(5660300002)(86362001)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 08t4pznHnoJlte4i0xSE9vQnIYcuqB/2gRh/iAmtqIE8YDH78YMF1nszoYeiLvcwsy5pucG6JR1hD+gLj4ogDo3JRtJmcTaVVrrc0GW0yUkeo5Vf1wakNW0M7CzrDiC1JjKVNbXKG0Vf38Mae37QNr5sW2e8VzRN0Dvn0DI3KV6lgmkH7KNSrSbr2oC9SpsdwsbvfjVu599JLTLw1tBHnmqVO9m8FLKc7q2gBgCWU2o1gt4zuEYVhLrJR2QvvG3e345o79cKeedJWkAqBEynJJAMaivQfAnK+wLXDDTJzF3nRUxueMZpKasJ1KMLWK2WqkRgpY/n8sfZbPdEvGxvFpSHJ0XuQf7VYkUMKcUvP4+tXaFgTx2gTYttLnk2Ia+dAJfMdBItYhUAM8B3tz0YaDF19d+P3IqwqrIPT6vLQycWb2nbfY8vsRoMlxsvVtWJ3Qs8K9ByXcwwF+KQwy3oeMrFPqZhVBHGVdznre3IopqazQLOmPhUFPWKiiSW5LPXKEl8ZFKSeJuT69iUBKLefhGhwRprV0sRN5i0kFh4Gameklnz+qwzlv/4q2fFrz3UqsryBbCi6AosQqWx0BwoCUdWIcklXw2R1NxE5DANXYecWCG/7Yr1fZr3EF6j0LI5Lc9n5lKrZvufmx/txVZ62zKr42E3s2FAPc+XZph8XAfuOEeOxwXqn21Kol/agp/KaxSGwq+XFLZSLOFtbXWvlEvRQUHrLeSkITyTLWVEro9xxU4NwRpZkevs1fEKP6pSWMJm0GS5WyEUoUKRNrS+Y+IOHEmCyVcAYAHImW6OcrQYOZL5BHW2OaOWtqp3FzjW+ym05rjcw3y9Hz3zF+SzdBzcDE4xC5MY434F3RgDmbcfanGaolBnEdKUCUZtqCCkCVt9P4gJa+9sqMdQC21R9xHSSzmo+zUokzdMv3y+VfyCWnMaMooYfN7cf70Ld0syVaf2h8+uSum8UuDSEGVDviIJeJEhW2PlXOfh12h3GCzudg+/TN6Ys1AH4ux4HEzSqAL3iGGd0e1Q3SF5aLcUo+R7c5uVg9Q0xGflLfvF5lazaLDqFb3dchjVIVmCsiMExQNopi5JEwCP2VjrKPZmjF/tpL9jUbUOeoC5cMpczJleGjRzhoCKEIvNJBQdotb/9fvjOiHDBJiekEcOaprRIBMeExhRBRrYD8X5ufpy2zOWM/kiISO/njnkJVGZs+H+blqQTfA+koN81pStdtPl3nxu1IVZlOn411SDfj/qFyyxpYaBUwGiHGawuGZk21pbPRTHlBHxr1D6PqPW5KB0SUMO83XW15vUW4ZsFbOQZ72d7HhsiG9VpzWYCIK46PvF2fVeOTvZdJ4esw3JZqdVS9Wk6hmOBMEZlJA+lbve7tZnz4ikWKcY0FTDXmJPz1CX1ZegSXqG7WaEJgGIVxNuvhRIeKoyd+XmjN0WMO4HKw6Ur5gX8BEb8LH02/YiRf30udug6WiVje0FzqXcxfJb73H2NTRn1UKtIPr4d39x4iHBlN+4GobBB+O9e0Io5RkhWE9w3ykVwpBx6G8wwCYrCROvyOEodo059aAi3AU71yPUQFIGG6qbUxiduLa+0qRh X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SQBcrLxsuXCVeOGY4DG3JCAaVfYmKq6Zk+qoIppHneuMEzflZZ0y2bsFHZ+sCq2K2/z6M09uby06vNWQ23tiYjVnm5CxlmkuoFinbFEALQcVLReEfyyHVryKi6bkd1eobjHqBLgZUb6yur3xHbUk/SP4hXS3J0hZCKTZCkZg0KbZwOpxklJFVLG566RsfuTr3AQzXr6rX5JkukN02mEUlh6hVZI7u6ceFti15xfTIXp5O140B+3Ho4WDYg02MGZJzXmF57uKcRspzCj+VWCZ5ngM8NHF+xvspd1wJna/fbA7jnQtyPi7AfSC9N3fvTChOFGpUMpYAmRdopFkHqRFqAay1jzfhF2X1pX4ohi3y1T5X3KekQjA3zqLBePFHTzpjPF97A2J4WTcOt389EHMXPszvkShAH4OQKG10QZwkyX23RR5UFP5kpbD8v2auRT/ueCiCTb2WbJp15apn0wdCnKU7rdRkxDiBASRIhmmKWAikunDQe0zzDemI+cYLop4iC+xBGM5FrHpEzmaN3wmY6XKaJ691JaCLhlRzXfcNA94jH0SyDzbdsM8Zx7NUQd2KBAd5wGCck2WDq2B9Ug3x2uq2g5QxoTzjHVNrL8P6qP3VKpOJ7ITYg0Y1993d4CehB8FBYaRKP7ABc6EGuMGwoXFIQjKS3QDoqo7aesmYi8gDnaQjIyp/Mn7HuLUk8iECZ+gN+kA0VDU3EDsLqmz/wtrCsuABknM30C2xmVJQPr3Q6dpAqZvLlzGZyZ2Z0OW X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dce5e5a-6aa2-4390-2a31-08db6267b5c3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 06:16:17.4872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uihHWUMinOTUDlmdjG4UxY8tMQuAyLpL/T4luL1Ag1jSXGaqzT6M6S88DSOg1FlohjVO+wKY9zkI21vfnF2n0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6757 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-01_03,2023-05-31_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2306010054 X-Proofpoint-GUID: 0Gaf-FLSFjwHRKK04uJEHvT9kVzs3uM0 X-Proofpoint-ORIG-GUID: 0Gaf-FLSFjwHRKK04uJEHvT9kVzs3uM0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767479907916533052?= X-GMAIL-MSGID: =?utf-8?q?1767479907916533052?= libsframe/ * sframe.c (flip_fre_start_address): Remove unnecessary type cast. Use uint16_t instead of unsigned short. (flip_fre_stack_offsets): Likewise. --- libsframe/sframe.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libsframe/sframe.c b/libsframe/sframe.c index dadce2c1262..97b49106e39 100644 --- a/libsframe/sframe.c +++ b/libsframe/sframe.c @@ -221,30 +221,28 @@ sframe_header_sanity_check_p (sframe_header *hp) /* Flip the start address pointed to by FP. */ static void -flip_fre_start_address (char *fp, unsigned int fre_type) +flip_fre_start_address (char *addr, unsigned int fre_type) { - void *start = (void*)fp; if (fre_type == SFRAME_FRE_TYPE_ADDR2) { - unsigned short *start_addr = (unsigned short *)(start); + uint16_t *start_addr = (uint16_t *)addr; swap_thing (*start_addr); } else if (fre_type == SFRAME_FRE_TYPE_ADDR4) { - uint32_t *start_addr = (uint32_t *)(start); + uint32_t *start_addr = (uint32_t *)addr; swap_thing (*start_addr); } } static void -flip_fre_stack_offsets (char *fp, uint8_t offset_size, uint8_t offset_cnt) +flip_fre_stack_offsets (char *offsets, uint8_t offset_size, uint8_t offset_cnt) { int j; - void *offsets = (void *)fp; if (offset_size == SFRAME_FRE_OFFSET_2B) { - unsigned short *ust = (unsigned short *)offsets; + uint16_t *ust = (uint16_t *)offsets; for (j = offset_cnt; j > 0; ust++, j--) swap_thing (*ust); }