From patchwork Mon Mar 20 03:34:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawei X-Patchwork-Id: 71942 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp996314wrt; Sun, 19 Mar 2023 20:35:14 -0700 (PDT) X-Google-Smtp-Source: AK7set8IfffRt0zTEqUaN0r6XjlawkA0UZ4Et40jhJhWsExtIVK/ekcfnAjdU1JVYR7TKlvq8u8w X-Received: by 2002:aa7:c043:0:b0:4fd:5a28:2eff with SMTP id k3-20020aa7c043000000b004fd5a282effmr10245637edo.26.1679283314691; Sun, 19 Mar 2023 20:35:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679283314; cv=none; d=google.com; s=arc-20160816; b=NwX8M5G3ORFOp9ees1FBQdDJe4o/jln8nIbfTHIpEnXQ0PJVrymbQvwmELWcB6bZfE I5WSuJGs5/EqMm4QyV0W/yhw2iH7s4DHbyus7UUr4K5jkQf/OKVCwlGVrrnGI7ql2Xe9 xoYIgFKUyifJtfJdCC3VAluveLYuh3thQQd/9lus/ODfPKc7zjPKKAJvHybsFqtNiH6v l/DYmJIvGhUMUMpvbmHLaHOBQDkdqgq49waUxoVD96GtJZJMjzD74B72hdcdELhMcrkm PbFFdPbJul2pB2i44CvPe3KhLPcrIW/b8MkertYNMtPz9FS8fH0zhXztjtZ92L+Irbl7 xz2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dmarc-filter :delivered-to; bh=ODAvIUhX5JijTjFzZFEe423gZzVQIuxlTAZcteh+6x8=; b=H2mRAKb7AaXdx0lbb/qboxL9nXten5UPUnmqKqoAqid77NnEHHLAAsfDUVKA/ovYiF ClK1NcaKUMltoWqVFBz0TOqit4Tqa7pIOPd4cJUCMgBbsXTFLoWqSoQ1d0uSo3XGZ5d2 jltVyqnFR1XEV80Su+pFuaYgsGW5VYOqytkJW1Rob1VB1JN1oGuxdb11hVgF8sE1AmkF AHbvE/ultSlIMpHcPyTfIAMVINyMaMDgFNqkzepbJlnXc+DWZMmVC+tS8h/kT6bNiQ9E WWn6CZifgwVfE6zmOgvyiLz2ICKKVvJFRpRMdY0XEIxo/33O72W960YaYRBdf4laKDy8 BSLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id i25-20020a056402055900b004ab4569274esi1507324edx.88.2023.03.19.20.35.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 20:35:14 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E92AE3854810 for ; Mon, 20 Mar 2023 03:35:12 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) by sourceware.org (Postfix) with ESMTP id 785F13858C53 for ; Mon, 20 Mar 2023 03:35:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 785F13858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [47.113.87.88]) by APP-05 (Coremail) with SMTP id zQCowABXXxdi1BdkNvBzBg--.41504S2; Mon, 20 Mar 2023 11:35:00 +0800 (CST) From: Jiawei To: binutils@sourceware.org Cc: nelson@rivosinc.com, palmer@dabbelt.com, christoph.muellner@vrull.eu, yunyao.zxl@alibaba-inc.com, wuwei2016@iscas.ac.cn, Jiawei Subject: [PATCH v2] RISC-V: Fix disassemble fetch fail return value. Date: Mon, 20 Mar 2023 11:34:44 +0800 Message-Id: <20230320033444.2819-1-jiawei@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: zQCowABXXxdi1BdkNvBzBg--.41504S2 X-Coremail-Antispam: 1UD129KBjvJXoW7GrWrtw1xtF45Xr17Zr4rGrg_yoW8JrW5pr 4FkrWDCrWYkFyxuF1xJwnxtrs0kF4Fkr9aqr9Iva1S9w17Xr43ZF4kKw129ryrGF17Kw4q yrs0vF40vw1rArUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUym14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vI r41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8Gjc xK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0 cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8V AvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E 14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUdHUDUUUUU= X-Originating-IP: [47.113.87.88] X-CM-SenderInfo: 5mld4v3l6l2u1dvotugofq/1tbiBwQQAGQX0NgLNgAAsV X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760856180823497040?= X-GMAIL-MSGID: =?utf-8?q?1760856180823497040?= This bug reported in https://sourceware.org/bugzilla/show_bug.cgi?id=30184 And discussed in https://sourceware.org/pipermail/binutils/2023-February/126213.html We also checked the implementation of return value in arm and mips. So this patch changes the return value to -1, that can fix bugs and maintain consistency with other architectures. opcodes/ChangeLog: * riscv-dis.c (print_insn_riscv):Change the return value. --- opcodes/riscv-dis.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 7baba054daa..f431124b423 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -1059,7 +1059,7 @@ print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info) if (status != 0) { (*info->memory_error_func) (status, memaddr, info); - return status; + return -1; } insn = (insn_t) bfd_getl16 (packet); dump_size = riscv_insn_length (insn); @@ -1071,7 +1071,7 @@ print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info) if (status != 0) { (*info->memory_error_func) (status, memaddr, info); - return status; + return -1; } insn = (insn_t) bfd_get_bits (packet, dump_size * 8, false);