From patchwork Fri Mar 17 01:53:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawei X-Patchwork-Id: 71031 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp94788wrt; Thu, 16 Mar 2023 18:53:53 -0700 (PDT) X-Google-Smtp-Source: AK7set/xOJt1+g5xRKu8uL2vwKd6JD+8QOc/tvmPfFedgtqp/XJau3PuD0gOCxJ6/VoqunjtzHtY X-Received: by 2002:a17:906:99cc:b0:92f:2c64:9d43 with SMTP id s12-20020a17090699cc00b0092f2c649d43mr7771429ejn.68.1679018032909; Thu, 16 Mar 2023 18:53:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679018032; cv=none; d=google.com; s=arc-20160816; b=YajmzX4vyN//rZwMHvBeP2oae98Jt/O8Ol9WVgFGq32n9F5aFVb9WOH6t43q2JXC2F EpNvG0+IqeG2tGMg5FZ/UvltCpARG33ZeQ5LAikLe/+FwbWR58zF6sfwe6XE5Xn99MP8 RuS/UEQ38v8kn9YlbdVk4++cMjsLJKhRxefupHuKqp09ICm5LDs+qL8VhKdQPdX7m6L4 YXCP0/Je1d5WtOIHQWEJ+YDETcLi0T91G2Qk/kxNGWvDIvWFJHSo7CLBuXZXD0InIqBN dOEIFyDl7Ieijbpr6fFc5o5RdYe8BQzS+uojPBSZF7dTNKR2aNLL+VOfxPyPxP6tJPD0 Xk6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dmarc-filter :delivered-to; bh=xmkEOCuMB6FGyp5RlyR/NrGFnnQw44p85quS2Dbx1nM=; b=aNAS3Ot+xlB2jam5XdCLIyLUTYsCkPeff10mwX1XBz8O/VaZFwBZJqqx1D2JEmBYhv V9vPkIoNfoMmujiBTT87tJ0Sm7tqehtRX2nVS7BAJWzgUxPber90G+SE2ja9Pe+GV/5S hRy0G5FaiD88Bhp4x9xtqK+JBuvmdWSg4kJs5koWuTyYdUaGqYUidGNceBM1SxulJL9h Cn73qgdWtiA4brdSd3DCfbJsvP4P47aYQwKa+7zLAKvAIXYWDjy6qj9O5BHDdy91uVWj gOswONcKUhvKZMdr5IMFMXmhHi9KySUK+33rjBtNMJ5xJVhZe7YOkS/0IybIqFXNFC++ 1sXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id p1-20020a170906140100b0092f39ba6e6bsi819635ejc.772.2023.03.16.18.53.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 18:53:52 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD7ED385B527 for ; Fri, 17 Mar 2023 01:53:51 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from cstnet.cn (smtp80.cstnet.cn [159.226.251.80]) by sourceware.org (Postfix) with ESMTP id 8408C3858438 for ; Fri, 17 Mar 2023 01:53:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8408C3858438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [47.113.87.88]) by APP-01 (Coremail) with SMTP id qwCowAAXG0chyBNksd9CEQ--.45859S2; Fri, 17 Mar 2023 09:53:37 +0800 (CST) From: Jiawei To: binutils@sourceware.org Cc: nelson@rivosinc.com, palmer@dabbelt.com, christoph.muellner@vrull.eu, wuwei2016@iscas.ac.cn, Jiawei Subject: [PATCH] RISC-V: Adjust the 'print_insn' return value of disassembling. Date: Fri, 17 Mar 2023 09:53:23 +0800 Message-Id: <20230317015323.567132-1-jiawei@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: qwCowAAXG0chyBNksd9CEQ--.45859S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GrWrtw1xtF45Xr17Zr4rGrg_yoWDGrc_Wr Z7Ww4fW3s7ZF43Aa1jyay8Ka47urZ3X398XasIkF9xtF15WFy5Cw4ktFs3XFyxAF1ktwnr J3s3Crsxt3y7XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb28FF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE174l42xK 82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGw C20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48J MIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMI IF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E 87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0pRCD7sUUUUU= X-Originating-IP: [47.113.87.88] X-CM-SenderInfo: 5mld4v3l6l2u1dvotugofq/1tbiCgoNAGQTOCLgiwAAsL X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760578013028762434?= X-GMAIL-MSGID: =?utf-8?q?1760578013028762434?= This bug reported in https://sourceware.org/bugzilla/show_bug.cgi?id=30184 And discussed in https://sourceware.org/pipermail/binutils/2023-February/126213.html We also checked the implementation of return value in arm and mips. So this patch changes the return value to -1, that can fix bugs and maintain consistency with other architectures. opcodes/ChangeLog: * riscv-dis.c (print_insn_riscv):Change the return value. --- opcodes/riscv-dis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 7baba054daa..1506dc5750b 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -1059,7 +1059,7 @@ print_insn_riscv (bfd_vma memaddr, struct disassemble_info *info) if (status != 0) { (*info->memory_error_func) (status, memaddr, info); - return status; + return -1; } insn = (insn_t) bfd_getl16 (packet); dump_size = riscv_insn_length (insn);