| Message ID | 20230316132101.205752-1-christophe.lyon@linaro.org |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <binutils-bounces+ouuuleilei=gmail.com@sourceware.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp478810wrt;
Thu, 16 Mar 2023 06:21:29 -0700 (PDT)
X-Google-Smtp-Source:
AK7set9pB83RRa+ZqN+mJ8Ukwk6ADV/D84U1X04Qm6N7qRZz9NzhJIv9lBlo0reWwRueaPp3YBtS
X-Received: by 2002:a17:906:640f:b0:88a:1ea9:a5ea with SMTP id
d15-20020a170906640f00b0088a1ea9a5eamr11099671ejm.65.1678972889349;
Thu, 16 Mar 2023 06:21:29 -0700 (PDT)
Received: from sourceware.org (server2.sourceware.org. [8.43.85.97])
by mx.google.com with ESMTPS id
y21-20020a170906471500b008c33c39014dsi5407922ejq.393.2023.03.16.06.21.28
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 16 Mar 2023 06:21:29 -0700 (PDT)
Received-SPF: pass (google.com: domain of
binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as
permitted sender) client-ip=8.43.85.97;
Authentication-Results: mx.google.com;
dkim=pass header.i=@sourceware.org header.s=default header.b=r21eDks9;
arc=fail (signature failed);
spf=pass (google.com: domain of
binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as
permitted sender)
smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org
Received: from server2.sourceware.org (localhost [IPv6:::1])
by sourceware.org (Postfix) with ESMTP id 4F15B3858035
for <ouuuleilei@gmail.com>; Thu, 16 Mar 2023 13:21:27 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4F15B3858035
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
s=default; t=1678972887;
bh=0nmrBhDh7C3ERh3FJkInQCQhDMlHBmkyPp96TgKAxY8=;
h=To:CC:Subject:Date:List-Id:List-Unsubscribe:List-Archive:
List-Post:List-Help:List-Subscribe:From:Reply-To:From;
b=r21eDks9A0/d4Br3aiJcPb/gq5akUCKS+cyGkVY9KkisB80JG445/zyPIJ1U8froC
G0mywPOlaRjgkbzBfdv5+G3yvwDmtko7bR7uAFMDSYsVG7UGBnWlbqQsd/cOUFICBl
uysWmwJqIBT91kw3l+thquIOXRkisaKhgyvrak3U=
X-Original-To: binutils@sourceware.org
Delivered-To: binutils@sourceware.org
Received: from EUR02-VI1-obe.outbound.protection.outlook.com
(mail-vi1eur02on2061b.outbound.protection.outlook.com
[IPv6:2a01:111:f400:fe16::61b])
by sourceware.org (Postfix) with ESMTPS id DBE943858D35
for <binutils@sourceware.org>; Thu, 16 Mar 2023 13:21:17 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DBE943858D35
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Mk78edJi1cv58K1VmyOwWH5NUJbd64rZFR4eo41TUWKZuGfe+tR0EmvGbpWiF7PqBBD+/By5yM81EUrB3zLRHRoZstIAAsmHv+UTkUueKOwYPqSXQjxJ2mqBI55HIjU9/CgVeIyFK2yBRdsDAv2PvbYPoVPel+NLfuPu/Jd1euflr61QWFWQkUJTIl7EtthX0lRil0KeCG15Cdu6zErDS1etwOmt8F/abldNRXdFhnIqmIlHqIU92xUpMr87p1kZeEHvrTQqay6qFPrrfm5jhxNw7Lydj+uo4DylwfoPEOP0cClqzSnRmv6Wg6tJ/IojdJAGg7OyyYNmzwy1wJSkeA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=0nmrBhDh7C3ERh3FJkInQCQhDMlHBmkyPp96TgKAxY8=;
b=N+wPX2aEK0V9hn76r6l+5/houz2Qxcz6KBKEclvIQVNoUCixm1uK1yhr+L7iCv0yYOcAD6AoGVCqbRKFK2KdG6uxGueDUZevsGF2S/8USmcdMMeYFFaYIIpQeCAbkToJUwtPd++vs8LIvgNhHVrLkuOCYNkSNFoZL4tVhB1LeoOkN1lWgeYaW02vrcIy5d+CD6xtJgwBglU6j+8R6dVz83ULYQ0VZ+G96j8bUCIaM5ZBHkRbYgTJp5ZhDUIELsG5h1SkhcNbQU6nHy7lsLpPC3tUxDfVMULwtV6CMrLIm92DB/Cdi5W4LU2g3tQ8nRYl/YVm1iK+agKAwsjwM4tBmg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip
is 40.67.248.234) smtp.rcpttodomain=sourceware.org smtp.mailfrom=linaro.org;
dmarc=fail (p=none sp=none pct=100) action=none header.from=linaro.org;
dkim=none (message not signed); arc=none
Received: from DU2PR04CA0203.eurprd04.prod.outlook.com (2603:10a6:10:28d::28)
by AM8PR08MB6340.eurprd08.prod.outlook.com (2603:10a6:20b:368::16)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.31; Thu, 16 Mar
2023 13:21:05 +0000
Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com
(2603:10a6:10:28d:cafe::b8) by DU2PR04CA0203.outlook.office365.com
(2603:10a6:10:28d::28) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.31 via Frontend
Transport; Thu, 16 Mar 2023 13:21:05 +0000
X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is
40.67.248.234) smtp.mailfrom=linaro.org; dkim=none (message not signed)
header.d=none;dmarc=fail action=none header.from=linaro.org;
Received-SPF: SoftFail (protection.outlook.com: domain of transitioning
linaro.org discourages use of 40.67.248.234 as permitted sender)
Received: from nebula.arm.com (40.67.248.234) by
DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.20.6199.18 via Frontend Transport; Thu, 16 Mar 2023 13:21:05 +0000
Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com
(10.251.24.32) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 16 Mar
2023 13:21:04 +0000
Received: from e129018.arm.com (10.57.17.55) by mail.arm.com (10.251.24.31)
with Microsoft SMTP Server id 15.1.2507.17 via Frontend Transport; Thu, 16
Mar 2023 13:21:04 +0000
To: <binutils@sourceware.org>, <nickc@redhat.com>
CC: Christophe Lyon <christophe.lyon@linaro.org>
Subject: [PATCH] Re: Add --enable-linker-version option
Date: Thu, 16 Mar 2023 14:21:01 +0100
Message-ID: <20230316132101.205752-1-christophe.lyon@linaro.org>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: DBAEUR03FT046:EE_|AM8PR08MB6340:EE_
X-MS-Office365-Filtering-Correlation-Id: 784469ab-bff1-44fb-3777-08db26214c1d
X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr
NoDisclaimer: true
X-MS-Exchange-SenderADCheck: 2
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
NpCaGA8AeKeZ51z1sLmhaBwDWl6/Pq5SBpDgcxl7NFrwJbV8jWkgGUfwTy/Np03fImwlYiklLZ4kFuq7OlLZJQ0SGfjjhdRNtNcP68A/1bHckHYOFmGKrzzoYQ4Dxvpq/s/6JARK3tzfmRg1X9/VDUAmJPLUiWKkhf7FFhNVpHkpdMAyMIGlzDXSDW5DLRzqIANd7J7bouthkKkbWcnFW/Df5GnTZCrhzOzxL3Cr5zdGOI+8E5WARWlWbNqNe7J2jNQDbbHEzXsivr9A9TuyPF2JRP03KbykPf8gnuPktqGa4Ww4glox4+2RiS02Y1foLKyUvXevNpvR2M91d5WtT2AaqOctsg6zhShKJ03nu2hSHylLe6JWW7kerqrdcj0qFkZ4y1VIG656V+l7W92CAGvIFuLG6vwVVkJIUsTaNjwz4qnZtFL9FMAhkpD9m8XJIlpiwF/xtJd65yRSFVkckmuqv8slIq8WaFElE/uyiKjFM+sGXUmF7B3pq1wnbCjtBRRZoZ4T0Nifltni+Xvt7WO/IcdJFLRvGdDVvy9qY7MJsCorruPjOWnMyY22RK8ghUQqiTy6XEZtcGcAmjllYyeUmyvp9C0gaHENJB3BEhalQQapvkvUeC0h0cz+r5qK+nrOZsCEYCgMuvg4c/GLJu3/Wjyh/4UtFAnvs5GNfg8Fcn2yS0wPHCtbAshWW55snSjaQronE2DfU9VjdCfcVUHJ3oUckoFh+k5I/nvol08=
X-Forefront-Antispam-Report: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE;
SFS:(13230025)(4636009)(346002)(136003)(396003)(39860400002)(376002)(451199018)(46966006)(40470700004)(83380400001)(2876002)(336012)(35950700001)(82310400005)(2616005)(47076005)(5660300002)(8676002)(70586007)(70206006)(41300700001)(81166007)(6666004)(2906002)(82740400003)(40460700003)(36756003)(1076003)(26005)(8936002)(498600001)(4326008)(356005)(110136005)(86362001)(40480700001)(316002)(21314003);
DIR:OUT; SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 13:21:05.5660 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id:
784469ab-bff1-44fb-3777-08db26214c1d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp:
TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[40.67.248.234];
Helo=[nebula.arm.com]
X-MS-Exchange-CrossTenant-AuthSource:
DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6340
X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS,
KAM_DMARC_NONE, SPF_HELO_PASS, SPF_NONE,
TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
<mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
<mailto:binutils-request@sourceware.org?subject=subscribe>
From: "christophe.lyon--- via Binutils" <binutils@sourceware.org>
Reply-To: christophe.lyon@linaro.org
Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org
Sender: "Binutils" <binutils-bounces+ouuuleilei=gmail.com@sourceware.org>
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760530676547318168?=
X-GMAIL-MSGID: =?utf-8?q?1760530676547318168?=
|
| Series |
Re: Add --enable-linker-version option
|
|
Checks
| Context | Check | Description |
|---|---|---|
| snail/binutils-gdb-check | success | Github commit url |
Commit Message
Frager, Neal via Binutils
March 16, 2023, 1:21 p.m. UTC
From: Christophe Lyon <christophe.lyon@linaro.org>
The recently-added ld-version*.d tests expect
.*GNU ld \(GNU Binutils\) 2.*
in the .comment section.
However, when buidling --with-pkgversion=XXX, we get
GNU ld (XXX) 2.[...]
instead, leading to a spurious FAIL.
This small patch replaces "GNU Binutils" with ".*" instead.
I inspected other testcases to see if we already had similar
occurrences but I couldn't see any, so I hope this fix is OK for the
purpose?
Thanks,
Christophe
---
ld/testsuite/ld-scripts/ld-version-2.d | 2 +-
ld/testsuite/ld-scripts/ld-version.d | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Comments
Hi Christophe, > The recently-added ld-version*.d tests expect > .*GNU ld \(GNU Binutils\) 2.* > in the .comment section. > > However, when buidling --with-pkgversion=XXX, we get > GNU ld (XXX) 2.[...] > instead, leading to a spurious FAIL. > > This small patch replaces "GNU Binutils" with ".*" instead. > > I inspected other testcases to see if we already had similar > occurrences but I couldn't see any, so I hope this fix is OK for the > purpose? It is. Patch approved - please apply. Cheers Nick
diff --git a/ld/testsuite/ld-scripts/ld-version-2.d b/ld/testsuite/ld-scripts/ld-version-2.d index c8738fd82d6..c696c093d69 100644 --- a/ld/testsuite/ld-scripts/ld-version-2.d +++ b/ld/testsuite/ld-scripts/ld-version-2.d @@ -4,4 +4,4 @@ # target: [is_elf_format] String dump of section '.comment': -.*GNU ld \(GNU Binutils\) 2.* +.*GNU ld \(.*\) 2.* diff --git a/ld/testsuite/ld-scripts/ld-version.d b/ld/testsuite/ld-scripts/ld-version.d index a55fc5e003b..7d1ffc5a45e 100644 --- a/ld/testsuite/ld-scripts/ld-version.d +++ b/ld/testsuite/ld-scripts/ld-version.d @@ -4,4 +4,4 @@ # target: [is_elf_format] String dump of section '.comment': -.*GNU ld \(GNU Binutils\) 2.* +.*GNU ld \(.*\) 2.*