diff mbox series

[v9,07/11] gas s_fill caused internal error in frag_new

Message ID 20230302220408.1925678-8-binutils@emagii.com
State Repeat Merge
Headers
Series [v9,01/11,gdb/testsuite] Fix gdb.rust/watch.exp on ppc64le |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Frager, Neal via Binutils March 2, 2023, 10:04 p.m. UTC 
  From: Alan Modra <amodra@gmail.com>

Fix an internal error after "non-constant fill count for absolute
section".

	* read.c (s_fill): Don't create frags after errors.
---
 gas/read.c | 30 ++++++++++++++++++++----------
 1 file changed, 20 insertions(+), 10 deletions(-)
diff mbox series

Patch

diff --git a/gas/read.c b/gas/read.c
index d43584be28c..5d83d35e0aa 100644
--- a/gas/read.c
+++ b/gas/read.c
@@ -2201,22 +2201,32 @@  s_fill (int ignore ATTRIBUTE_UNUSED)
 	as_warn (_("repeat < 0; .fill ignored"));
       size = 0;
     }
-
-  if (size && !need_pass_2)
+  else if (size && !need_pass_2)
     {
-      if (now_seg == absolute_section)
+      if (now_seg == absolute_section && rep_exp.X_op != O_constant)
 	{
-	  if (rep_exp.X_op != O_constant)
-	    as_bad (_("non-constant fill count for absolute section"));
-	  else if (fill && rep_exp.X_add_number != 0)
-	    as_bad (_("attempt to fill absolute section with non-zero value"));
-	  abs_section_offset += rep_exp.X_add_number * size;
+	  as_bad (_("non-constant fill count for absolute section"));
+	  size = 0;
+	}
+      else if (now_seg == absolute_section && fill && rep_exp.X_add_number != 0)
+	{
+	  as_bad (_("attempt to fill absolute section with non-zero value"));
+	  size = 0;
 	}
       else if (fill
 	       && (rep_exp.X_op != O_constant || rep_exp.X_add_number != 0)
 	       && in_bss ())
-	as_bad (_("attempt to fill section `%s' with non-zero value"),
-		segment_name (now_seg));
+	{
+	  as_bad (_("attempt to fill section `%s' with non-zero value"),
+		  segment_name (now_seg));
+	  size = 0;
+	}
+    }
+
+  if (size && !need_pass_2)
+    {
+      if (now_seg == absolute_section)
+	abs_section_offset += rep_exp.X_add_number * size;
 
       if (rep_exp.X_op == O_constant)
 	{