From patchwork Thu Mar 2 22:03:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Frager, Neal via Binutils" X-Patchwork-Id: 63598 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp92186wrd; Thu, 2 Mar 2023 14:04:52 -0800 (PST) X-Google-Smtp-Source: AK7set9jYon4gmXFyRAPn5buAjMCRWp2b33c9RLkglr/Nx5XCrYRfrAM+krCHNlzZ+3gyJphC9QC X-Received: by 2002:a17:906:348f:b0:8a9:f870:d259 with SMTP id g15-20020a170906348f00b008a9f870d259mr12078153ejb.48.1677794692699; Thu, 02 Mar 2023 14:04:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677794692; cv=none; d=google.com; s=arc-20160816; b=vnz08HxAgCW2J3PEgUzcNAnRFRiyxhw0rNbmdnhOx8JkcNqu0e3AvXrW1hDARgvebx BM9bsICXInJ1pcTMMnjMmTdTcA/gdRGHEw0f3qldPyUkz1N+lkPEl4fI4ji64VcRsmXr 8Zauikho8Y3gnvBHOwU4Okado17G4Plva1kmSLizZgRg4q50GRywfkp4mmDXYo8lXJov lEiS9WilxcjSANd0BFrtWRCmNQf76DpE5FVq9uL23ZQ3ElvKCdVD21K/nU2cm5bVKd/D zZWAnFFtMq38JJN21D2xhNasWqRUs5LwKP/7l1wwnaJusxFA3HLonVXpxXQfIrrDv8rW djaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=JfbCZBLb48icnhGbPFicaIOCZfainLCpcLSDImnD7v8=; b=LaHSplittCybF02O2YzNSGDVq45nYsi6rqddl5cD3xc7UABPoFtR52vBVyCqda3yUI LoF0I9FQGp/UK+EODMzR0/gxMHjcF6FIiL5OoH0yI25cx1I0izVT4QUvDapLoeBpnxg0 USjDIEQ8nvG3AESXp0e+9+c2y0LpJk4xbd2NaB1TpgVX0bJKphMrxDNvxpMh9wn2aike ltrCCcV8ya+kQNzH5Myrzos5w9y6HMZdwT45+SFAZYtYmvVEowv78Y3Pb+l8BhiIbE5B vUodyHYChvvLJjvQT1t+310N/a1bEkupTDUmM9HD6t1VSXfAiK3TfMVDKaq5PVliBKqA cdeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=ll+zMfat; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id qn1-20020a170907210100b008d46bf1a665si333209ejb.891.2023.03.02.14.04.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 14:04:52 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=ll+zMfat; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7CE02385E839 for ; Thu, 2 Mar 2023 22:04:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7CE02385E839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677794678; bh=JfbCZBLb48icnhGbPFicaIOCZfainLCpcLSDImnD7v8=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ll+zMfatfGOIrUxMPAk30bqihtV/GRw7Or+CSQnrjPp18cf/q3gVYV9ze4lDZNuCU 45owu7e9M8SbNbtl93ZaeFeiuNf0lg0PotQdRPEBwsx3tdLd9ygHchGJjTZE+GgLOf l6moItokS+zXCKuQUcC7krWVbAbCRzCvq2f1ojGo= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from emagii.se (www.emagii.com [185.133.207.17]) by sourceware.org (Postfix) with ESMTPS id 0BF893857C4F for ; Thu, 2 Mar 2023 22:04:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0BF893857C4F Received: from valinor.ownit.se (84-55-68-216.customers.ownit.se [84.55.68.216]) by emagii.se (Postfix) with ESMTPSA id 4B5631201F3; Thu, 2 Mar 2023 23:04:26 +0100 (CET) Received-SPF: pass (emagii.beebytevps.io: connection is authenticated) To: binutils@sourceware.org Cc: nickc@redhat.com, Tom Tromey Subject: [PATCH v9 02/11] Remove value_in Date: Thu, 2 Mar 2023 23:03:59 +0100 Message-Id: <20230302220408.1925678-3-binutils@emagii.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230302220408.1925678-1-binutils@emagii.com> References: <20230302220408.1925678-1-binutils@emagii.com> MIME-Version: 1.0 X-PPP-Message-ID: <167779466686.1167673.1622141584737926033@localhost.localdomain> X-PPP-Vhost: emagii.com X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_FAIL, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ulf Samuelsson via Binutils From: "Frager, Neal via Binutils" Reply-To: binutils@emagii.com Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759295247665030163?= X-GMAIL-MSGID: =?utf-8?q?1759295247665030163?= From: Tom Tromey value_in is unused. From git log, it seems to have been part of the Chill language, which was removed from gdb eons ago. This patch removes the function. Tested by rebuilding. --- gdb/valarith.c | 23 ----------------------- gdb/value.h | 2 -- 2 files changed, 25 deletions(-) diff --git a/gdb/valarith.c b/gdb/valarith.c index a6a5f5102a2..070ee63808e 100644 --- a/gdb/valarith.c +++ b/gdb/valarith.c @@ -2020,26 +2020,3 @@ value_bit_index (struct type *type, const gdb_byte *valaddr, int index) rel_index = TARGET_CHAR_BIT - 1 - rel_index; return (word >> rel_index) & 1; } - -int -value_in (struct value *element, struct value *set) -{ - int member; - struct type *settype = check_typedef (set->type ()); - struct type *eltype = check_typedef (element->type ()); - - if (eltype->code () == TYPE_CODE_RANGE) - eltype = eltype->target_type (); - if (settype->code () != TYPE_CODE_SET) - error (_("Second argument of 'IN' has wrong type")); - if (eltype->code () != TYPE_CODE_INT - && eltype->code () != TYPE_CODE_CHAR - && eltype->code () != TYPE_CODE_ENUM - && eltype->code () != TYPE_CODE_BOOL) - error (_("First argument of 'IN' has wrong type")); - member = value_bit_index (settype, set->contents ().data (), - value_as_long (element)); - if (member < 0) - error (_("First argument of 'IN' not in range")); - return member; -} diff --git a/gdb/value.h b/gdb/value.h index f2a4907ab81..c3eb96bf143 100644 --- a/gdb/value.h +++ b/gdb/value.h @@ -1270,8 +1270,6 @@ extern struct value *value_bitstring_subscript (struct type *type, extern struct value *register_value_being_returned (struct type *valtype, struct regcache *retbuf); -extern int value_in (struct value *element, struct value *set); - extern int value_bit_index (struct type *type, const gdb_byte *addr, int index);