From patchwork Thu Mar 2 22:04:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Frager, Neal via Binutils" X-Patchwork-Id: 63605 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp93723wrd; Thu, 2 Mar 2023 14:08:36 -0800 (PST) X-Google-Smtp-Source: AK7set9zOJb5NuS2g73Sqy0t+hOTQkuhcvJMHDyb8Ioj/syO6yqYOCI2iseYIEvfRvDCRzbjy1hs X-Received: by 2002:a17:907:2d1f:b0:88f:8a5:b4cd with SMTP id gs31-20020a1709072d1f00b0088f08a5b4cdmr14678623ejc.1.1677794915982; Thu, 02 Mar 2023 14:08:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677794915; cv=none; d=google.com; s=arc-20160816; b=pa487EvYTziWnuA8fm1YRCHr7uHD35gjztR3UP1UZdAAJO4hkqrJm+NfFXrlfcDNTt m3QRg4G/BXjFk6b3dzhhHZvkrp6sNE1qsO0Mc1NaLbe5iHEwrs/C8wvhDYJRdfHAqeR9 Nvx94ITufVj0jTAU3H/14whbXGNhYaVnowQTHj8E3w8sMfmJYhaeaExfztqSH/jiA6ns EdmzuK8Fns/uJ2+aPQ3BennMawzbUxH2nzqzaeiQs8fhjgUsNNOIksWsANV1vsDzNbiI YW1bdTyiRgove5WcPQKsdT2ZCY2umcPLT/CtsU6mBJFMi54zaUkZTBABo49SrID9sxo7 hpHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=ntY1HitF77eIvTp3L5Eekmc/x9yDF1ibDFbyWbKUEmw=; b=QJimmuIIUrIQCD9rh6qA8AEiMSlwr/lAkKPwPEDRbEBG9M5sW6KXuAf25eIs5awwBo QZhJYa80zeFBdGMJOpb7pnBpCI7ts7WRT4VbOAlsZXA6ddvsHwwR7t783fggIeXWY9vS vhzAtEOUS6FZVty9MXv54I7CH/L+7wNV0Es3dPZ+yOnSYSgJS8R0wGAmu1R1mw348Ug8 NcTvMOPtnqwBMQ3P0L1pcJJLmxMz+Kae0Vi2YvCwKnHRPOm08HbIEWjyp9e0x0Q2uzPh LSYXaYYLfy/8yU6S3L5TNELO7+pjAylTQUfHZyemrLEF5GmNw5iBl06avTCwMsyn9Dw5 XEpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=CjYVosel; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id e25-20020a170906375900b008dffd95e783si379551ejc.568.2023.03.02.14.08.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 14:08:35 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=CjYVosel; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2CCF43836E8C for ; Thu, 2 Mar 2023 22:06:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CCF43836E8C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1677794765; bh=ntY1HitF77eIvTp3L5Eekmc/x9yDF1ibDFbyWbKUEmw=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CjYVoselsCysKT17v99NNW2fz7DE/amZIXsy6AzF14X/nZyGkzpJD0K+RbMrGeUpa mDbluDy0CTNptzDce1c85zv9yiY2hF9DrpVa/8takASzesQXWnxBJDpDukGfsPZcEA 3ge0mQJmUFCAjWjk11C5X+MjEevH8PaijK8LkgI0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from emagii.se (www.emagii.com [185.133.207.17]) by sourceware.org (Postfix) with ESMTPS id E8DAF3858C62 for ; Thu, 2 Mar 2023 22:04:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8DAF3858C62 Received: from valinor.ownit.se (84-55-68-216.customers.ownit.se [84.55.68.216]) by emagii.se (Postfix) with ESMTPSA id 8DAA41201F3; Thu, 2 Mar 2023 23:04:36 +0100 (CET) Received-SPF: pass (emagii.beebytevps.io: connection is authenticated) To: binutils@sourceware.org Cc: nickc@redhat.com, Tom Tromey , Bruno Larsen Subject: [PATCH v9 10/11] Fix btrace regression Date: Thu, 2 Mar 2023 23:04:07 +0100 Message-Id: <20230302220408.1925678-11-binutils@emagii.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230302220408.1925678-1-binutils@emagii.com> References: <20230302220408.1925678-1-binutils@emagii.com> MIME-Version: 1.0 X-PPP-Message-ID: <167779467686.1167769.17566891087244466437@localhost.localdomain> X-PPP-Vhost: emagii.com X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_FAIL, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ulf Samuelsson via Binutils From: "Frager, Neal via Binutils" Reply-To: binutils@emagii.com Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759295481940382381?= X-GMAIL-MSGID: =?utf-8?q?1759295481940382381?= From: Tom Tromey Tom de Vries pointed out that my earlier patch: commit 873a185be258ad2552b9579005852815b4da5baf Date: Fri Dec 16 07:56:57 2022 -0700 Don't use struct buffer in handle_qxfer_btrace regressed gdb.btrace/reconnect.exp. I didn't notice this because I did not have libipt installed. This patch fixes the bug. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30169 Tested-By: Bruno Larsen --- gdbserver/linux-low.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index dec1944d45f..0ca3bb1cd6a 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -6781,7 +6781,7 @@ linux_low_encode_raw (std::string *buffer, const gdb_byte *data, elem[0] = tohex ((*data >> 4) & 0xf); elem[1] = tohex (*data++ & 0xf); - buffer->append (elem); + buffer->append (elem, 2); } *buffer += "\n";