Message ID | 20230217192905.3160819-4-tom@tromey.com |
---|---|
State | Accepted |
Headers |
Return-Path: <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp29522wrn; Fri, 17 Feb 2023 11:30:59 -0800 (PST) X-Google-Smtp-Source: AK7set8fX2rJq0egz4kQ8IpZWmMg8qlBAF1/+YqQMpgVkBpYbhPfTE7Vy22suvplxRRRmzvuR2GI X-Received: by 2002:a17:906:f298:b0:877:8ae7:2e44 with SMTP id gu24-20020a170906f29800b008778ae72e44mr90949ejb.5.1676662259584; Fri, 17 Feb 2023 11:30:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676662259; cv=none; d=google.com; s=arc-20160816; b=lxOaKUVkFWcoVMQ9o1CT9+N8Kk+evC1WmxdBJKPJiz2WCwD72mHUfN3mnE/2RA6S3C /qHtIOZCzJBh7UxuJTZCHHMLXYhvFM9DvSYKg0xKzgQ3Vw2A9Q+b6yyDYaO1L8HtkBIs 0Wu8FFxlOL8YX/HoMI4LTJ9LNd9ds1xsITYpsM7QlmtP1o/E6fF67IOZI2itnw6dj0rv 6gjIaYoWNXgi0aZ4y8+cL4SdHGnoAw0miAWSmhddbV3zGi5J/KJ2YlfOtu4mCF1rOenZ rx5ko+Vaa9Pa3/ZsP9G5EEu9OH5csg8mpTEQ5hssdgNG02Ojj0XotCFqPX4E5h4yzLcN WtcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dmarc-filter:delivered-to; bh=0ip17iN1PuuyM3zpJkFkDU6uCsCNQ1RyMWM5fC7sH3E=; b=APlcokDsShgs1GskgMOcca3Dr6Yo7H5kCQoaweybNH0E91L/obK7dC1v/4XrmVOwJN bcKv0oLSf89Utqsn4IrdfIBwz8aMsuz5aF6QKLtLzwyVGO3fM+J6psBMzokBfIN3PwFf UJY0dTCPN0N0H8yyWXbL06lulOxVdHMV+No35wmn9o3GyACDAZ1I9PSeqqgqygokz/Sl ES/lOJgbHBDBrZQvhv481XWHNk000pAc37nF+Y4k7XMiu4B/NJeBrAJlhUpf8XLYsFV9 MKq0/pEY4jwh2EALJA5s4vnIp1n495HFMMT7UydNKrj9MYb79EwvztaKiPOpsKVscuHl WJsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@tromey.com header.s=default header.b=q7IyiP5l; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id vs20-20020a170907139400b008b1493c2870si6232777ejb.465.2023.02.17.11.30.59 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 11:30:59 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=fail header.i=@tromey.com header.s=default header.b=q7IyiP5l; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 572B6382E686 for <ouuuleilei@gmail.com>; Fri, 17 Feb 2023 19:29:58 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 3F0653857BB2 for <binutils@sourceware.org>; Fri, 17 Feb 2023 19:29:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F0653857BB2 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 844DA10048773 for <binutils@sourceware.org>; Fri, 17 Feb 2023 19:29:16 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id T6Q0psEKHBkq3T6Q0p2EiM; Fri, 17 Feb 2023 19:29:16 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DdHSFthW c=1 sm=1 tr=0 ts=63efd58c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=N4Iy2rMeAAAA:8 a=zstS-IiYAAAA:8 a=8vZBmT7D0Ky6Z7zk3r4A:9 a=5hpKZm7SNATvkXljoCd7:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0ip17iN1PuuyM3zpJkFkDU6uCsCNQ1RyMWM5fC7sH3E=; b=q7IyiP5lcOKQ/xQUoo02kGMXYe z1P0T07vXbeDQ+W0f9HAVEXN3B1zNewMhdEhXnMyDWQgyUJ4WaGIvNPzH6krIUKAK8HBAi0vwO01n TqD+ReclOMEmzHsLrYSpCJtF3; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37066 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <tom@tromey.com>) id 1pT6Q0-002oM4-Bl; Fri, 17 Feb 2023 12:29:16 -0700 From: Tom Tromey <tom@tromey.com> To: binutils@sourceware.org Cc: Tom Tromey <tom@tromey.com> Subject: [PATCH 3/4] Hoist the SECTION comment in opncls.c Date: Fri, 17 Feb 2023 12:29:04 -0700 Message-Id: <20230217192905.3160819-4-tom@tromey.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230217192905.3160819-1-tom@tromey.com> References: <20230217192905.3160819-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pT6Q0-002oM4-Bl X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (localhost.localdomain) [75.166.130.93]:37066 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758107805444492787?= X-GMAIL-MSGID: =?utf-8?q?1758107805444492787?= |
Series |
More fixes to chew documentation
|
|
Checks
Context | Check | Description |
---|---|---|
snail/binutils-gdb-check | success | Github commit url |
Commit Message
Tom Tromey
Feb. 17, 2023, 7:29 p.m. UTC
The opening and closing node in BFD starts: File: bfd.info, [...] /* Set to N to open the next N BFDs using an alternate id space. */ extern unsigned int bfd_use_reserved_id; 2.13 Opening and closing BFDs ============================= That is, there's a stray C comment and declaration before any other text or subsections. This occurs because the code fragment for bfd_use_reserved_id comes before the SECTION comment. Hoisting it makes this a little nicer. bfd/ChangeLog 2023-02-17 Tom Tromey <tom@tromey.com> * opncls.c: Hoist the SECTION comment. --- bfd/ChangeLog | 4 ++++ bfd/opncls.c | 16 ++++++++-------- 2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/bfd/opncls.c b/bfd/opncls.c index 95906526973..15ee4f7f44e 100644 --- a/bfd/opncls.c +++ b/bfd/opncls.c @@ -37,6 +37,14 @@ #define S_IXOTH 0001 /* Execute by others. */ #endif +/* +SECTION + Opening and closing BFDs + +SUBSECTION + Functions for opening and closing +*/ + /* Counters used to initialize the bfd identifier. */ static unsigned int bfd_id_counter = 0; @@ -179,14 +187,6 @@ _bfd_free_cached_info (bfd *abfd) return true; } -/* -SECTION - Opening and closing BFDs - -SUBSECTION - Functions for opening and closing -*/ - /* FUNCTION bfd_fopen