diff mbox series

[1/2] gas: RISC-V: Add a test for near->far branch conversion

Message ID 20230130210642.7579-1-palmer@rivosinc.com
State Accepted
Headers
Series [1/2] gas: RISC-V: Add a test for near->far branch conversion |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Palmer Dabbelt Jan. 30, 2023, 9:06 p.m. UTC 
  This works in GAS and has for a very long time, but I couldn't find a
test case for it.  It doesn't appear to be documented anywhere, but GCC
depends on it and I'd bet a bunch of handwritten assembly does too so
it's probably too late to drop.
---
 gas/testsuite/gas/riscv/far-branch.d | 13 +++++++++++++
 gas/testsuite/gas/riscv/far-branch.s |  6 ++++++
 2 files changed, 19 insertions(+)
 create mode 100644 gas/testsuite/gas/riscv/far-branch.d
 create mode 100644 gas/testsuite/gas/riscv/far-branch.s

Comments

Nelson Chu Jan. 31, 2023, 3:37 a.m. UTC | #1 
I always thought the test cases were already there, because the
assembler branch relaxation (or branch conversion, whatever called)
has been supported since the very beginning of the risc-v porting.
Anyway, both of the gas and ld test cases for this are what we need,
so thanks for adding them :)

Nelson

On Tue, Jan 31, 2023 at 5:07 AM Palmer Dabbelt <palmer@rivosinc.com> wrote:
>
> This works in GAS and has for a very long time, but I couldn't find a
> test case for it.  It doesn't appear to be documented anywhere, but GCC
> depends on it and I'd bet a bunch of handwritten assembly does too so
> it's probably too late to drop.
> ---
>  gas/testsuite/gas/riscv/far-branch.d | 13 +++++++++++++
>  gas/testsuite/gas/riscv/far-branch.s |  6 ++++++
>  2 files changed, 19 insertions(+)
>  create mode 100644 gas/testsuite/gas/riscv/far-branch.d
>  create mode 100644 gas/testsuite/gas/riscv/far-branch.s
>
> diff --git a/gas/testsuite/gas/riscv/far-branch.d b/gas/testsuite/gas/riscv/far-branch.d
> new file mode 100644
> index 00000000000..e781e3eadb5
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/far-branch.d
> @@ -0,0 +1,13 @@
> +#as: -march=rv32i
> +#objdump: -d
> +
> +.*:[   ]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[^:]+:[        ]+00b51063[     ]+bne[  ]+a0,a1,0 <target>
> +#...
> +[^:]+:[        ]+00b50463[     ]+beq[  ]+a0,a1,.*
> +[^:]+:[        ]+ff9fe06f[     ]+j[    ]+0 <target>
> diff --git a/gas/testsuite/gas/riscv/far-branch.s b/gas/testsuite/gas/riscv/far-branch.s
> new file mode 100644
> index 00000000000..2b369ffb538
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/far-branch.s
> @@ -0,0 +1,6 @@
> +target:
> +       bne a0, a1, target
> +.rep 1024
> +       nop
> +.endr
> +       bne a0, a1, target
> --
> 2.39.0
>
Jan Beulich Jan. 31, 2023, 8:57 a.m. UTC | #2 
On 30.01.2023 22:06, Palmer Dabbelt wrote:
> --- /dev/null
> +++ b/gas/testsuite/gas/riscv/far-branch.d
> @@ -0,0 +1,13 @@
> +#as: -march=rv32i
> +#objdump: -d
> +
> +.*:[ 	]+file format .*
> +
> +
> +Disassembly of section .text:
> +
> +0+000 <target>:
> +[^:]+:[ 	]+00b51063[ 	]+bne[ 	]+a0,a1,0 <target>
> +#...
> +[^:]+:[ 	]+00b50463[ 	]+beq[ 	]+a0,a1,.*

Isn't the target of this branch kind of relevant here, and hence shouldn't
be "anything" in the expectations?

Jan
diff mbox series

Patch

diff --git a/gas/testsuite/gas/riscv/far-branch.d b/gas/testsuite/gas/riscv/far-branch.d
new file mode 100644
index 00000000000..e781e3eadb5
--- /dev/null
+++ b/gas/testsuite/gas/riscv/far-branch.d
@@ -0,0 +1,13 @@ 
+#as: -march=rv32i
+#objdump: -d
+
+.*:[ 	]+file format .*
+
+
+Disassembly of section .text:
+
+0+000 <target>:
+[^:]+:[ 	]+00b51063[ 	]+bne[ 	]+a0,a1,0 <target>
+#...
+[^:]+:[ 	]+00b50463[ 	]+beq[ 	]+a0,a1,.*
+[^:]+:[ 	]+ff9fe06f[ 	]+j[ 	]+0 <target>
diff --git a/gas/testsuite/gas/riscv/far-branch.s b/gas/testsuite/gas/riscv/far-branch.s
new file mode 100644
index 00000000000..2b369ffb538
--- /dev/null
+++ b/gas/testsuite/gas/riscv/far-branch.s
@@ -0,0 +1,6 @@ 
+target:
+	bne a0, a1, target
+.rep 1024
+	nop
+.endr
+	bne a0, a1, target