From patchwork Fri Dec 9 01:52:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Harmstone X-Patchwork-Id: 31570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp528320wrr; Thu, 8 Dec 2022 17:52:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf4IthM+aHsKhJqPYO3Co8XOKE1lT0brOVeDw+HQMBHbG42bw+gouIllljt7ArxiMSJhcQmP X-Received: by 2002:a17:907:8c8e:b0:78d:f457:1063 with SMTP id td14-20020a1709078c8e00b0078df4571063mr4272506ejc.32.1670550777073; Thu, 08 Dec 2022 17:52:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670550777; cv=none; d=google.com; s=arc-20160816; b=VjxJCW+iIjZJBHUAujHSvt9eaUvk5mppQu70i5YfxLw/Phjx2O6uZjsJpUE25iYV09 0xKcl5bA7PJqeB8XKKH6zifG6zgvoN4pELfCTomUPAmUoInIi4Y4Ok4Eep1v2zZKhg1F hqOZjcUz0kYILJzTOR5cHNIWHBzziurjI7r+C8oAd1/FJyCOjaxp/vTMSC3CKdfm3xqt jLJsnO74ofCyvaf1Nk4HY5mmYZlP+7y2iadrSwk9huATBe3Z8vrVlK+CzJw/wwoghCUX catKhWbLqx6EMSw9bI4IoUoYUUpdKCu/mmFMthQdnaHftuMaPG/J6jmBVTo7vmjcaulz 8wgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:dmarc-filter:delivered-to; bh=xs6f9Fl+fCvfMD9EKWlNPkbPozQ5JFHLBNSwUpQJ8es=; b=igiQrXF9km1MgJmjg4bE7zg3URyZHGoGJMaKHcmuwPA4FRGSz3AnhvaMsNqXXv+MUw xdkrJzNZVwg5cHu1WXDROIh/HGH79uq4tpZeUKfHy+245rB41ZBIkR5eIT6GT1PXEGhE ye9cAr7kcfzylcBSyKT45ugPb2ZVtLtzr08ZYB/J8mg1bkdK+dC2uRujkJWSKD+AKOxE sMOnEAYmmzpTCxexzgqcvdojyKMQmwF4L6mspmP3Ev0fjMi5IB7pTq0XZnx+0oL7myIf 9d+5TJAMa599rDEv7uaILsYrW25vkWKQxeb+/9g5z+ric5V/0VoT3hMcQdRHVw+WOZli RBmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=MnvAZVFL; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id cs16-20020a170906dc9000b007add0e1a187si38926ejc.594.2022.12.08.17.52.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 17:52:57 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20210112 header.b=MnvAZVFL; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70E6C382E18F for ; Fri, 9 Dec 2022 01:52:54 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 94837387723A for ; Fri, 9 Dec 2022 01:52:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 94837387723A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x32c.google.com with SMTP id ay40so2567523wmb.2 for ; Thu, 08 Dec 2022 17:52:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=xs6f9Fl+fCvfMD9EKWlNPkbPozQ5JFHLBNSwUpQJ8es=; b=MnvAZVFLeIUgYUSlmVK3/LmdC6tKHFNNMPYbn9mNcoRhXor5LbPwk1782kE59Dd6nq iSHrgdx33fHNr/XTSLDSAcpzQxh3CutUAr+EdR50axDFF9/i9VqCayYJmDkg5SXNBaQu UkFgokyQ3mBiok3VcxbHPuQXDEdLi/VC9Tg7oNDCc1RcANGNUS/BM/Vbf7gPJwh91vi2 cVGPMh9K/CfYB7YjMzyXUvjzf27y1NDGq+EFQhX7n1x2fXbwZvg07XPnpu2tiQsJv2KG GHG/l1HU+NMaqxgcGE/Wkmm2ajljzEIb4v70Y/qN/s1AfvUOlKamO/rdQAYM5x09lqMp 8E3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xs6f9Fl+fCvfMD9EKWlNPkbPozQ5JFHLBNSwUpQJ8es=; b=Xyqt+QSRtAjqn4MHnKru1VoTPRJe00iX2bbEuETDz3jsCGdf2GIHZFZGvWNSJuyfIS 7pd7sF7nv2KlQEVX2Bbg9crDtV54RnHevPIq4c+1e2V5m1R+4Ut2pwKjK8d29dlpso3A Md/TBw7sr44fMGUcmjN0Ndu7o8giFwPCmDQxztXaB+A3h3Uw4aOsHu+NkuabTqVVUUXC U3IZhZEBG/AbcSqraFdecuS0uuGuHcPUwQMbnZ/Xwt9kia17nRHedPGyeqBiVilVUDDF KBG3597lotxp2VO9VwVfNMbY9dHKFzvl9hIRZkXGpEHUu5SfymUwysl680muZO6WGK+V wZSA== X-Gm-Message-State: ANoB5pk+lWr7n2DojKfZkDJcZk5kzXv56DlkuTCKaNiXP7hDgOK2qnxo XevlxXInPcaTKxKB223qpPoam7gmcag= X-Received: by 2002:a1c:6a04:0:b0:3c6:e63d:fce2 with SMTP id f4-20020a1c6a04000000b003c6e63dfce2mr3299239wmc.9.1670550766077; Thu, 08 Dec 2022 17:52:46 -0800 (PST) Received: from beren.harmstone.com ([2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f]) by smtp.gmail.com with ESMTPSA id fc18-20020a05600c525200b003d04e4ed873sm7473139wmb.22.2022.12.08.17.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 17:52:45 -0800 (PST) From: Mark Harmstone To: binutils@sourceware.org, nickc@redhat.com Cc: Mark Harmstone Subject: [PATCH 03/10] ld: Fix segfault in populate_publics_stream Date: Fri, 9 Dec 2022 01:52:33 +0000 Message-Id: <20221209015240.6348-3-mark@harmstone.com> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221209015240.6348-1-mark@harmstone.com> References: <20221209015240.6348-1-mark@harmstone.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751699451853323201?= X-GMAIL-MSGID: =?utf-8?q?1751699451853323201?= --- ld/pdb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ld/pdb.c b/ld/pdb.c index b37a5a0ebfd..3edeab25332 100644 --- a/ld/pdb.c +++ b/ld/pdb.c @@ -1410,6 +1410,9 @@ populate_publics_stream (bfd *stream, bfd *abfd, bfd *sym_rec_stream) for (bfd *in = coff_data (abfd)->link_info->input_bfds; in; in = in->link.next) { + if (!in->outsymbols) + continue; + for (unsigned int i = 0; i < in->symcount; i++) { struct bfd_symbol *sym = in->outsymbols[i];