From patchwork Wed Dec 7 19:52:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 31015 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp377179wrr; Wed, 7 Dec 2022 11:56:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf6rhOmocesb3cvC/FK3V4yaL7JwmmI7Tz1lVFqgOVmi8HNIQafs2jyS88oSmSLdW30ou/Ly X-Received: by 2002:a17:906:3e41:b0:78d:bc9f:33da with SMTP id t1-20020a1709063e4100b0078dbc9f33damr75978944eji.80.1670443010817; Wed, 07 Dec 2022 11:56:50 -0800 (PST) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id rn5-20020a170906d92500b007c0e314d945si7120525ejb.654.2022.12.07.11.56.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 11:56:50 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=NtLBTsTY; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1AD02392B13A for ; Wed, 7 Dec 2022 19:54:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1AD02392B13A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670442897; bh=SyI/M21AuCIHdnh05jmfxld4VvfQM3cFgpTXiIyVbwg=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=NtLBTsTY3pQ4H0OvvyZ9EO8sN7T2JrtNlRtRvf1TWZ86x/PLDd7ElTSQG2WvPYWvw wU9atlDrfvywc+fMxx5xi/N2nj1iPwiYwTvxuec2e3fh6IbOD4slfzRgvpGXTtiG/a wL7hL0eldErIhnd1cLf84TVP0a855XPOfFJUoRu8= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 94B893921786 for ; Wed, 7 Dec 2022 19:52:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 94B893921786 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B7IwTFQ016130 for ; Wed, 7 Dec 2022 19:52:46 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3maud719pu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 07 Dec 2022 19:52:46 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2B7ItEK9009860 for ; Wed, 7 Dec 2022 19:52:45 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2102.outbound.protection.outlook.com [104.47.58.102]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3maa69m3g9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 07 Dec 2022 19:52:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UAVAGUAIqR+BrSryXC7zRuYqRYd9E05ddd9/BV0DbI77Jm2sNjDS8xL2aev6LRIU3y0f9hoZ2IFVGEZL3cjJjK8fvsdHTHe4qIGnmoVlSOPZSwx+ZDExKRepVWckj41hgyea4cb18PwRl31WSHoZlMbJZjKyRGqHrZww8Bfk91Usvp9bdKza4W5bLBYipqXpYWJNNgDViQH36TxuPaqZ5V4re+LVRrAIHwC0mKHs3/52IS8u096o8ZYJEtuUo6voFBJIKSyHpp0QKfr7/Da+oPuFvnmZCXaajab21PeLznlLAhhRNjAjwF6NDC/16e7kJ9mSvnVzFBeraTZDOTiAgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SyI/M21AuCIHdnh05jmfxld4VvfQM3cFgpTXiIyVbwg=; b=EOHbCXKl95cGUaK6OYpfIA+0wAY3A7sxFHguB1ER4ChjSbGKBCwX8vx6USK2bY6vVc+oEmIUg5zqwuJCN0PFze6pINxfRFLwyq6PgP6HZdHN/NkwSZbBUkQomcgHLMv3warKBzmj9ohKEqd3Qd+U37uUnPc39X72GUsADliXDoEqzOfzXKf8/Vxw8wG2RV7j01fTWwJu2b8HiHjI2VBDbOhxGBOL59x+/syMK0a2hWXjdH+h2EBpUcxwFGBx7QxGUMWCuZ4fwNAQbUqzrfhF6T32My8GeTLGfXeKqOW9bFufIvTkEI+5x8CBs9dxNliiWQ5Xae/1OEZGw0ApfAJcxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by BN0PR10MB5125.namprd10.prod.outlook.com (2603:10b6:408:12e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 19:52:44 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc%5]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 19:52:44 +0000 To: binutils@sourceware.org Cc: weimin.pan@oracle.com, Indu Bhagat Subject: [PATCH 6/6] objdump: sframe: fix memory leaks Date: Wed, 7 Dec 2022 11:52:22 -0800 Message-Id: <20221207195222.1182788-7-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221207195222.1182788-1-indu.bhagat@oracle.com> References: <20221207195222.1182788-1-indu.bhagat@oracle.com> X-ClientProxiedBy: MW3PR05CA0007.namprd05.prod.outlook.com (2603:10b6:303:2b::12) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|BN0PR10MB5125:EE_ X-MS-Office365-Filtering-Correlation-Id: 045841f1-5b2b-436c-3ba6-08dad88c9b44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q3JLZbw5NxX0uR77nXdG1ZzIWlXzvcAT5mXn4d8W9trB2Dd3MoRBVeRQvbuQHQfEcAWGeV1+ienD+TBPlPLOiPrrDmYmNY9Sw/7LMi/yX1lTvGmBLiGa5EHJRV3cn4+hU6rLEgPzZzy9bcbUlYWm/XUu417QMcE7REH5ShJyQpZjJZgEE4EU2XRDoZwVojSKEwPzIsf7HHAMG5p/svXymmfUVJmuro6jntygWTVpWLT8KcFe1XkHjKiDKMsIXgv/O5lf128qPI71V1AYz5l4ZGtk2HRmrqTkDwtdgLk9uBBB+lR7QEoiA6Jmk+NIPxY+SX+sMY8IqG82H2m7UvtgRLhAKUYsQYN6UAZd7TQylsxo6rqCHirgPtRptfdOy704hkxS9mqsd2d8SEf6Y3rQsR/V87kCPjymX/ZfVKjkZ5Z1tQRi2IDBVWh3DNAu3SkdKe//5CnmShJ0PloQD4/z26GNHUGGuBnRhy6Y6ELUVI6+j0Xq9XrU9XSBONf0KKHcaUE17dDBUyc/EzogLQ4qFONDRdkd0wI4/KuXfPWtQQcL9BbfmvEH4ylm5U4dc7P5P7Q1oMQWqyXIM+EGEiweniK4el9t1UJdn+SsNNGjku9ovi73QytvN3Xm6yFpTiuSYsB28U0f8AkrN9TIqVZIXw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(396003)(136003)(366004)(39860400002)(346002)(451199015)(83380400001)(38100700002)(8936002)(4326008)(66946007)(66476007)(6916009)(86362001)(41300700001)(4744005)(44832011)(2906002)(66556008)(8676002)(478600001)(6666004)(5660300002)(6506007)(186003)(6512007)(107886003)(316002)(2616005)(6486002)(1076003)(36756003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /AZTLTmJg8kXA4r8+jQ0lZ/hkGWNXxjIJ0C4J7tFLuJaYgnCAyZR3zwfnrIS5N+V1Xb/8A49+uRmuipVA2Fvu4XYySXOFv7luCeJxUr+6Zx+h+Lrj3dzLrwI4CbxRa8cnfAlrCk1i3/JTdJaPdAod3VbiT2JqImDoC1dNBgI37q8NfAUJBZ2q36V/TWQAmhMItK/U0fQ2wxjToDOVxkCbz8U8BZZLa/H8p21mElmiJkhxEK3MRPk1j0tNvoD+0M5crV0QqyJWwLSVLxdpODqHqdrNGOeFLEJzjCVs8H/Pvmy4Ew5ZYEXiYX8wt1BKcBlGAhz9c6jfUfaLdBbZlNNUHUC+WrjYLyOkkUZblz85Mgp+5fpM/Fw2WM8+6i5OokQAkszC7rnUCYtR4bsvmJ1CAaBBBVvDZWIlZx6nz1XHkWP5zanQXp9BRkt1GSKy05pSKmyHxychF9FI8PyGMyzSet4iqJNF1vn91JtCTFu+HEmOxI1ijAXu6EpaDYXk79Ee/qiqmAO3V4fn0abV0KL7EH0oLwbj9Kf8griIzAfqwDmnFVqKAee2grivUz+7KB6hf0LVcHua/u05uziC5BntBI4I4QUbO05FNtKmp4VvLdNXLTvTi5cHYUp3udfyJCWG5eAnFk29JfbMWPJoY5TrsiqZVUvcjCSjWDHDrQzRC4NSF/qAFac6N3N5xDqRqF6HaOQv+kX3PlxS0F7voXG6vtAUCoolxVSnoWb9ge3a2RmGD3C9QBse25moWG39SRS60sXysth5MP7rEyDTlpZFCc/M/ABFhnHPrwZDMJ/7pNDh3E8MNvDAMcgT6HFcivDRRmJuvxJsNrAiYFP0IWqvquKXUen6duIeU3yRuHBw1mTuETbYsLncI4r4h4RrTKrM9bqR5iKchBCqtL+ltH6XGTIxXF1YEB1JhIkZLEk0d4mYvd6BWzj0rlKWdWsPtqQLKJmz84oTP0Zh90KduISfruCBn8PILsGMVojwhj6+xT6W+WD/K2ArsjY2PMb4GWT/yYnV/8IuZdhrS7sjc690drGzUaOAkHqg0gEyPylXseQQ5src7AqfMmrRgbgdC5ok3KxtNZ7bRp8RhkWohMQenTeKwcaDq1JMSdUhM9iNKWWAepXALvlGFbkagxVbJmnmvGtiyT1sfS0MM3nU4e+5KPedfckyMVGIZIHLOGPp9CeU9XCg2q8ozuPS0EYvdhkOYB1hY9Cn+ZwMUHm6Q2xQoJTZKAEg71WT25wX3rpSKk5h+o3abNksJ6bZ8T/KbO9Nnd/Q2soe/sM3nzZGqgJm/F1ZKIAWmdD3Kx0ywjuaDYWIQgX486QKI/kMMI0FjVjnQGifO8GfVfbauF3G29j4en7U7u24R0HLSb6VBHriClsLfssrP6h+bINSRa2Z/jgAZr56siE0TXdCWVQSs8NH9/YQH8emzNTtxDtBeUZ6iCxG2RIBC/xkVl6ebYbGIJP6mjyCl0v4DSxPlEnpsnhNAhkar+XR2/50GLl3P63w02tEcm4vYPWS3hncfqobmINFTVRT8Pv1BGiecMm5SZGH72/lR1fFNO0rn80BnwhDuVuChtQENWpvcf5K1NChvcVGZFVBu9chVD6Awyv7YNgltEVdgT5Q+aiPzM0FMip5zU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 045841f1-5b2b-436c-3ba6-08dad88c9b44 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 19:52:43.9557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hkLo9Ctjo6/Xyu8Rs3CFyhmfOcyN7N6Wm/rX9wVklelErmXfOvpXCDG1T0+77Db1J1j/zvHzgTuHIJyzwkTDFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5125 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-07_09,2022-12-07_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=896 spamscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212070167 X-Proofpoint-GUID: C92rhKtbrC4YIuNhBmLXpA0vKJp_sJNc X-Proofpoint-ORIG-GUID: C92rhKtbrC4YIuNhBmLXpA0vKJp_sJNc X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751586450770954108?= X-GMAIL-MSGID: =?utf-8?q?1751586450770954108?= ChangeLog: * binutils/objdump.c (dump_section_sframe): free up contents and SFrame decoder context on exit. --- binutils/objdump.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/binutils/objdump.c b/binutils/objdump.c index d95c8b68bf0..6695c5d343f 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -4871,12 +4871,18 @@ dump_section_sframe (bfd *abfd ATTRIBUTE_UNUSED, /* Decode the contents of the section. */ sfd_ctx = sframe_decode ((const char*)sframe_data, sf_size, &err); if (!sfd_ctx) - bfd_fatal (bfd_get_filename (abfd)); + { + free (sframe_data); + bfd_fatal (bfd_get_filename (abfd)); + } printf (_("Contents of the SFrame section %s:"), sanitize_string (sect_name)); /* Dump the contents as text. */ dump_sframe (sfd_ctx, sf_vma); + + free (sframe_data); + sframe_decoder_free (&sfd_ctx); }