From patchwork Fri Nov 4 16:33:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Cl=C3=A9ment_Chigot?= X-Patchwork-Id: 15679 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp511346wru; Fri, 4 Nov 2022 09:34:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6NST5dCd+yEcxF22nMGSvVfF/wJGHafr+PyqWHlbpsjB16QTjfkGCGdfhOQvVNqV7f85Ux X-Received: by 2002:a17:907:86a8:b0:7ad:988e:a93 with SMTP id qa40-20020a17090786a800b007ad988e0a93mr37290604ejc.704.1667579661982; Fri, 04 Nov 2022 09:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667579661; cv=none; d=google.com; s=arc-20160816; b=bS9hKygbJjlSi0qoEbciJIOoos6mSSWjZfi0Mf5z8U+ujn+LtewdkX1qSZHflkWypQ ytkHezb6O0wiDh/nsWVxkx/JZ+5MykzLuQSGadTfUd5r+8WshZhYecUKmLuJzTCWLXUx MZjXnrqp6+bKkQQm2yipXzNSf2MWiWJNFZh8OEFML+4wMhRXhm/oi/WZEUUFIp5pFe7I e0rE995n5lvzgHLfVJZmqaFgYha1xcsxgBtZLlbyEpffeBRDC+LJkokBTv27SS5PMBie Hz8i+0+lK7ALC71WaozQv5r8ggIllexiH/Is6NK2IfS3tNW1zAYb2CV9cYYCVTB6FhrA jiSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=BR9rxcz4Pjzi7Jeo5vhUl/WZeceO49176wEiKkz7G0o=; b=jC+DnDEtGqBY+B9S8uqJtin5EePAIKZBJmQvWttorOZKiI6zTc+3dCOzl59TGNPwan D0F1jH18bV8FpHp6GQ6oNd84dKF3ovUde3+9AbDvNf9cD51a+uUImz0iZai0QARYUcoL 0u83MJ/f1XB/XqSzGksflF+eCghgaGukqwENUI4y7XPaZoutpwqYLVxukCAjM0am9I3K ZOsUB4wfS/fW2eqpb0zGvOT+yLCDG8kvz4ZVYxYphYx5lz8K6c9XEPaJBtRx3V1uN5r/ X9rD2t3vs6M4jZZC0mBH7L75QxWhR98yGJxwlz/J6rw8G5mW79M4ZYK2P73OXwUy5Wk0 D6Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=XfhA565V; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v3-20020a056402348300b00463c13a9ab7si6399615edc.32.2022.11.04.09.34.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 09:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=XfhA565V; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5F1F385841C for ; Fri, 4 Nov 2022 16:34:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5F1F385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667579658; bh=BR9rxcz4Pjzi7Jeo5vhUl/WZeceO49176wEiKkz7G0o=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=XfhA565VDhiYaoWxBT1C1jgYkXOSLEFDG4JCnlRuL5yPF0jHZtvaFyAFNPgvpnddj k3wHcB2bfHn7oneg1uRtU5eshBzdxYq/94u4ap2O9xNg1+CaT5ETnuqtRgrM7q95dk MRj3PyrKCGt5giDz8qKXg6Sh1s3RUKvD2wByli/o= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 73581385840D for ; Fri, 4 Nov 2022 16:33:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73581385840D Received: by mail-wm1-x336.google.com with SMTP id i5-20020a1c3b05000000b003cf47dcd316so5746346wma.4 for ; Fri, 04 Nov 2022 09:33:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BR9rxcz4Pjzi7Jeo5vhUl/WZeceO49176wEiKkz7G0o=; b=COV/DivxKvYIF1bGCdjURwBCd3AOB2WkV4KklBGj6KoIEumpQXPys99W0NCkr0eOsR 9j1KtVnHJuCKhpLl1CO5FenrzLNvyHdNFJePJ1vNdifOIDTwnina7cDyUC7Rlfj3JFCd VYcH2LVh7zr2OeeMwI0LUTyDG7p0bLzGzbL5zpcYmqRGfCcWLXMwjs3XpxdamgshyLZV AhT6XBJ3AR0BWH4AD8ODzMe6BcxWHdj4QMOWZNyRgOfj532C428UYTsneKQg2CK6sb1b 2juZ0ugwGW26TGJHAaHdy0qJNXjNQPUwbUX0/9fHne/phJPRKEXhCc8Wm4L/RCIOEbjd PnSg== X-Gm-Message-State: ACrzQf1uHlpEJSOqVR7YsblnI2Y/E71IZEsba7nZMjdPd+qh6XE/egtz qHfIbtXlLVWxdFhqwSTXUus6nDGM8B9Mjw== X-Received: by 2002:a7b:c303:0:b0:3b4:6e89:e5d5 with SMTP id k3-20020a7bc303000000b003b46e89e5d5mr24783158wmj.111.1667579613081; Fri, 04 Nov 2022 09:33:33 -0700 (PDT) Received: from chigot-Dell.home ([2a01:cb15:8123:8100:ac2d:4a3a:f207:258b]) by smtp.gmail.com with ESMTPSA id x14-20020adfffce000000b002366eb01e07sm3647477wrs.114.2022.11.04.09.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Nov 2022 09:33:32 -0700 (PDT) To: binutils@sourceware.org Subject: [PATCH] ld/testsuite: skip tests related to -shared when disabled Date: Fri, 4 Nov 2022 17:33:28 +0100 Message-Id: <20221104163328.2274371-1-chigot@adacore.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Cl=C3=A9ment_Chigot_via_Binutils?= From: =?utf-8?q?Cl=C3=A9ment_Chigot?= Reply-To: =?utf-8?q?Cl=C3=A9ment_Chigot?= Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748584011512334763?= X-GMAIL-MSGID: =?utf-8?q?1748584011512334763?= I didn't remove the hardcoded switch below as I'm not sure if some platforms still want to skip these tests even if the shared support is there. --- Call the helper function "check_shared_lib_support" to ensure -shared is enabled before launching ld-shared, ld-elfweak and ld-elfvers. This allows to catch custom targets explicitly disabling it. ld/ChangeLog: * testsuite/ld-elfvers/vers.exp: Call check_shared_lib_support. * testsuite/ld-elfweak/elfweak.exp: Likewise. * testsuite/ld-shared/shared.exp: Likewise. --- ld/testsuite/ld-elfvers/vers.exp | 5 +++++ ld/testsuite/ld-elfweak/elfweak.exp | 5 +++++ ld/testsuite/ld-shared/shared.exp | 5 +++++ 3 files changed, 15 insertions(+) diff --git a/ld/testsuite/ld-elfvers/vers.exp b/ld/testsuite/ld-elfvers/vers.exp index 3e2ba2aac07..2e44d4a410f 100644 --- a/ld/testsuite/ld-elfvers/vers.exp +++ b/ld/testsuite/ld-elfvers/vers.exp @@ -27,6 +27,11 @@ if { ![check_compiler_available] } { return } +# Skip targets where -shared is not supported +if { ![check_shared_lib_support] } { + return +} + # This test can only be run on a couple of ELF platforms. # Square bracket expressions seem to confuse istarget. # This is similar to the test that is used in ld-shared, BTW. diff --git a/ld/testsuite/ld-elfweak/elfweak.exp b/ld/testsuite/ld-elfweak/elfweak.exp index 99188654df1..69826803a17 100644 --- a/ld/testsuite/ld-elfweak/elfweak.exp +++ b/ld/testsuite/ld-elfweak/elfweak.exp @@ -27,6 +27,11 @@ if { ![check_compiler_available] } { return } +# Skip targets where -shared is not supported +if { ![check_shared_lib_support] } { + return +} + # This test can only be run on a couple of ELF platforms. # Square bracket expressions seem to confuse istarget. # This is similar to the test that is used in ld-shared, BTW. diff --git a/ld/testsuite/ld-shared/shared.exp b/ld/testsuite/ld-shared/shared.exp index 229fddbd436..94e03fceff9 100644 --- a/ld/testsuite/ld-shared/shared.exp +++ b/ld/testsuite/ld-shared/shared.exp @@ -30,6 +30,11 @@ if { ![check_compiler_available] } { return } +# Skip targets where -shared is not supported +if { ![check_shared_lib_support] } { + return +} + # This test can only be run on a couple of ELF platforms. # Square bracket expressions seem to confuse istarget. if { ![istarget hppa*64*-*-hpux*] \