diff mbox series

ld/testsuite: skip tests related to -shared when disabled

Message ID 20221104163328.2274371-1-chigot@adacore.com
State Accepted
Headers
Series ld/testsuite: skip tests related to -shared when disabled |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Clément Chigot Nov. 4, 2022, 4:33 p.m. UTC 
  I didn't remove the hardcoded switch below as I'm not sure if some
platforms still want to skip these tests even if the shared support is
there. 

---

Call the helper function "check_shared_lib_support" to ensure -shared
is enabled before launching ld-shared, ld-elfweak and ld-elfvers.
This allows to catch custom targets explicitly disabling it.

ld/ChangeLog:

	* testsuite/ld-elfvers/vers.exp: Call check_shared_lib_support.
	* testsuite/ld-elfweak/elfweak.exp: Likewise.
	* testsuite/ld-shared/shared.exp: Likewise.
---
 ld/testsuite/ld-elfvers/vers.exp    | 5 +++++
 ld/testsuite/ld-elfweak/elfweak.exp | 5 +++++
 ld/testsuite/ld-shared/shared.exp   | 5 +++++
 3 files changed, 15 insertions(+)

Comments

Nick Clifton Nov. 7, 2022, 11:13 a.m. UTC | #1 
Hi Clément,

> Call the helper function "check_shared_lib_support" to ensure -shared
> is enabled before launching ld-shared, ld-elfweak and ld-elfvers.
> This allows to catch custom targets explicitly disabling it.
> 
> ld/ChangeLog:
> 
> 	* testsuite/ld-elfvers/vers.exp: Call check_shared_lib_support.
> 	* testsuite/ld-elfweak/elfweak.exp: Likewise.
> 	* testsuite/ld-shared/shared.exp: Likewise.

Approved, please apply.

Cheers
   Nick
diff mbox series

Patch

diff --git a/ld/testsuite/ld-elfvers/vers.exp b/ld/testsuite/ld-elfvers/vers.exp
index 3e2ba2aac07..2e44d4a410f 100644
--- a/ld/testsuite/ld-elfvers/vers.exp
+++ b/ld/testsuite/ld-elfvers/vers.exp
@@ -27,6 +27,11 @@  if { ![check_compiler_available] } {
     return
 }
 
+# Skip targets where -shared is not supported
+if { ![check_shared_lib_support] } {
+    return
+}
+
 # This test can only be run on a couple of ELF platforms.
 # Square bracket expressions seem to confuse istarget.
 # This is similar to the test that is used in ld-shared, BTW.
diff --git a/ld/testsuite/ld-elfweak/elfweak.exp b/ld/testsuite/ld-elfweak/elfweak.exp
index 99188654df1..69826803a17 100644
--- a/ld/testsuite/ld-elfweak/elfweak.exp
+++ b/ld/testsuite/ld-elfweak/elfweak.exp
@@ -27,6 +27,11 @@  if { ![check_compiler_available] } {
     return
 }
 
+# Skip targets where -shared is not supported
+if { ![check_shared_lib_support] } {
+    return
+}
+
 # This test can only be run on a couple of ELF platforms.
 # Square bracket expressions seem to confuse istarget.
 # This is similar to the test that is used in ld-shared, BTW.
diff --git a/ld/testsuite/ld-shared/shared.exp b/ld/testsuite/ld-shared/shared.exp
index 229fddbd436..94e03fceff9 100644
--- a/ld/testsuite/ld-shared/shared.exp
+++ b/ld/testsuite/ld-shared/shared.exp
@@ -30,6 +30,11 @@  if { ![check_compiler_available] } {
     return
 }
 
+# Skip targets where -shared is not supported
+if { ![check_shared_lib_support] } {
+    return
+}
+
 # This test can only be run on a couple of ELF platforms.
 # Square bracket expressions seem to confuse istarget.
 if { ![istarget hppa*64*-*-hpux*] \