diff mbox series

[PUSHED] opcodes/arm: silence compiler warning about uninitialized variable use

Message ID 20221104110132.694984-1-aburgess@redhat.com
State Repeat Merge
Headers
Series [PUSHED] opcodes/arm: silence compiler warning about uninitialized variable use |

Checks

Context Check Description
snail/binutils-gdb-check warning Git am fail log

Commit Message

Andrew Burgess Nov. 4, 2022, 11:01 a.m. UTC 
  *sigh*

Off-list, I was pointed at yet another uninitialized variable problem
caused by my disassembler styling patch.  This one is the same as the
first fix I pushed, just in another function.

Hopefully /this/ will be the last fix I end up pushing.

Thanks for your continued patience,

Andrew

---

After this commit:

  commit 6576bffe6cbbb53c5756b2fccd2593ba69b74cdf
  Date:   Thu Jul 7 13:43:45 2022 +0100

      opcodes/arm: add disassembler styling for arm

Some people were seeing their builds failing with complaints about a
possible uninitialized variable usage.  I previously fixed an instance
of this issue in this commit:

  commit 2df82cd4b459fbc32120e0ad1ce19e26349506fe
  Date:   Tue Nov 1 10:36:59 2022 +0000

      opcodes/arm: silence compiler warning about uninitialized variable use

which did fix the build problems that the sourceware buildbot was
hitting, however, an additional instance of the same problem was
brought to my attention, and that is fixed in this commit.

Where commit 2df82cd4b4 fixed the uninitialized variable problem in
print_mve_unpredictable, this commit fixes the same problem in
print_mve_undefined.

As with the previous commit, I don't believe we could really ever get
an uninitialized variable usage, based on the current usage of the
function, so I have just initialized the reason variable to "??".
---
 opcodes/arm-dis.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c
index 31ed81f5a4e..47a0a38adec 100644
--- a/opcodes/arm-dis.c
+++ b/opcodes/arm-dis.c
@@ -7148,7 +7148,9 @@  print_mve_undefined (struct disassemble_info *info,
 {
   void *stream = info->stream;
   fprintf_styled_ftype func = info->fprintf_styled_func;
-  const char *reason;
+  /* Initialize REASON to avoid compiler warning about uninitialized
+     usage, though such usage should be impossible.  */
+  const char *reason = "??";
 
   switch (undefined_code)
     {