From patchwork Thu Nov 3 07:15:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Machado X-Patchwork-Id: 14706 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp366296wru; Thu, 3 Nov 2022 00:15:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4oeBx0pvujNRafFnD7gzhRzLx37FSksVCDSetCvSzEUF3qXmDPl8mvNu/PUnXiwz0Evfx2 X-Received: by 2002:a17:907:7fab:b0:7aa:97e5:fac2 with SMTP id qk43-20020a1709077fab00b007aa97e5fac2mr27434125ejc.553.1667459753462; Thu, 03 Nov 2022 00:15:53 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id hc38-20020a17090716a600b0078849a014e9si450809ejc.196.2022.11.03.00.15.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Nov 2022 00:15:53 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=Nk2povdp; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 18B2B385842B for ; Thu, 3 Nov 2022 07:15:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 18B2B385842B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1667459751; bh=Z3bwhaIaz2MshOeGHwxVB9TPzpRG41bQd0XOorZwVVo=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Nk2povdpg7UlnP9u6Rpm234UsSBudG6whR6oxYPAB3r5mNeDJQmJCt/BlvJn0hP1l CC5J/7/PiD2+AvrJflBYNjxVP4c9+wlv53FKipgTraCDWTjaPgEiIuTAkYAxagNdKF Yo03AIllEx3L2t9BArpASouCY9pZ9Faiy9ve9fj0= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2079.outbound.protection.outlook.com [40.107.20.79]) by sourceware.org (Postfix) with ESMTPS id 27F853858404 for ; Thu, 3 Nov 2022 07:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 27F853858404 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CtVw+9y/KLxUWOwIyxZc9MmSxvq6Wot6Gnrl+F595MyRNuEfwRGsbAjTUKpCUknKjUJt2GrRnf++gYayY/JWL35DlrqKS3QqqJwEQTMCgPjgt4Ao3zBIdwWT1YW1G6MIsljcEd+Dy+NMZZ0gYf0NBkPqQGAwx7D13vu328VW5CWaRY7uS2Nvgm201Z7dOQ5k8/y5COMX3ldRymV60WGfiooOsndv/krI433I5HDgqeHaHu7XJ0X6ywATLkdt9Kx2bYDVPEMrBTridSdGMOP0AH7RDOIs8IcKXp8KTpgWlOEThgaRDQPoTnBH+JNqYsQMwJ2kHV0aPrfnPa/j6gGqlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z3bwhaIaz2MshOeGHwxVB9TPzpRG41bQd0XOorZwVVo=; b=M+LpdiZ7WUah/wqDULLRodFdJIJeinSTGwXsVq0Yi6hMYZgx6/yEpctn8Pv5Tcm/vtF7T3zQRtYmSeLNtCP7gOrtw1ECBtZM+Imjct8Cg4lhExqwZ4P1nSd+ABd8h9T0siOWh4BFWDMa4FSZEzymF7U75zlh7NY8I4+Yuh2ZELBaAXucouPH9JafBCX2oa+FbrM4r8tfnTIyLuy0Zh7qSuvWXVbk4z3gXIIRrIja6kpFaks6MCiRjSWGC555Qyv+RhT0rbvTR+0LOg6pVcXkjcuST4uyVPnDzhHm4Jl4QvqR8cKeH2r2ro06FuGZWF3WsHLt5+1jYT6QtkaHZznz9g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1, 1, smtp.mailfrom=arm.com] dmarc=[1, 1, header.from=arm.com]) Received: from DB8PR06CA0060.eurprd06.prod.outlook.com (2603:10a6:10:120::34) by DU0PR08MB7788.eurprd08.prod.outlook.com (2603:10a6:10:3b7::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14; Thu, 3 Nov 2022 07:15:38 +0000 Received: from DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::67) by DB8PR06CA0060.outlook.office365.com (2603:10a6:10:120::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.24 via Frontend Transport; Thu, 3 Nov 2022 07:15:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT057.mail.protection.outlook.com (100.127.142.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 07:15:38 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Thu, 03 Nov 2022 07:15:38 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 29ddbada10a3e814 X-CR-MTA-TID: 64aa7808 Received: from 097a7a10ac9d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 005C9A81-AFCC-45F6-A1C5-57DAE72470F2.1; Thu, 03 Nov 2022 07:15:31 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 097a7a10ac9d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 03 Nov 2022 07:15:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XxNHd6pNC/51ecWUTV3pTMqav91EaIQHMu6Hz1fAxqd6yboMg9C+CUVKQxpwWTxazM+5xWevbOD19UYQ7JWkPLlJ36443HHJABxdnScGcAYfjUtoSt+kCsu5T8c27QIQ/9Y+pw32Cji/YM0sFbvAJAFoAmV+2jGGMGebcP0hXevldgew0mE3DaaEf150LXZHiNtzCWz+gIXMG182+cKdpfzYTKLNEqXUxHNO9wTtTaYygsq9agnkuIugDmMAIlhyiqhBDIp2vWFyVWqz8D86IYdIDo6DIJ5gBEpxKlfNdC3rDl0qmIyWYOpUAxq9IQNzC55H+pBTVWs1rlljITWpRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z3bwhaIaz2MshOeGHwxVB9TPzpRG41bQd0XOorZwVVo=; b=gxC5oP195lO7WC5+XBrE+Sv+IJAd5dgp3YFueENzJsKzmBlvTfQ51LKag9Aoy3eBZQoWCYJpNQyouecMG9LRuK6UJfjYjhErZuojBwQeY9VA8L4XA8GU748IlqcWnkxpW60w8Jrs/kOpxj4byK9lULJHXepiOUKlQ3eAYuEffCn4UQoYEnERrhg6QQoEpeZtR5zDXWr1uiDuKhxlh/DVp/XtL0VH0SZ/4svmnAWf7bo5USNZCKGjLGnl9Obo21uGC1scJqzxeo33aj2z/twFk8wY481leaC7r3xLvlaCxrFa6ZsmYEroU+FZa/aDM3wJ/Q8YN0Erx6cvwPWoI/YlsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none Received: from DB9PR02CA0021.eurprd02.prod.outlook.com (2603:10a6:10:1d9::26) by AS4PR08MB7903.eurprd08.prod.outlook.com (2603:10a6:20b:51e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Thu, 3 Nov 2022 07:15:29 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::3b) by DB9PR02CA0021.outlook.office365.com (2603:10a6:10:1d9::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Thu, 3 Nov 2022 07:15:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 07:15:29 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 3 Nov 2022 07:15:29 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Thu, 3 Nov 2022 07:15:28 +0000 Received: from e129171.arm.com (10.57.68.244) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Thu, 3 Nov 2022 07:15:28 +0000 To: Subject: [PATCH] [opcodes/arm] Fix potential null pointer dereferences Date: Thu, 3 Nov 2022 07:15:19 +0000 Message-ID: <20221103071519.3510462-1-luis.machado@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DBAEUR03FT011:EE_|AS4PR08MB7903:EE_|DBAEUR03FT057:EE_|DU0PR08MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: 18ba68a6-fe33-46e5-c98a-08dabd6b3560 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UWBnwFITwrObamx36Ax9v9WVnG2l6iM2WdCPvRzEY/8b+svuwQNUIk7hVu5ntlfi6PBDdKOd5BzBNW8ymKEnZBuaF0qm29Ycv41goLw/KiJI3Fs+Ei0dvQdXboAdQVyzvBjI61hZjcp5t5gj7HwkpHmRDd4JPXvxZjBsX6ZkA6+bvtAeumfcyMsyahQ/Uo78ELXuvPvTZjw5lBymh2f14M419JAI+Iu7Q5H8Op4BdDR9F4ttBtEORCL4a+mGunDYQC55m4b4wLXX5j1JdJAcYniDBm18OZ1uo6hg6v9fnn5Obl5z7Jc0jeL14L0jR9MWziFR9K3PwU1k2TTARc46dmdIN6GTSZ3aLBspFsU1U2/NB9HQ+TUkBgcFvC2P5jh9PPGyzq/oxsRtxdUO9iK7o13GWTwURAQSAo4o9VofetjO+laq4DM8h1ZNW3y80p92FDg+jOZkgeoqmBNBxnc/cPxeEgjGXHjf8aSglYX/PEB0bCETdCmgPql9iKN4SepmpXqF3fSX2RCRE7RE4gvjG48orZ9KkMYYoRoAUrRpsODwVh2l/0DBcdPrQRG0HGZ55J0Rdlez22gIcbvLEcr6gpqv204nL50Jb96a/nQYOVn4yMnPH06dfl1uKOjW5+k1N8CXPT7ZsrhONpCjGL8VtRGmpMYpT1AyUCAswZiDYNWOI4J/XzGfH4EbCWjbhKCx4B3Y7YACmcsKE3XkbpOOvlrZvA1pwumPagKcCbFDdkLjBt7UsqmLsCRyQEd4lovVx5kv2mSGaS2bu4oDjlvNJRzX1obfB15U0kOGsMpFfgONAmS9O13vBOtHVYskRHUD X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(451199015)(40470700004)(46966006)(36840700001)(81166007)(356005)(40460700003)(36756003)(82740400003)(40480700001)(44832011)(2906002)(6666004)(7696005)(478600001)(8936002)(6916009)(2616005)(86362001)(8676002)(5660300002)(70586007)(70206006)(41300700001)(186003)(82310400005)(1076003)(336012)(316002)(36860700001)(26005)(47076005)(426003)(83380400001)(36900700001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7903 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fdb3f2bb-fd71-4145-4aee-08dabd6b3031 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Rpn6g5mJ1j3l9bHDmsEe0zqadogJ1iDZH5cpfOwuupA5iAzCT5d3RtW0pYBFRccFAGVk8OlaGJbLsS53qhAiBEqo7gJS96bRNw+fqwpfDydSP5GFI3077Rsq0reZX8BJcHUPDX7ZjYioqIka8RzNechRjS5qUwA5KMtlOZyRhskvpvbxo6LZQLrD2DqY4O6Vz1paAgccudJ0OM6yzoREnsz6I0mXo4lnq3aPtMoA5wKSnycuegp2H8nd0hWIHtbe9NADZQUobzq/Kw19DiI5NabSow992MkX5H5yhLiv3IuYFb2vX/7DQ0Atfi4e+CPX6jUpm4V2zKjDI1X8UZsqcVaHqqpq96Zn2KjhD+LLjXjdOaOJtwuG4lo6kN3J3Q2nbKXWpRGdNiZg0S95Q+JCparbttIO+io2NulRZhpNM11fCbXji377/ASzn+boR0fvm15GS9nh6RJEA+8h2g10HoKeT62iUoyqOkaRqxEDB8i+P3lO+zEvQ7Yc6uJHv/Fs9ay86LymR1a+czN3P3j5EV3Vrhs0hvfre7vgKKrS4X9azlzVz3FxnoOrSoTrtJ/3u61/oqVt1v4MH4DrWfoCroQ/eu7woUiWnWpkWiQAxFIlkDeZhy9uyIQZfnL0/G/DnU9QFJmbPp/Tl/3Sa5YEOtKIQjFDPbr1geiNXwBKIDbTdZCxR5x8QfVUpjPmoKeY31Ag8Q6BAJ265LXJIGwqe3ruQzNc9KpuAcLO/DZSZJ5dAPsQbcRlod7GNoEL6sM4nKH1VAc+rfEJw+jtuPg02w== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199015)(36840700001)(46966006)(40470700004)(82310400005)(44832011)(2906002)(36756003)(40460700003)(47076005)(81166007)(1076003)(36860700001)(5660300002)(41300700001)(70586007)(8936002)(8676002)(316002)(40480700001)(2616005)(336012)(186003)(26005)(426003)(83380400001)(70206006)(6916009)(7696005)(82740400003)(478600001)(6666004)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 07:15:38.0876 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18ba68a6-fe33-46e5-c98a-08dabd6b3560 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7788 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Luis Machado via Binutils From: Luis Machado Reply-To: Luis Machado Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748458278324008998?= X-GMAIL-MSGID: =?utf-8?q?1748458278324008998?= PR 29598: dereferenced null pointer in arm-dis.c As pointed out in the bug ticket, we have a couple potential null pointer dereferencing situations for mapping_symbol_for_insn. Harden those. --- opcodes/arm-dis.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/opcodes/arm-dis.c b/opcodes/arm-dis.c index 31ed81f5a4e..01b43582513 100644 --- a/opcodes/arm-dis.c +++ b/opcodes/arm-dis.c @@ -12482,6 +12482,10 @@ mapping_symbol_for_insn (bfd_vma pc, struct disassemble_info *info, bool found = false; bool can_use_search_opt_p = false; + /* Sanity check. */ + if (info == NULL) + return false; + /* Default to DATA. A text section is required by the ABI to contain an INSN mapping symbol at the start. A data section has no such requirement, hence if no mapping symbol is found the section must @@ -12495,7 +12499,7 @@ mapping_symbol_for_insn (bfd_vma pc, struct disassemble_info *info, type = MAP_ARM; struct arm_private_data *private_data; - if (info->private_data == NULL + if (info->private_data == NULL || info->symtab == NULL || info->symtab_size == 0 || bfd_asymbol_flavour (*info->symtab) != bfd_target_elf_flavour) return false;