From patchwork Thu Oct 27 08:48:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Nelson Chu X-Patchwork-Id: 11658 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp110114wru; Thu, 27 Oct 2022 01:48:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4NMpiYCz3EFOQiFZu8r8t3q7afixOW0w2DQ4sF6rR9wjZYXqqGbRONmpz0rekBnCCfKT1F X-Received: by 2002:a17:907:1b1f:b0:72f:56db:cce9 with SMTP id mp31-20020a1709071b1f00b0072f56dbcce9mr40308626ejc.605.1666860514131; Thu, 27 Oct 2022 01:48:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666860514; cv=none; d=google.com; s=arc-20160816; b=0pAHt5P8+bxBN+RQzVLK519mg1nIeojtSc6HLfDMBWv9VMeaePWsf4hnSE4J9kCvk5 S9kjs5wVAkh/UZpMykyawmWXMQUUAwnzRRPHWVQi41O8zItMg87ONY4NVFp7qVcovvFR zYKFd1XuZyVJDKA2qMUHrNXTwA2Cik+VwKH0lPCEU1BCdVOKVGQvbFtSlMDpb1uwRHrb ZkfwAfiesmG9yg7mnEOScMVeovRH5qBhayJOAZJtSwKa1ianV4USZTuUM3r7Pz7LNtI1 lXVnLTfzPM1OBHOQrZHDBwLvBUS4n/pI4rt4oxPhK72ITVhxGi4cyvwEIugYCEU2boxr WftA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dmarc-filter :delivered-to; bh=2jKDlD1BMnfMvPnvTJZROl8+J23wj0h5Iez8IkbewYk=; b=Qf2+hNVFYuzMtagp4aJcE42wo47azAuAeX9UwiJOI2s30YJm5FBjVROFrPUkw3hjRj tWEHqCIvNlTvuuJ3z1sg+X8XUyFffVlC52NzA/Ok8dSlndtnbs715Gof5do06kS4gBc/ r+be24o8hfz89fhVPWMGxJOUeuehYZqNQrEAOUSpl5s6hnC3RchsDSQllNiOXd5eUedY pVsmfbp4YmKSz9KZ/TjvicaRx8GrP5H7KXCMJAWw9KJ5YOY3IEcNCnP2tqaj0UuF8D6M ql60JBX5BshhMwqLJm7XHOKFMzEQdJWk6ZoZAXMaaGQtTTbSeEUrfSnxxGsH8gaDscRD ARcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id z20-20020a05640240d400b00461a9ddbda7si1184715edb.90.2022.10.27.01.48.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 01:48:34 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EDDEB3887F49 for ; Thu, 27 Oct 2022 08:48:32 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from NelsondeMBP.localdomain (114-25-54-207.dynamic-ip.hinet.net [114.25.54.207]) by sourceware.org (Postfix) with ESMTP id 274BE385D0FD for ; Thu, 27 Oct 2022 08:48:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 274BE385D0FD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=NelsondeMBP.localdomain Received: by NelsondeMBP.localdomain (Postfix, from userid 501) id 6197837488F; Thu, 27 Oct 2022 16:48:22 +0800 (CST) From: Nelson Chu To: binutils@sourceware.org Subject: [committed] RISC-V: Fix build failures for -Werror=sign-compare. Date: Thu, 27 Oct 2022 16:48:08 +0800 Message-Id: <20221027084808.37252-1-nelson@rivosinc.com> X-Mailer: git-send-email 2.37.0 (Apple Git-136) MIME-Version: 1.0 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, NO_DNS_FOR_FROM, PDS_RDNS_DYNAMIC_FP, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_PBL, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747829930535427812?= X-GMAIL-MSGID: =?utf-8?q?1747829930535427812?= elfnn-riscv.c: In function ‘riscv_relax_resolve_delete_relocs’: elfnn-riscv.c:4256:30: error: operand of ‘?:’ changes signedness from ‘int’ to ‘unsigned int’ due to unsignedness of other operand [-Werror=sign-compare] So make the operands unsigned could resolve problem. bfd/ * elfnn-riscv.c (riscv_relax_resolve_delete_relocs): Fixed build failures for -Werror=sign-compare. --- bfd/elfnn-riscv.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/bfd/elfnn-riscv.c b/bfd/elfnn-riscv.c index cf852636c9c..0570a971b5a 100644 --- a/bfd/elfnn-riscv.c +++ b/bfd/elfnn-riscv.c @@ -4239,7 +4239,10 @@ riscv_relax_resolve_delete_relocs (bfd *abfd, rel_next = relocs + i; if (ELFNN_R_TYPE ((rel_next)->r_info) == R_RISCV_DELETE && (rel_next)->r_offset > rel->r_offset) - break; + { + BFD_ASSERT (rel_next - rel > 0); + break; + } else rel_next = NULL; } @@ -4253,7 +4256,8 @@ riscv_relax_resolve_delete_relocs (bfd *abfd, rel->r_info = ELFNN_R_INFO (0, R_RISCV_NONE); /* Skip ahead to the next delete reloc. */ - i = rel_next != NULL ? rel_next - relocs - 1 : sec->reloc_count; + i = rel_next != NULL ? (unsigned int) (rel_next - relocs - 1) + : sec->reloc_count; } return true;