diff mbox series

[1/1] IBM zSystems: Issue error for *DBL relocs on misaligned symbols

Message ID 20221018081205.17880-1-krebbel@linux.ibm.com
State Accepted
Headers
Series [1/1] IBM zSystems: Issue error for *DBL relocs on misaligned symbols |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Andreas Krebbel Oct. 18, 2022, 8:12 a.m. UTC 
  Relocs like PC32DBL require a right shift of the symbol value.  There
is no situation where dropping symbol value bits with the right shift
is a good thing.  Hence we now issue an error to detect such problems.
---
 bfd/elf64-s390.c                    | 18 ++++++++++++++++++
 ld/testsuite/ld-s390/reloccheck-1.d |  5 +++++
 ld/testsuite/ld-s390/reloccheck-1.s | 14 ++++++++++++++
 3 files changed, 37 insertions(+)
 create mode 100644 ld/testsuite/ld-s390/reloccheck-1.d
 create mode 100644 ld/testsuite/ld-s390/reloccheck-1.s
diff mbox series

Patch

diff --git a/bfd/elf64-s390.c b/bfd/elf64-s390.c
index c1ed3d619d6..fa4497181fe 100644
--- a/bfd/elf64-s390.c
+++ b/bfd/elf64-s390.c
@@ -3056,6 +3056,24 @@  elf_s390_relocate_section (bfd *output_bfd,
 	  || r_type == R_390_PLT24DBL)
 	rel->r_offset--;
 
+      /* Issue an error if the right shift implied by the relocation
+	 would drop bits from the symbol value.  */
+      if (howto->rightshift
+	  && (relocation & (((bfd_vma)1 << howto->rightshift) - 1)))
+	{
+	  _bfd_error_handler
+	    /* xgettext:c-format */
+	    (_("%pB(%pA+%#" PRIx64 "): "
+	       "misaligned symbol `%s' (%#" PRIx64 ") for relocation %s"),
+	     input_bfd,
+	     input_section,
+	     (uint64_t) rel->r_offset,
+	     h->root.root.string,
+	     (uint64_t)relocation,
+	     howto->name);
+	  return false;
+	}
+
       if (r_type == R_390_20
 	  || r_type == R_390_GOT20
 	  || r_type == R_390_GOTPLT20
diff --git a/ld/testsuite/ld-s390/reloccheck-1.d b/ld/testsuite/ld-s390/reloccheck-1.d
new file mode 100644
index 00000000000..00c568cffa1
--- /dev/null
+++ b/ld/testsuite/ld-s390/reloccheck-1.d
@@ -0,0 +1,5 @@ 
+#as: -m64 -mzarch -march=z900
+#ld: -m elf64_s390 -e start -static
+#error: .*misaligned symbol.*
+
+There are no relocations in this file.
diff --git a/ld/testsuite/ld-s390/reloccheck-1.s b/ld/testsuite/ld-s390/reloccheck-1.s
new file mode 100644
index 00000000000..6c932bdfb0c
--- /dev/null
+++ b/ld/testsuite/ld-s390/reloccheck-1.s
@@ -0,0 +1,14 @@ 
+        .machinemode zarch
+        .machine "z900"
+.text
+        .align  8
+.globl start
+        .type   start, @function
+start:
+	larl	%r1, test
+.globl	test
+.data
+	.align	4
+	.byte	23
+test:
+	.zero	4