diff mbox series

x86: correct CPU_AMX_{BF16,INT8}_FLAGS

Message ID 19c08747-fa5b-1e67-3dd2-c891a2c0c1fa@suse.com
State Accepted
Headers
Series x86: correct CPU_AMX_{BF16,INT8}_FLAGS |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Jan Beulich Oct. 17, 2022, 7:44 a.m. UTC 
  AMX-TILE is a prereq to these, as already correctly expressed by
CPU_ANY_AMX_TILE_FLAGS. Express the dependency also in the reverse
("positive") direction.
---
Ideally we would teach i386-gen to at least check (better derive) such
two-way dependencies.

Comments

H.J. Lu Oct. 17, 2022, 10:24 p.m. UTC | #1 
On Mon, Oct 17, 2022 at 12:44 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> AMX-TILE is a prereq to these, as already correctly expressed by
> CPU_ANY_AMX_TILE_FLAGS. Express the dependency also in the reverse
> ("positive") direction.
> ---
> Ideally we would teach i386-gen to at least check (better derive) such
> two-way dependencies.
>
> --- a/opcodes/i386-gen.c
> +++ b/opcodes/i386-gen.c
> @@ -303,9 +303,9 @@ static initializer cpu_flag_init[] =
>    { "CPU_CLDEMOTE_FLAGS",
>      "CpuCLDEMOTE" },
>    { "CPU_AMX_INT8_FLAGS",
> -    "CpuAMX_INT8" },
> +    "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" },
>    { "CPU_AMX_BF16_FLAGS",
> -    "CpuAMX_BF16" },
> +    "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" },
>    { "CPU_AMX_TILE_FLAGS",
>      "CpuAMX_TILE" },
>    { "CPU_MOVDIRI_FLAGS",

OK.

Thanks.
diff mbox series

Patch

--- a/opcodes/i386-gen.c
+++ b/opcodes/i386-gen.c
@@ -303,9 +303,9 @@  static initializer cpu_flag_init[] =
   { "CPU_CLDEMOTE_FLAGS",
     "CpuCLDEMOTE" },
   { "CPU_AMX_INT8_FLAGS",
-    "CpuAMX_INT8" },
+    "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" },
   { "CPU_AMX_BF16_FLAGS",
-    "CpuAMX_BF16" },
+    "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" },
   { "CPU_AMX_TILE_FLAGS",
     "CpuAMX_TILE" },
   { "CPU_MOVDIRI_FLAGS",