Message ID | 07c1da37-c5a1-4ce6-ab8b-07079af73715@suse.com |
---|---|
State | Accepted |
Headers |
Return-Path: <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9222921dys; Fri, 15 Dec 2023 04:10:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGVpw6XSr/bmmWAAO5ZA1Yc5EebZl2u9eM7lkoAyV+WJIrW99v3HdpYt7tINHH/pYHOt0WQ X-Received: by 2002:a05:620a:6002:b0:77f:ad4f:d3ae with SMTP id dw2-20020a05620a600200b0077fad4fd3aemr1662533qkb.93.1702642252041; Fri, 15 Dec 2023 04:10:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702642252; cv=pass; d=google.com; s=arc-20160816; b=wliaQaTu/BaErdglQwBnd3/oEe0jte/YFLWOIav5HJMoB2muiA7HpEcolb0Ds2R6X1 EqPspUOX/SX889V0Q2YO6EHf6bGsuQv6ubjS2lQmHG12ZuJXmC6Mf1DJEOLgYDjpPB5O hVPAEmFZR2hfSV1ZBFyANFCS0VZBkpKZvXWwfzjdhAtGopXFA/nVXyQYenRCjC6VaFh2 JDgkpw5XH4wp9vYBJYw25WWEzO045f+wQ5QUy+9Qkw/CBaK8nhfoD6zRU4UTMLHshmJm e6DXcgZ8BJptgoKxDVGHbqbhUDz3wGLbAS2nC31t4mcE6CaV66Oy5Q1KClZXCNI/Ch/W 2SHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:references:cc:to:from:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=7KAUisUQXzVMOWczhLK+enueCCsmVZ8/txsRrDY8qyE=; fh=fl2hWRsm7syaPDF0inlJCxwhtB5XpFVkYEfkZZT/1AI=; b=Tv3Fu5JNqV2PJKK/FOALgct5PStyIWDfHb7fB7DurWx6GEjsbLo8wm4I+CLDbmR+Cu ZbyaGIH/8WtJZoT6ecz4F0UIJGN181Qh+nm6UuhUb3YUIAM8G214LnvLZUe1YzH02DFi TxsBzzaff3KjH0NGwZojWd19d8xW+nVANOAoU3GJG0wfxPfCcdf2cMhGXkjk+9v85e/Q L8ZOddFYKEtLNASPxPx8fpL4a93fhk/ZZXgh2U99IPN1mTA8tPACAP2tk0rnPapuFSyj u6wC5s94yOmvLsGvmJJLnTzBS3TlokLLVAsQmXs8gTPG/1EBQnIZjzOaivvyAEC6Rvex W6+g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=NhWd6b20; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id oq2-20020a05620a610200b0077dcec33533si16044885qkn.201.2023.12.15.04.10.51 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 04:10:52 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=NhWd6b20; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4ECC43870924 for <ouuuleilei@gmail.com>; Fri, 15 Dec 2023 12:10:50 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id 738233844053 for <binutils@sourceware.org>; Fri, 15 Dec 2023 12:10:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 738233844053 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 738233844053 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::236 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642243; cv=none; b=eU4jQrskavF4h1govGvoAthrCY1CmrMns5n5mSug+LuFbV94L0k2HF++x2W74ePgUOzc6fykoNjYLEHONdSsfli1XO06zifu1oBp3jsR0X08Z2AgWrWHym6WWgGwqpoG9LkxCAi1b6djNSoVdqZdx1VYhgvcItEkfjScUy1gcL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642243; c=relaxed/simple; bh=cbpviJFD2qldR3iSJFpC/LV7LLsYX4VJ6EdGrceq5Ag=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=NU5CYd1lEb6WfpdxoTK+DuYX0TxgSpNdb8SM5+niCuYgtxUlTagkhwdWXlKNsqz7vtF57YxVK6XAWpQfWd/lJIXpTdJWltnip4tsP3N7hpAZYwX3Xp/vkjvJnj5o8nBz8rOuYSLzHCUoD7Gz1Vt7+yBN3bd423tP7pCHWT0Jxds= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2cc4e15605aso5275711fa.0 for <binutils@sourceware.org>; Fri, 15 Dec 2023 04:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702642241; x=1703247041; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=7KAUisUQXzVMOWczhLK+enueCCsmVZ8/txsRrDY8qyE=; b=NhWd6b20oLN/JQZ1Sx7YRKVpn9sr+DsjhpCdo2dVsSiMujnq2P3stWy4ytYC9Ntseh kOND1F4k+WALIMe5XmHq91dc4nwhUQyd8dhkTd+uLLUyWBRXw9nnfP1kiUO9bqty3Zwa mw/gt5TR2gCM1bWwdd7IBkd3ko2iRt2elUQ4AAniO0ZmldWlw10TgvRK1jbRibBySMaL HPq69lJuTnvnjRkS5OQpI7vhqgWMfEhJc3xVvXy7ePTbxJGmQPy3Y0ZZ3vnlyB5McLY8 KUiz4c39hw0oqUqO2YImziIiE0+1UFZtj5NLeSoNY0ua+9ajTAw9QnyvzL4lPtD8Bb5c 2y6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702642241; x=1703247041; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7KAUisUQXzVMOWczhLK+enueCCsmVZ8/txsRrDY8qyE=; b=X6EPbJq9aDoq4eecraOjzPHogkqQZKloM2bLmS27AQ4YZ72gCGURg34T16M5uedn7j gxG3X8CdSU0NP2/MrQ3ogweEFJKjN0ryyV75/suJqQ0ypB2U+ez4HtcvG3uuZSOrMmbK 7v/4STbpr1cbG1okStZQM+1vW6iZh5gl9f2rgahBT1E2vhiI1bl1YulUAcVhT/U6cM7W jIIe3qv39heXMkNbGALsp0vK/Wdt+qa5D8l9+9v9QtGj3cZB62XTdjqiFXBPf/vRXlzP 0ns8lpF5tABWWRPXFVIY9SVUV8yPghvmaeF/dDz5eEPko1KP6NBBFOqeNuvNbicZ+LEV L/EA== X-Gm-Message-State: AOJu0YzfPXk7bZgoHnXfOL7g8+u2jBxUFHjhyXKmEOdzOKJraQdiL3T4 r8RkfY2GBp2aLocRisy9pBJzJhaQaDtyH81v2bQP X-Received: by 2002:a05:651c:201e:b0:2cc:4203:2196 with SMTP id s30-20020a05651c201e00b002cc42032196mr1356839ljo.93.1702642241134; Fri, 15 Dec 2023 04:10:41 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id k9-20020a056e02156900b0035da74cd896sm4764564ilu.77.2023.12.15.04.10.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 04:10:40 -0800 (PST) Message-ID: <07c1da37-c5a1-4ce6-ab8b-07079af73715@suse.com> Date: Fri, 15 Dec 2023 13:10:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 07/22] m68k: drop .bss override Content-Language: en-US From: Jan Beulich <jbeulich@suse.com> To: Binutils <binutils@sourceware.org> Cc: Nick Clifton <nickc@redhat.com>, Alan Modra <amodra@gmail.com> References: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785349802012466703 X-GMAIL-MSGID: 1785349802012466703 |
Series |
ELF: correct handling of simplified section directives
|
|
Checks
Context | Check | Description |
---|---|---|
snail/binutils-gdb-check | success | Github commit url |
Commit Message
Jan Beulich
Dec. 15, 2023, 12:10 p.m. UTC
The comment looks bogus (perhaps simply stale), and there are also no other precautions against subsections being used on ELF with .bss. It also doesn't look to be a good idea to override the custom handler that ELF has (afaict doing so further broke .previous).
--- a/gas/config/tc-m68k.c +++ b/gas/config/tc-m68k.c @@ -455,7 +455,6 @@ static int reverse_16_bits (int in); static int reverse_8_bits (int in); static void install_gen_operand (int mode, int val); static void install_operand (int mode, int val); -static void s_bss (int); static void s_data1 (int); static void s_data2 (int); static void s_even (int); @@ -862,7 +861,6 @@ const pseudo_typeS md_pseudo_table[] = { {"data1", s_data1, 0}, {"data2", s_data2, 0}, - {"bss", s_bss, 0}, {"even", s_even, 0}, {"skip", s_space, 0}, {"proc", s_proc, 0}, @@ -5493,16 +5491,6 @@ s_data2 (int ignore ATTRIBUTE_UNUSED) demand_empty_rest_of_line (); } -static void -s_bss (int ignore ATTRIBUTE_UNUSED) -{ - /* We don't support putting frags in the BSS segment, we fake it - by marking in_bss, then looking at s_skip for clues. */ - - subseg_set (bss_section, 0); - demand_empty_rest_of_line (); -} - static void s_even (int ignore ATTRIBUTE_UNUSED) {