binutils: Remove unused substitution PROGRAM

Message ID 07bfebbf3843b47e13d82d4fa16eb14fec942ef7.1666184962.git.research_trasio@irq.a4lg.com
State Accepted
Headers
Series binutils: Remove unused substitution PROGRAM |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Tsukasa OI Oct. 19, 2022, 1:09 p.m. UTC
  Unlike other substitution, this substitution of @PROGRAM@ was done in
binutils/Makefile and it was intended for binutils/cxxfilt.man.  @PROGRAM@
in binutils/cxxfilt.man is removed in the commit 0285c67df190 ("Automate
generate on man pages") in 2001 and @PROGRAM@ is ineffective since then.

Because PROGRAM substitution does nothing, removing this manual
substitution should be completely safe.

binutils/ChangeLog:

	* doc/local.mk: Remove unused substitution PROGRAM.
	* Makefile.in: Regenerate.
---
 binutils/Makefile.in  | 3 +--
 binutils/doc/local.mk | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)


base-commit: 2b06e59de0675c2cb526af2de6803dae29703d15
  

Comments

Alan Modra Oct. 19, 2022, 10:44 p.m. UTC | #1
On Wed, Oct 19, 2022 at 01:09:54PM +0000, Tsukasa OI via Binutils wrote:
> binutils/ChangeLog:
> 
> 	* doc/local.mk: Remove unused substitution PROGRAM.
> 	* Makefile.in: Regenerate.

OK, thanks.
  

Patch

diff --git a/binutils/Makefile.in b/binutils/Makefile.in
index 6de4e239408..9fb03f34b40 100644
--- a/binutils/Makefile.in
+++ b/binutils/Makefile.in
@@ -2136,8 +2136,7 @@  doc/$(DEMANGLER_NAME).1: doc/cxxfilt.man Makefile doc/$(am__dirstamp)
 	else \
 	  man=$(srcdir)/doc/cxxfilt.man; \
 	fi; \
-	sed -e 's/@PROGRAM@/$(DEMANGLER_NAME)/' \
-	    -e 's/cxxfilt/$(DEMANGLER_NAME)/' < $$man \
+	sed -e 's/cxxfilt/$(DEMANGLER_NAME)/' < $$man \
 		> doc/$(DEMANGLER_NAME).1
 
 html-local: doc/binutils/index.html
diff --git a/binutils/doc/local.mk b/binutils/doc/local.mk
index a3e0a78d6ae..4f632e82cd2 100644
--- a/binutils/doc/local.mk
+++ b/binutils/doc/local.mk
@@ -169,8 +169,7 @@  MAINTAINERCLEANFILES += $(man_MANS) %D%/binutils.info %D%/cxxfilt.man
 	else \
 	  man=$(srcdir)/%D%/cxxfilt.man; \
 	fi; \
-	sed -e 's/@PROGRAM@/$(DEMANGLER_NAME)/' \
-	    -e 's/cxxfilt/$(DEMANGLER_NAME)/' < $$man \
+	sed -e 's/cxxfilt/$(DEMANGLER_NAME)/' < $$man \
 		> %D%/$(DEMANGLER_NAME).1
 
 html-local: %D%/binutils/index.html