From patchwork Wed Nov 23 10:35:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 24882 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2708268wrr; Wed, 23 Nov 2022 02:35:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf4RFkWrF4HXlVKZOqEq/xkG7iNTi18HKO6mqSZxtrs6uLEQVQPLM2zXoJfRscsoThfttIcQ X-Received: by 2002:a17:906:6782:b0:7ad:7d50:dec2 with SMTP id q2-20020a170906678200b007ad7d50dec2mr24556087ejp.37.1669199731041; Wed, 23 Nov 2022 02:35:31 -0800 (PST) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f12-20020a0564021e8c00b00461a7bb34c2si3524089edf.473.2022.11.23.02.35.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 02:35:31 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=iQFLO0kK; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1DE463852C64 for ; Wed, 23 Nov 2022 10:35:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DE463852C64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669199729; bh=opWRivpLZoUkZ3zjOWsLHc1loB90Pij+dpRCsXsYatw=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=iQFLO0kKeXprs6aq/pUiGAQuOZ1G2/32aQwdDHZfgP4msD7gmkw3pKAlvWmZmyV3z gaZoBlumH6Yx6mo629Bt6dN2R8O/MCS1LWoABhbQWQwsi3+fef/JswbZ798vHC+VUT gnMdtjb/fi0Cy+6gkFWehRweToWWG5GJ5In0Flqs= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2073.outbound.protection.outlook.com [40.107.247.73]) by sourceware.org (Postfix) with ESMTPS id 5D84C3853D50 for ; Wed, 23 Nov 2022 10:35:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D84C3853D50 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Awn9F4tHcSBmMuQDYMIEzd2r5jA1Qmr3RUrpAZLwNSy3etkWBfyq/ON+ueuWnJB2ZLmMayOTMza6hv3sfRltxMWEBnvRT8m3xWpOk47k+O0+UHX2ZXPmdUDOe+UfWdmmlBvcIXOCVXFpMs34c1bJ8ELIZwKV8g+crdy/DUHh8ke9xHx7XF+ZZ3DTpcgutSISDy9r4rCw1zwTtIU7idsMnddz5pcALLqCaSse6TdMsK79uGRvVc5t5uzSTBPBIbZ0dGmA9h6il6ps/cfI3rC1uLSfsIVQ1C0nuJQgHRDc5V0GdXW+YBk0zVvSecqtz6UtwfRIcTFPNuvCNfVB7h4wUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=opWRivpLZoUkZ3zjOWsLHc1loB90Pij+dpRCsXsYatw=; b=Wu/KpVRJH6ZuBQvJP/Dn8pzgq/AzJSiwR1lOGfTA0buDxkoNPq5SIt6lDCXbFZtEG/4d9NKvl+CGWiIkUIYOdJcz2DBRDKTQgbKc19AfYmuXe5W5KCAP73P5OkndXnVaW4aYadlfE/6lb7BB1yomv36SercGkdcIdV/PigrcAHQKLYUo1N4YeIIFOGyxPFJKzwtOihHyE9J9/vPjrnvri1phW+f4G8IkinPzcIU4gvgVbeQy5pPtMQ0TG2JuYt37cUnMLKRpR5GRaps/lAiPFjk/ND0wbx6pMfR+04z7ZuTorMCh/MFhBR77K2Sgwv8vTFiG7DZM7Pk9Rd+tRSkyyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7414.eurprd04.prod.outlook.com (2603:10a6:10:1a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.9; Wed, 23 Nov 2022 10:35:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5834.015; Wed, 23 Nov 2022 10:35:17 +0000 Message-ID: <0168ba4a-766c-7cfe-7917-53259f846da0@suse.com> Date: Wed, 23 Nov 2022 11:35:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: [PATCH 3/3] x86: widen applicability and use of CheckRegSize Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: In-Reply-To: X-ClientProxiedBy: FR3P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7414:EE_ X-MS-Office365-Filtering-Correlation-Id: ddac9a79-804c-415c-aa59-08dacd3e69e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oD5ZK/SBa46jNP6zMz9RYfLNOWIsJQU6bg8xDrd4RsaO6EKr2e+YcZBeqINEBM8Wmw9MOfMDT3vfSs2rX3HZ1+f8/2R4+3j7Qt08YfhUncOgFky4r+8bsUUjZcg3ZftzSELOKCBqyglgKLxbTADuClLorBLcN+mIB7uyGAKO/orrs6zwOJ66RH0sBVVUu1OFiFeDnT1udlQGpj/JL2Kq4+d9DRnJ+HI+eZz3V8kdOjib6AUGXaOrfJGeSxKo2aBrV8qLGywGGtQ6McMqWVa33ijHq/vggIId8J6GlIzwyNpBxsDH+niwqn+NsPHSpDBn75HjRzXxDUKkNULih5JWSffb0zxDk/ebPHMYaHQGvIeCC+iwCyHCInasn1ZhQskBCvK9nhEnMwOSnVS6+fTWOYTMzrFUktaiz/VJTnu4xw7JWB3pkOYWln0BAgx9UeZy5h0YDO8VH7WDN4ITWXAG4MjXq5BZYVn/aRYhi1339XLzAcfQ5siRpKyOf9GnPO1CAKIgX5a7uy+F+0+oT3b2knFCR/FMn3XDE99rEWfoYeWKSg3HWy2+jVBwNq35g2tzerGsJj2Rhdx80ZNfdhtd96gYzYkk9JmknpiNeHS3BRkqLzZXV4MWJcn+fdO56QWsnHPeH86BjpXmW7aoUkg6SvtGoyD8tI5/n/WBmPlkI8FfuaHXKqbdEtlBeAbwOmuD+H+50R5XkZDGyhnEpdy11paviSxmJsrcf128bZ4cw40= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(366004)(136003)(346002)(396003)(376002)(451199015)(66899015)(2906002)(31686004)(2616005)(66946007)(41300700001)(36756003)(31696002)(86362001)(66556008)(83380400001)(6916009)(38100700002)(4326008)(6486002)(6506007)(8936002)(8676002)(5660300002)(66476007)(186003)(6512007)(26005)(316002)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XIBEea2QFpcoLPzTUdhw0/wPv5V6?= =?utf-8?q?seIWtT+JLwEsBQKQkKspnZLybZWVURTrq/NqVC8qum/0RP7v0XTKtAs8B038PTrkI?= =?utf-8?q?3Wx4O04Kut28Vxz/sXIJQvF44tjuF+WM/OlHuZ3arv366XAYGEw9BbYZYve05vGU7?= =?utf-8?q?mlHwzA3SrWpwWvRhCoKFMwOfLF/Z+BoeqhbQahQXKTj0bfalQGV4/5tR2nrGQGuhv?= =?utf-8?q?zVaw8ODQN+ysPxQ0sTB4ZLuA8NcfLHalT2jwbmiOj0CJ8+ad/zS4IEgoPpkPK7fcI?= =?utf-8?q?wcq6Uc0PfdQcQYkO3/CWV1cP/JnhZQt/bfoGPcxVZ33yAw7wuq/NAANLycvrDuyyB?= =?utf-8?q?6YgGP3xzNiEYsAilrxcolvRgmeCP3E09op681nf08uTJs7sIIQHGiEzwPX/AIdfiN?= =?utf-8?q?eweieS01uXNLh4tlb+OFcfN0GAMzycydyoSvRoKNB3d97Eo4FnlNqFT0XjFMCht1F?= =?utf-8?q?eHsroZJfFHbckeBa1l3PP56nGDONlsmEhFvKsiHBLrqHV3cZrYZhCsNq0AS820/zc?= =?utf-8?q?JoVAMsKL3jT2DrQUtcFoQYqpxN7f/kaOQelr81smwGNRFsWGz9NE1C2LX0LJRbdbk?= =?utf-8?q?tN2gS4HjcUONSuVd1hGqYemGG9ab/gbOeuVaTtEMfh4D0JB+PXksdOWJCYBSDhevb?= =?utf-8?q?DsyUEGHW76fOpwbyk8NPAyDmIU+uC/2m9HUhUcSoeXR4Rabn1ZKwG5hEpIJY9Hw9C?= =?utf-8?q?p+31VCNCW5o6kWaMTBC9YLmTumpwBeLqv+nw7gRv4HkzEu6RHuxqdgMmYx4r09Ndw?= =?utf-8?q?DEy3Mg8udgVngLthKhY136B9pCOee5dQ2qpZC8Go49Mr7yGoJcGi1PiY38ZtWzKJA?= =?utf-8?q?jwN3E1d+uDipYQSfenZwNM4UjSTlry/9Y8bGApEDyIQsFTy2bzjR8vyU1pbt98iqt?= =?utf-8?q?f0leATc4Sj7snIIRyX+82lpjSpRhI8W47/3zH29WPqjtRLzJQ1FHdyVZhlJlo69Pz?= =?utf-8?q?63Hnpwk88G7EtC/MJGusAGlVWD5M+BDK/53l/nFIM9+qVk6/hshqxFCcfLO/cIR0z?= =?utf-8?q?DMkxEhXMJHPIs7xCHnajuszecWlHowN8rXkstooCBoWpZHecyoQTHJOnVgOzV3Hq6?= =?utf-8?q?RAeehEcAcCfAAOtUSN29Io/FxZYEHZerTXVB+Svn0ktlfQv1tDg9QYuHWuwtPgm3Y?= =?utf-8?q?OpJCLCjPTNgssCZtRUrCZHIIgo7Qw4bk3jAMzIsYkCrqv+I6TsE/uBve8uQcoUOPs?= =?utf-8?q?WfDSkX0EeP8Veu7T3sS/VphzmdN2PiScBQ0uXyziQ7mZIQnZZdk2fR5UhcvSogsME?= =?utf-8?q?lT6slZPqPLQTcIibmweM47HV0Y2e1Fr1PNoS1sAcQxzXR6G/ZmWrjjnA3TDVT/eTr?= =?utf-8?q?GfOBogDeb3oZ8phiDfw6uGkHK8LLFGZQ8ey9KltuwMm2T4DZhph3bvynCL4O/bSUY?= =?utf-8?q?R5P3a9IQnDyKa0cuDiVesr89Zw9o2iQPj47y3U+HMmnnoGX18ZIJFKE+jBMvMfRBq?= =?utf-8?q?StnjVI68c705wMzF74WPY3JtJViX9EFnXQxdsMePGEA/dtRfHz/9GVvXM/RRPuqmP?= =?utf-8?q?8uBECXr4hzk+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddac9a79-804c-415c-aa59-08dacd3e69e5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 10:35:17.5921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: do9d0ztwWm+JigXkXlF+NaDYwXXmGHh3eqXCwzo86+aB7Z4jCCdA0AQqwp5vf7yotsK1JSrLnQnyIX1MKqvrgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7414 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750282777243184897?= X-GMAIL-MSGID: =?utf-8?q?1750282777243184897?= First of all make operand_type_register_match() apply to all sized operands, i.e. in Intel Syntax also to respective memory ones. This addresses gas wrongly accepting certain SIMD insns where register and memory operand sizes should match but don't. This apparently has affected all templates with one memory-only operand and one or more register ones, both permitting at least two sizes, due to CheckRegSize not taking effect. Then also add CheckRegSize to a couple of non-SIMD templates matching that same pattern of memory-only vs register operands. This replaces bogus (for Intel Syntax) diagnostics referring to a wrong suffix (when none was used at all) by "type mismatch" ones, just like already emitted for insns where the template allows a register operand alongside a memory one at any particular position. This also is a prereq to limiting (ideally eliminating in the long run) suffix "derivation" in Intel Syntax mode. While making the code adjustment also flip order of checks to do the cheaper one first in both cases. --- CheckRegSize now firmly isn't an appropriate name anymore - perhaps we want to rename it to e.g. CheckSizes or CheckOperandSize (and then better in a prereq patch)? --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -2192,7 +2192,7 @@ operand_type_match (i386_operand_type ov /* If given types g0 and g1 are registers they must be of the same type unless the expected operand type register overlap is null. - Some Intel syntax memory operand size checking also happens here. */ + Intel syntax sized memory operands are also checked here. */ static INLINE int operand_type_register_match (i386_operand_type g0, @@ -2202,18 +2202,14 @@ operand_type_register_match (i386_operan { if (g0.bitfield.class != Reg && g0.bitfield.class != RegSIMD - && (!operand_type_check (g0, anymem) - || g0.bitfield.unspecified - || (t0.bitfield.class != Reg - && t0.bitfield.class != RegSIMD))) + && (g0.bitfield.unspecified + || !operand_type_check (g0, anymem))) return 1; if (g1.bitfield.class != Reg && g1.bitfield.class != RegSIMD - && (!operand_type_check (g1, anymem) - || g1.bitfield.unspecified - || (t1.bitfield.class != Reg - && t1.bitfield.class != RegSIMD))) + && (g1.bitfield.unspecified + || !operand_type_check (g1, anymem))) return 1; if (g0.bitfield.byte == g1.bitfield.byte --- a/gas/testsuite/gas/i386/intelbad.l +++ b/gas/testsuite/gas/i386/intelbad.l @@ -169,3 +169,27 @@ .*:192: Error: .* .*:193: Error: .* .*:194: Error: .* +.*:196: Error: .* +.*:197: Error: .* +.*:199: Error: .* +.*:200: Error: .* +.*:202: Error: .* +.*:203: Error: .* +.*:205: Error: .* +.*:206: Error: .* +.*:208: Error: .* +.*:209: Error: .* +.*:211: Error: .* +.*:212: Error: .* +.*:214: Error: .* +.*:215: Error: .* +.*:217: Error: .* +.*:218: Error: .* +.*:220: Error: .* +.*:221: Error: .* +.*:223: Error: .* +.*:224: Error: .* +.*:226: Error: .* +.*:227: Error: .* +.*:229: Error: .* +.*:230: Error: .* --- a/gas/testsuite/gas/i386/intelbad.s +++ b/gas/testsuite/gas/i386/intelbad.s @@ -192,3 +192,39 @@ start: lsl ax, eax lsl eax, dword ptr [eax] lsl ax, dword ptr [eax] + + mov eax, word ptr [eax] + mov eax, qword ptr [eax] + + mov eax, word ptr [0x12345678] + mov eax, qword ptr [0x12345678] + + xchg eax, word ptr [eax] + xchg eax, qword ptr [eax] + + add eax, word ptr [eax] + add eax, qword ptr [eax] + + test eax, word ptr [eax] + test eax, qword ptr [eax] + + test word ptr [eax], eax + test qword ptr [eax], eax + + movnti word ptr [eax], eax + movnti qword ptr [eax], eax + + movbe eax, word ptr [eax] + movbe eax, qword ptr [eax] + + vmovntdq xmmword ptr [eax], ymm0 + vmovntdq zmmword ptr [eax], ymm0 + + vmovntdqa ymm0, xmmword ptr [eax] + vmovntdqa ymm0, zmmword ptr [eax] + + movdiri word ptr [eax], eax + movdiri qword ptr [eax], eax + + aadd word ptr [eax], eax + aadd qword ptr [eax], eax --- a/opcodes/i386-opc.tbl +++ b/opcodes/i386-opc.tbl @@ -142,9 +142,9 @@ ### MARKER ### // Move instructions. -mov, 0xa0, None, CpuNo64, D|W|No_sSuf|No_qSuf|No_ldSuf, { Disp16|Disp32|Unspecified|Byte|Word|Dword, Acc|Byte|Word|Dword } -mov, 0xa0, None, Cpu64, D|W|No_sSuf|No_ldSuf, { Disp64|Unspecified|Byte|Word|Dword|Qword, Acc|Byte|Word|Dword|Qword } -movabs, 0xa0, None, Cpu64, D|W|No_sSuf|No_ldSuf, { Disp64|Unspecified|Byte|Word|Dword|Qword, Acc|Byte|Word|Dword|Qword } +mov, 0xa0, None, CpuNo64, D|W|CheckRegSize|No_sSuf|No_qSuf|No_ldSuf, { Disp16|Disp32|Unspecified|Byte|Word|Dword, Acc|Byte|Word|Dword } +mov, 0xa0, None, Cpu64, D|W|CheckRegSize|No_sSuf|No_ldSuf, { Disp64|Unspecified|Byte|Word|Dword|Qword, Acc|Byte|Word|Dword|Qword } +movabs, 0xa0, None, Cpu64, D|W|CheckRegSize|No_sSuf|No_ldSuf, { Disp64|Unspecified|Byte|Word|Dword|Qword, Acc|Byte|Word|Dword|Qword } movq, 0xa1, None, Cpu64, D|Size64|NoSuf, { Disp64|Unspecified|Qword, Acc|Qword } mov, 0x88, None, 0, D|W|CheckRegSize|Modrm|No_sSuf|No_ldSuf|HLEPrefixRelease, { Reg8|Reg16|Reg32|Reg64, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } movq, 0x89, None, Cpu64, D|Modrm|Size64|NoSuf|HLEPrefixRelease, { Reg64, Reg64|Unspecified|Qword|BaseIndex } @@ -176,7 +176,7 @@ movq, 0xf21, None, Cpu64, D|RegMem|Size6 mov, 0xf24, None, Cpu386|CpuNo64, D|RegMem|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_qSuf|No_ldSuf, { Test, Reg32 } // Move after swapping the bytes -movbe, 0x0f38f0, None, CpuMovbe, D|Modrm|No_bSuf|No_sSuf|No_ldSuf, { Word|Dword|Qword|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } +movbe, 0x0f38f0, None, CpuMovbe, D|Modrm|CheckRegSize|No_bSuf|No_sSuf|No_ldSuf, { Word|Dword|Qword|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } // Move with sign extend. // "movsbl" & "movsbw" must not be unified into "movsb" to avoid @@ -302,7 +302,7 @@ cmp, 0x3c, None, 0, W|No_sSuf|No_ldSuf, cmp, 0x80, 7, 0, W|Modrm|No_sSuf|No_ldSuf, { Imm8|Imm16|Imm32|Imm32S, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } test, 0x84, None, 0, W|CheckRegSize|Modrm|No_sSuf|No_ldSuf, { Reg8|Reg16|Reg32|Reg64, Reg8|Reg16|Reg32|Reg64|Unspecified|Byte|Word|Dword|Qword|BaseIndex } -test, 0x84, None, 0, W|Modrm|No_sSuf|No_ldSuf, { Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } +test, 0x84, None, 0, W|CheckRegSize|Modrm|No_sSuf|No_ldSuf, { Byte|Word|Dword|Qword|Unspecified|BaseIndex, Reg8|Reg16|Reg32|Reg64 } test, 0xa8, None, 0, W|No_sSuf|No_ldSuf|Optimize, { Imm8|Imm16|Imm32|Imm32S, Acc|Byte|Word|Dword|Qword } test, 0xf6, 0, 0, W|Modrm|No_sSuf|No_ldSuf|Optimize, { Imm8|Imm16|Imm32|Imm32S, Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseIndex } @@ -970,7 +970,7 @@ fucompi, 0xdfe8, None, Cpu687, NoSuf, { // Pentium4 extensions. -movnti, 0xfc3, None, CpuSSE2, Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf, { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } +movnti, 0xfc3, None, CpuSSE2, Modrm|CheckRegSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf, { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } clflush, 0xfae, 7, CpuClflush, Modrm|Anysize|IgnoreSize|NoSuf, { BaseIndex } lfence, 0xfaee8, None, CpuSSE2, NoSuf, {} mfence, 0xfaef0, None, CpuSSE2, NoSuf, {} @@ -3053,7 +3053,7 @@ cldemote, 0x0f1c, 0, CpuCLDEMOTE, Modrm| // MOVDIR[I,64B] instructions. -movdiri, 0xf38f9, None, CpuMOVDIRI, Modrm|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf, { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } +movdiri, 0xf38f9, None, CpuMOVDIRI, Modrm|CheckRegSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_ldSuf, { Reg32|Reg64, Dword|Qword|Unspecified|BaseIndex } movdir64b, 0x660f38f8, None, CpuMOVDIR64B, Modrm|AddrPrefixOpReg|NoSuf, { Unspecified|BaseIndex, Reg16|Reg32|Reg64 } // MOVEDIR instructions end.