mbox series

[v2,0/2] RISC-V: Preparation for more generic linker relaxation

Message ID cover.1697330630.git.research_trasio@irq.a4lg.com
Headers
Series RISC-V: Preparation for more generic linker relaxation |

Message

Tsukasa OI Oct. 15, 2023, 12:44 a.m. UTC 
  Hi,

For details, see the cover letter of PATCH v1.

PATCH v1:
<https://sourceware.org/pipermail/binutils/2023-October/129952.html>

Changes: v1->v2
1.  [1/2] Minor fix to the commit message
2.  [1/2] Deduplicate bfd_link_pic(info)
          as RISCV_RELAX_PIC feature flag
3.  [2/2] Change some function description comment
          from "GP-relative" to "GP/zero-relative".

Thanks,
Tsukasa




Tsukasa OI (2):
  RISC-V: Group linker relaxation features
  RISC-V: Prepare for more generic PCREL relaxations

 bfd/elfnn-riscv.c | 191 ++++++++++++++++++++++++++--------------------
 1 file changed, 110 insertions(+), 81 deletions(-)


base-commit: cd09b5ddefe662dcaa793cfa348730cbdee1e01b

Comments

Nelson Chu Oct. 15, 2023, 2:29 a.m. UTC | #1 
On Sun, Oct 15, 2023 at 8:44 AM Tsukasa OI <research_trasio@irq.a4lg.com>
wrote:

> Hi,
>
> For details, see the cover letter of PATCH v1.
>
> PATCH v1:
> <https://sourceware.org/pipermail/binutils/2023-October/129952.html>
>
> Changes: v1->v2
> 1.  [1/2] Minor fix to the commit message
> 2.  [1/2] Deduplicate bfd_link_pic(info)
>           as RISCV_RELAX_PIC feature flag
>

PIC isn't a relaxation feature, and we used to use bfd_link_pic everywhere,
so it seems no good to define it to another RISCV_RELAX_PIC.

Nelson


> 3.  [2/2] Change some function description comment
>           from "GP-relative" to "GP/zero-relative".
>
>
>
Tsukasa OI Oct. 15, 2023, 5:12 a.m. UTC | #2 
On 2023/10/15 11:29, Nelson Chu wrote:
> 
> 
> On Sun, Oct 15, 2023 at 8:44 AM Tsukasa OI <research_trasio@irq.a4lg.com
> <mailto:research_trasio@irq.a4lg.com>> wrote:
> 
>     Hi,
> 
>     For details, see the cover letter of PATCH v1.
> 
>     PATCH v1:
>     <https://sourceware.org/pipermail/binutils/2023-October/129952.html
>     <https://sourceware.org/pipermail/binutils/2023-October/129952.html>>
> 
>     Changes: v1->v2
>     1.  [1/2] Minor fix to the commit message
>     2.  [1/2] Deduplicate bfd_link_pic(info)
>               as RISCV_RELAX_PIC feature flag
> 
> 
> PIC isn't a relaxation feature, and we used to use bfd_link_pic
> everywhere, so it seems no good to define it to another RISCV_RELAX_PIC.
> 
> Nelson

Okay, (about PIC) I agree that it's not worth it.  Even for performance
reasons, the possible improvement will be marginal (too small to get
real improvements).  I'll withdraw this part from the next version.

I hope that you accept the rest (obviously you didn't as in another
e-mail but hope that you reconsider; this is just a preparation for
other changes regarding linker relaxation).

Thanks,
Tsukasa

>  
> 
>     3.  [2/2] Change some function description comment
>               from "GP-relative" to "GP/zero-relative".
> 
>