mbox series

[0/2] MIPS disassembler styling

Message ID cover.1667483581.git.aburgess@redhat.com
Headers
Series MIPS disassembler styling |

Message

Andrew Burgess Nov. 3, 2022, 1:58 p.m. UTC 
  This commit adds disassembler styling for MIPS.

Patch 1/2 changes the disassembler to make use of the assembler
directives .word and .short.  This isn't a requirement, but I think is
an improvement.  There's a lot of updated tests in this commit, it's
possible that this patch might be too large to reach the mailing list.
In case of this, I've pushed my work to the branch:
     users/aburgess/try-mips-disasm-styling

Patch 2/2 is where I actually add disassembler styling.  If patch #1
is not wanted then I can easily rebase this second patch, removing the
use of .word and .short, just let me know.

Thanks,
Andrew

---

Andrew Burgess (2):
  opcodes/mips: use .word/.short for undefined instructions
  libopcodes/mips: add support for disassembler styling

 .../testsuite/binutils-all/mips/mips-ase-1.d  |   2 +-
 .../binutils-all/mips/mips-xpa-virt-1.d       |   4 +-
 .../binutils-all/mips/mips-xpa-virt-2.d       |   4 +-
 .../binutils-all/mips/mips-xpa-virt-3.d       |   2 +-
 .../binutils-all/mips/mips1-branch-alias.d    |   4 +-
 .../binutils-all/mips/mips1-branch-noalias.d  |   4 +-
 .../binutils-all/mips/mips16-extend-noinsn.d  |  24 +-
 .../binutils-all/mips/mips16-pcrel.d          |  16 +-
 .../binutils-all/mips/mips32r6-branch-alias.d |   4 +-
 .../mips/mips32r6-branch-noalias.d            |   4 +-
 gas/testsuite/gas/mips/interaptiv-mr2@mcu.d   | 112 ++---
 .../gas/mips/mips16-32@mips16-asmacro.d       |   6 +-
 gas/testsuite/gas/mips/mips16-32@mips16-sub.d | 436 +++++++++---------
 .../gas/mips/mips16-32@mips16e-64-sub.d       |   4 +-
 .../gas/mips/mips16-32@mips16e-sub.d          |  66 +--
 gas/testsuite/gas/mips/mips16@save-sub.d      |  68 +--
 gas/testsuite/gas/mips/mips1@isa-override-1.d |  16 +-
 gas/testsuite/gas/mips/mips1@save-sub.d       |  68 +--
 gas/testsuite/gas/mips/mips2@isa-override-1.d |  12 +-
 .../gas/mips/mips32@isa-override-1.d          |  14 +-
 .../gas/mips/mips32r2@isa-override-1.d        |  14 +-
 gas/testsuite/gas/mips/set-arch.d             | 208 ++++-----
 gas/testsuite/gas/mips/tls-o32.d              |   4 +-
 opcodes/disassemble.c                         |   5 +
 opcodes/mips-dis.c                            | 306 +++++++-----
 25 files changed, 751 insertions(+), 656 deletions(-)

Comments

Andrew Burgess Nov. 28, 2022, 5:15 p.m. UTC | #1 
Ping!

Thanks,
Andrew

Andrew Burgess <aburgess@redhat.com> writes:

> This commit adds disassembler styling for MIPS.
>
> Patch 1/2 changes the disassembler to make use of the assembler
> directives .word and .short.  This isn't a requirement, but I think is
> an improvement.  There's a lot of updated tests in this commit, it's
> possible that this patch might be too large to reach the mailing list.
> In case of this, I've pushed my work to the branch:
>      users/aburgess/try-mips-disasm-styling
>
> Patch 2/2 is where I actually add disassembler styling.  If patch #1
> is not wanted then I can easily rebase this second patch, removing the
> use of .word and .short, just let me know.
>
> Thanks,
> Andrew
>
> ---
>
> Andrew Burgess (2):
>   opcodes/mips: use .word/.short for undefined instructions
>   libopcodes/mips: add support for disassembler styling
>
>  .../testsuite/binutils-all/mips/mips-ase-1.d  |   2 +-
>  .../binutils-all/mips/mips-xpa-virt-1.d       |   4 +-
>  .../binutils-all/mips/mips-xpa-virt-2.d       |   4 +-
>  .../binutils-all/mips/mips-xpa-virt-3.d       |   2 +-
>  .../binutils-all/mips/mips1-branch-alias.d    |   4 +-
>  .../binutils-all/mips/mips1-branch-noalias.d  |   4 +-
>  .../binutils-all/mips/mips16-extend-noinsn.d  |  24 +-
>  .../binutils-all/mips/mips16-pcrel.d          |  16 +-
>  .../binutils-all/mips/mips32r6-branch-alias.d |   4 +-
>  .../mips/mips32r6-branch-noalias.d            |   4 +-
>  gas/testsuite/gas/mips/interaptiv-mr2@mcu.d   | 112 ++---
>  .../gas/mips/mips16-32@mips16-asmacro.d       |   6 +-
>  gas/testsuite/gas/mips/mips16-32@mips16-sub.d | 436 +++++++++---------
>  .../gas/mips/mips16-32@mips16e-64-sub.d       |   4 +-
>  .../gas/mips/mips16-32@mips16e-sub.d          |  66 +--
>  gas/testsuite/gas/mips/mips16@save-sub.d      |  68 +--
>  gas/testsuite/gas/mips/mips1@isa-override-1.d |  16 +-
>  gas/testsuite/gas/mips/mips1@save-sub.d       |  68 +--
>  gas/testsuite/gas/mips/mips2@isa-override-1.d |  12 +-
>  .../gas/mips/mips32@isa-override-1.d          |  14 +-
>  .../gas/mips/mips32r2@isa-override-1.d        |  14 +-
>  gas/testsuite/gas/mips/set-arch.d             | 208 ++++-----
>  gas/testsuite/gas/mips/tls-o32.d              |   4 +-
>  opcodes/disassemble.c                         |   5 +
>  opcodes/mips-dis.c                            | 306 +++++++-----
>  25 files changed, 751 insertions(+), 656 deletions(-)
>
> -- 
> 2.25.4
Nick Clifton Nov. 30, 2022, 4:50 p.m. UTC | #2 
Hi Andrew,

> Ping!

Hmm, noone has objected, so please go ahead and apply your patch.

Cheers
   Nick
Andrew Burgess Dec. 5, 2022, 10:08 a.m. UTC | #3 
Nick Clifton <nickc@redhat.com> writes:

> Hi Andrew,
>
>> Ping!
>
> Hmm, noone has objected, so please go ahead and apply your patch.

Thanks.  I pushed these patches.

Andrew