mbox series

[avr,0/1] Addendum to PR3124: Don't PROVIDE __flmap_init_label

Message ID 2e7671e3-8cfd-4a86-94df-31985365fb1b@gjlay.de
Headers
Series Addendum to PR3124: Don't PROVIDE __flmap_init_label |

Message

Georg-Johann Lay Jan. 30, 2024, 1:37 p.m. UTC 
  Hi Nick,

this patch removes PROVIDE from __flmap_init_label,
which is needed to make the startup code from AVR-LibC work
with versions of Binutils that don't have PR31124: The start
code would weakly define __flmap_init_label, but when Binutils DOES
support PR31124, then we need the correct values, hence no PROVIDE.

If approved, please apply.

Also if it is possible to squeeze this in v2.42, that would be great.

Thanks,

Johann

Comments

Nick Clifton Jan. 30, 2024, 1:44 p.m. UTC | #1 
Hi Johann,

> this patch removes PROVIDE from __flmap_init_label,

Err, I think that you forgot to attach the patch ...

> which is needed to make the startup code from AVR-LibC work
> with versions of Binutils that don't have PR31124: The start
> code would weakly define __flmap_init_label, but when Binutils DOES
> support PR31124, then we need the correct values, hence no PROVIDE.
> 
> If approved, please apply.
> 
> Also if it is possible to squeeze this in v2.42, that would be great.

Assuming that it is OK for the mainline, then I will also apply it to the 2.42 branch.
But - since the 2.42 release is now out, it will only affect people who check out the
branch, or if we make a 2.42.1 point release...

Cheers
    Nick
Georg-Johann Lay Jan. 31, 2024, 8:43 a.m. UTC | #2 
Am 30.01.24 um 14:44 schrieb Nick Clifton:
> Hi Johann,
> 
>> this patch removes PROVIDE from __flmap_init_label,
> 
> Err, I think that you forgot to attach the patch ...


Hi Nick,

the patch is in a separate e-mail that only contains the commit
message and the patch:

https://sourceware.org/pipermail/binutils/2024-January/132247.html

Thanks,

Johann

>> which is needed to make the startup code from AVR-LibC work
>> with versions of Binutils that don't have PR31124: The start
>> code would weakly define __flmap_init_label, but when Binutils DOES
>> support PR31124, then we need the correct values, hence no PROVIDE.
>>
>> If approved, please apply.
>>
>> Also if it is possible to squeeze this in v2.42, that would be great.
> 
> Assuming that it is OK for the mainline, then I will also apply it to 
> the 2.42 branch.
> But - since the 2.42 release is now out, it will only affect people who 
> check out the
> branch, or if we make a 2.42.1 point release...
> 
> Cheers
>     Nick
Nick Clifton Jan. 31, 2024, 11:25 a.m. UTC | #3 
Hi Johann,

> the patch is in a separate e-mail that only contains the commit
> message and the patch:

Sorry - I was a bit slow yesterday.


> https://sourceware.org/pipermail/binutils/2024-January/132247.html

Patch approved and applied, mainline and 2.42 branch.

Cheers
   Nick