From patchwork Wed Feb 14 16:02:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Hawkins X-Patchwork-Id: 20378 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp1314448dyb; Wed, 14 Feb 2024 08:03:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXd3K0LG+SmaThI2+O8tRxKborjMoVYnXrIX7GYDbR8pw9Etb9wRWDRsBvw8g9OafWPOzh6exwiv35xCzNgjok8fd8BXg== X-Google-Smtp-Source: AGHT+IHy7tmImtia4yMdo9/jN/t9ezyZaDHb/aZASpTvSTbbfnQyDsidw9MHT2sNqxShNkdWE2c9 X-Received: by 2002:ac8:5cc3:0:b0:42c:557b:87f2 with SMTP id s3-20020ac85cc3000000b0042c557b87f2mr4399922qta.23.1707926605865; Wed, 14 Feb 2024 08:03:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707926605; cv=pass; d=google.com; s=arc-20160816; b=TF0KTxgVjBnC6ZKsQ435OYFxUnu6JHhNbTypueEncQRb+B2xjU/K/HQqqDwtoPHO0R rxNl95aISMj7GQlFyRZPLoFe9HPKvtuBjdcOuEgn4rC8+nrKmEXC2yLC0ZGZFtmbN4/X RElgEx9j9fsLtaOrpab/ZkUA3y3evgPDihHQpSedia77AEgh+w13GZcAfp44CNyprJTi ROgp4o/4uyuGhjRu+dkNAjyfXPQriZk2Se8y/yN3uNMOdBJ6+DJrTXPHXHhV2u+vY/J9 6ijuovLMdGZYl1GZHE0Iul4VqIUv/zTC8ccrmijWGq6gtOSaa+/y2SDnTK70kiqyofF0 7V/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=8Z60LVa2yo94UjffJ+5a57KmrGG6y2Q1sZx1SPdvz+A=; fh=UB/uHa9KNkYwKYMNpjjYGPlEPQpcuaPUIT5PnQAL3Vg=; b=qTs0ZFrDdn0YuEchP/j2LZNlvIBQN3/jJawGsUAKLrMIjFbfxQfFigE6xpQ8ZnK6xR 5Af6M6WSqRE50s96bTcllpmudQHovdhppYbdfNjnchXpuefHU1hhFZmHQTzjM7xm2eSU /WVULpyeaY/ZdizJIBvkL1kDe1aGi033Vzi/Uin7d6K88XhJz3/nmHAc0Yaq0lkSvmMa 3J9iU4QNhfTZyp4VV3LY46DDGyyohJyLsyc3hG1RhMHY+SaNTUqaCiFsSvCripU56p2h gnGmw/BK3JCRlGfAJGMgxuMi+zLDgFxLqUafUepxW6OzPflx5BesTPo3CT6sbhhMCDZU c3DA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@obs-cr.20230601.gappssmtp.com header.s=20230601 header.b=HucLDLIZ; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" X-Forwarded-Encrypted: i=2; AJvYcCUUqjP5XV6X+NnshToKbpF2wo2nkUSWHRnNE6DmwerrtEa5k0TsFWOzAT3zOd666Z5JFyZfVf4ADtUhONWohaohoKRsMw== Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id v15-20020ac8728f000000b0042c01ce9059si5091249qto.430.2024.02.14.08.03.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 08:03:25 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@obs-cr.20230601.gappssmtp.com header.s=20230601 header.b=HucLDLIZ; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 76395385E005 for ; Wed, 14 Feb 2024 16:03:25 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id 8C236385840C for ; Wed, 14 Feb 2024 16:03:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C236385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8C236385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::82a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707926597; cv=none; b=nVz2L47mvQ7csqP/2eK3dmFbuPHB4Ti/3C7iXdWyIp45YJNuRFHk0zUomnO/4ORDzVZKr3XArxhpufBhrHSyOnxgILgW86nzIJtrchD/zfRuFuLClIODroxhhQZr8UJyYb8wJnyy/TrGF+kSBDx9tY+4n4Wqa0Q3bJ61137zSK0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707926597; c=relaxed/simple; bh=j1fwvFt/rcTq/qwkPOLAcmmZWpGpW4QXLBxCJSWaBuQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rvwGJ1+ylicxX6BeVvBEb7SMbhUqfMrMNFYCyAfiDQv4Ai/92qq+Esnn4tF8KENEyE7mxeauxeNPEPo7ZhScPet5dzK5H8zaTCFJWOam1tGBLDdW+1y8XdvQAE/6NjfzEXca1Ildjwu8Te6lVBQL0+YRkXlCkDmFVMNNzVX5dIQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-42c758f075dso8133711cf.0 for ; Wed, 14 Feb 2024 08:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20230601.gappssmtp.com; s=20230601; t=1707926594; x=1708531394; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8Z60LVa2yo94UjffJ+5a57KmrGG6y2Q1sZx1SPdvz+A=; b=HucLDLIZd1GT/3CWythoZHzhRN7UfW8DP/HJ1zEUPM2/eOOFjcPPhmLfGRbjz0S3gC 3M7gfb6En437j+PjlRX53SlSthGNT0SDwvsBNI40UTI+OTVqEXdqNcAj1RwET+iSy/1V UpXqGGaVS5r9qtAwfGnRScOMY5FLLq8bhcokahFVjTQvtShyiy9KEm9Z1qmNHc4PD0xq UcC2Oge4yyRwAjE4oYiCQgBBP+LyZY40ewa+szN4BhRXQ+CtYJoRZZfZEQiG9jSoH/9u 0OosDePLYaYU94w4Fv5kJ4UtsfunCCF+Ln4B5Da7y5JaTFCFNnnhWVuPR2pkPlezpfyb yUIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707926594; x=1708531394; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Z60LVa2yo94UjffJ+5a57KmrGG6y2Q1sZx1SPdvz+A=; b=EqEETz+L8bRBNNxt6p2nv0Wn3J6fcArvVZSGXcU2ZSVRvIuIY/XKV4elrgSrvQNNfi YySPRK57Nfq4sfrGahBYe70i2rTo8Hc9UDKPeTP3ovC0wqC3HDIC2hpFdgk6Te56ZfQD n5dc6ET18yb73bVZDA8EdIXuBJkr4oBSxJVJIsPLFdZXVj94i7B3ZpHJ6MEJOvZyaQiC L3zTxDFg/rG4Zwo57nWsV38X5LjyNhVxObRzuxPgKyPsIGw/3q5e+CEJdaoDOX2sdBfP vqy9alNbnupT/tF2q0pehb0cZup3P7DPGDfw/0YYsyssVyowHnV0kMccsfZpX/zJwJsU 8hNA== X-Gm-Message-State: AOJu0YwDI4O8aJ4T1g+3EsT7zFwwc0HEMB3t7z1gQIQY3DavPQRplrI9 gk1MRqLpZvjOH/F314iPBMe7vOeuGXOqvjq5hRPZXN/2dciR5q+u/ipQEIqza0BXBoxvu/5X04Q u X-Received: by 2002:ae9:e116:0:b0:785:cdad:f113 with SMTP id g22-20020ae9e116000000b00785cdadf113mr3659025qkm.38.1707926594526; Wed, 14 Feb 2024 08:03:14 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWkiB/zp46+cgwNUopU12T892WZ+ZPyeMoJ4b7m5QcdaYaaMb/Rkofo0BfPvoylLCWriOvGnz8I6PxzCihUQDLAU62LxJh6Kg== Received: from borderland.rhod.uc.edu ([129.137.96.2]) by smtp.gmail.com with ESMTPSA id fa11-20020a0561302f8b00b007d2e2f14bd4sm1593032uab.29.2024.02.14.08.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 08:03:14 -0800 (PST) From: Will Hawkins To: binutils@sourceware.org Cc: Will Hawkins , yonghong.song@linux.dev Subject: [PATCH v3 0/1] Move callx (nee callr) to v1 ISA variant Date: Wed, 14 Feb 2024 11:02:59 -0500 Message-ID: <20240214160303.869180-1-hawkinsw@obs.cr> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790890848900621564 X-GMAIL-MSGID: 1790890848900621564 Thank you for all the feedback on v1 and v2! Thanks to the willingness of the clang/llvm developers to compromise on their encoding of the callx instruction, this version of the patch is much more straightforward than v2. In other words, a special thanks to Yonghong Song! The only "controversial" piece of this patch is the reworking of the testsuite code. I refactored the test code slightly to (visually) match the test code from the clang/llvm test code for the callx instruction. It made it easier for me to visually confirm that the objdump output matches. I am more than happy to revert that piece if what I did goes too far. Of course, I am also happy to change anything about this patch to make sure that it meets the community's guidelines. Thank you, again, for all the help! Will Will Hawkins (1): objdump, as: Add callx support for BPF CPU v1 gas/testsuite/gas/bpf/indcall-1-pseudoc.d | 8 ++++---- gas/testsuite/gas/bpf/indcall-1-pseudoc.s | 6 +++--- gas/testsuite/gas/bpf/indcall-1.d | 10 +++++----- gas/testsuite/gas/bpf/indcall-1.s | 6 +++--- include/opcode/bpf.h | 2 +- opcodes/bpf-opc.c | 4 ++-- 6 files changed, 18 insertions(+), 18 deletions(-)