From patchwork Thu Jun 8 04:49:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Indu Bhagat X-Patchwork-Id: 10459 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp42481vqr; Wed, 7 Jun 2023 21:50:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7vbRyoPZZsdIrSv04QkPeeQrV+KZgD4UP1bWt/uU0WlLEif+tn9bWUhnPxQ3To9bPtSdyJ X-Received: by 2002:a17:907:72cc:b0:973:940e:a00f with SMTP id du12-20020a17090772cc00b00973940ea00fmr7293492ejc.6.1686199801146; Wed, 07 Jun 2023 21:50:01 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id qx13-20020a170906fccd00b00977d16c01fesi211946ejb.379.2023.06.07.21.50.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 21:50:01 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=KVMQ6NrZ; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 295313856DCA for ; Thu, 8 Jun 2023 04:49:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 295313856DCA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1686199797; bh=dg8MSy6XMmaDeVE7PtOM0jLK94JwEty0N7afgUAUQL8=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=KVMQ6NrZzsEYFZ1/amEOQARYEjXoupip9NmxYEup2b1vFAAP/pYJHW1OJcToQtn8O W4AkSNp0XDBFArXP2q2ruNiYJkYcThOcSkVw6BAx3Gbi9fOc8lU/oqBaYYFUyQUyCs PO7u0l7YQwtH0sR/Pra3v50D4rVR/7sAzAr0zscI= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id ED7BE3857B9B for ; Thu, 8 Jun 2023 04:49:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED7BE3857B9B Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3580D9uo007991 for ; Thu, 8 Jun 2023 04:49:46 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3r2a6rkayu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 08 Jun 2023 04:49:46 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3582lf4t010420 for ; Thu, 8 Jun 2023 04:49:45 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3r2a6rcujj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 08 Jun 2023 04:49:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dzFiaIv8qzxaEWwOEfpOFDbgwAREtqZJtOgJq3bnMM/E4vmKlCNa3Jl8L9mAfKW9TcTLyQlYDw/3EwtNaUOyHXEoSTFkfiwA1yYd/VPHLIN19j4szitoPyggcahuWBvNe53QAlSI5cwFHAU1NrTITTvNnof9qyJN1Qi6CnfpvFkN1JWb044FBYH+aZyb9+vsko4LAf6ji+bg1QMa9vdCFU6rqv+B3KKHAcuu+9GUWspvWeycybk6G/YXI7A4A8q8FaA3laLb3hw0GWBDyf3SnTTLMjgAfWaHkucJ8qPEOxu+xgZ8k2aF+Orr7nzcc8uGT3zNTWTwHdMMoxLvfSZ8iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dg8MSy6XMmaDeVE7PtOM0jLK94JwEty0N7afgUAUQL8=; b=CJeymJKk+oxXXx5Ohu2ZfZm3lAok5SqwQb2e6hWbTj8Cx7FlNp/SoVsRpup8c9FVn++M72KTolNYKymZ8o99RYEhHz7Cnp8dysujNTZKgKV2hzl5Lv6LTsOuR2XUrmNL6MG5VRnOtEoeUsVMJanTEqXkM9uDKlCKfEuUiTataRkcv6QDI9hK31he02CxtgzMA/Q1mCWKI/BJJFBxhYDFfowUb1o91M1cquqYQKEtxgif47xiBQYk2YOrYBoS09B5iOlpD+HPvIzc9ZEbEP4GR1OsdX4ejVb4TO1fJwnWCoft65VIscBIQJXRzW1k93v7YRGJZAEdxwK7hGKREuykFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB4461.namprd10.prod.outlook.com (2603:10b6:a03:2d8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Thu, 8 Jun 2023 04:49:44 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fdbb:b921:1ef:2d44%4]) with mapi id 15.20.6455.028; Thu, 8 Jun 2023 04:49:44 +0000 To: binutils@sourceware.org Cc: Indu Bhagat Subject: [PATCH 0/2] libsframe: changes to semantics of two existing APIs Date: Wed, 7 Jun 2023 21:49:33 -0700 Message-Id: <20230608044935.4183325-1-indu.bhagat@oracle.com> X-Mailer: git-send-email 2.39.2 X-ClientProxiedBy: MW3PR05CA0030.namprd05.prod.outlook.com (2603:10b6:303:2b::35) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB4461:EE_ X-MS-Office365-Filtering-Correlation-Id: 0561517e-a443-41fd-0d2a-08db67dbc6f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hhV8HwtxsL0q5nJwHkD78Q0xC3BeSOJF6YVa1uRbtpMUdXNGN0ZdfsVEUZiJL41Q5lDeGdN7g4J8jK00mSPH7+z3jXko3YLBBIsT+HmAYZir2S+ri3zkQPy9KFrKw+2bJGE/RGXmFZEC/Eua078PM1E3/opSCvCRtSA8tFeLMU5vtS0pFg2ACpPZnLSL2yU4cdDFDFxRA3T6c9K0hrra3WNMSI3qgCct8+eUX/tF2qM3fcddDmk4uEfwooXzGX186ib6jTUtElO/GomApI6AFRCQHM357Fxpk8k3kW8Eh82QZCeUsto1v9wXaOhUndyReAE+abwa1R4vHIl27NCltKM1c5bGoZ/FI0vxK59iafqmUME5vzQT81zDIU5IRkPNNQW7Hw6fnSckV//Kj6XI13eAcD7cK8/TirAIA5kBT6fRjRLhIHo3txt0V2c2GwCHMs+LGr5Vi4Y7gVHQU2PJXOdy5EPwlhdS6vM3GXDcXwqSZjEKiPJ2usz4BPGN3FMWa2F1C02CinLs97YLbkEvbJ1MrOuL8KkPJPC1W7JLbL4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2158.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(346002)(366004)(376002)(396003)(451199021)(6486002)(478600001)(6666004)(36756003)(2616005)(186003)(38100700002)(86362001)(83380400001)(966005)(26005)(6512007)(1076003)(6506007)(107886003)(8936002)(5660300002)(8676002)(41300700001)(44832011)(2906002)(316002)(4326008)(6916009)(66556008)(66476007)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yY3S9W8qK0tmBcNHbK40jb8feuxEy6mroqC9kGqayl3Pdtg3jcK5XCkBY0gWNzNeNyN0P+QHPKuqLoEs5NNfsT9rqhJyH+T+okKKa2MPmaLC+4+LyrrgmAOeLVIi6iTwdQ/S2BriKuCiYkFL8fYRaTkvW9NMFb97WvKga2g19o701Ywk9A8XvP1/PNfZmR9QgpD2i4a9tEkaQOITsLx1E37b+5pz81Pf4uwcItQuhi9vc2Z5wQyG+/he63yqU4kI7AYcXYBAmSVcriHbAs4MD9/tmbEgZtnQgoxT+AORbu3TYSlwzITLnHzcwjYJehRuewzzEh/5SVFuGkditZJcAmNmlRjtnjixHL33GKT4PknjtgGfKiaIpUYP/kZYniIIke333ow7paku2BECIzjwr6jkaj7ikFI1h7bxKND0AA9RBS3XVylNYja0ZAM5collrm5EP5v5PtzQhRD9rHbITOK1oTaT/NRUareq/6zd5fKXvPD3B3zXkd80Lh4PYpcULcvNr/1t//R+D9FhAzkK9VQrg32M0ngrBGjG8jMRMXlKpAfcGd0+ineyVK1P2yUDJX+PxOlXYJZy/0vehdGQ/PqClXsB50PfA9Onn6T03xh/jKuhud7XgDW+okYsctCmYM/5hyGRU0bpgwdQzehKcA7aondD4QpNCLIVNb3iZ5iEmepU00WWVkvHfWjtcIWxbZQweud5BLc0Xt9qGDLlzEUgr4qY14KnsPjqrA5DcXeF80pamDBdC+MW5TcjPt/iQ2Eu6m1gK3HLOqlmCebgi6/dy8yDT5LTTtT+9ns7t9XqYbMTQpd9lbuNIa7FjP731rGG8TUPjZDHnQcM6IldEA7BtZ+6+A+cPY9zbLu2g3b7Fk63c34lG+Uk3VX6N9ohAytK8jcZvdBpF3k2ZIx0stEbWkjIWXi/szVHabwgRjeAAlYaJ+Uvlfqsh9dkFF3ckLJ9tLsPyIeDPgeyUNEPGu/OvLDVBF3V9Nmhn9Q3HVHW6w0/fBnwlXbFqMIS/yOrRu7PjemkkP9OL02mgBDhGuZCI4JFxSB7rYqnAbDXll5zXldZvktKfgoGSTwkeX5cmPUa+FRGxGGrmQI/fP9Lt/kcatL2Nb5keI1ql2IjV5oH+9kwboxBxa19z2CDRpQsH/878vuNUqp83zK5HA21DUj/IWz3lUZFxlluPQY/2IoNRyGE/krGdfjl8uU1V3rhQVYPbOaGM4/UyeP7KJ3PAhdt29LGiYeMVB5aysRDCoy8wSLyDjurrdInyf0mvXlGH01dl79fPWr7gP4utdQyhZVZ0WrQGNAhiZiKXgyv2bk56CqfUBsM0FvgLF3FCbjEWSLeQHfsJns/vJ0LPSUMP+zsZnQkNlG7K3G0AYt2mLIBpgdZKuBHq35vCHIL59JUx2LsQv1t+xbtw64+96Cb0rCIGCwpFUXMgcs9g/lcUhVBfqTsIgCZw258LyWC1Hh+qUCb0VANkQQYloysPdCkKL/dM2Y4DeiQ8h6s0uYWjUQG40Jz8M4HYX1tce4bimrUsxJFZWCXNHqHSUaY2H7Gbei8op3j1HHt4ofyWNrMAB7BfajHtrM8XQ6z2kpy6Tx3 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 56K3ClTouoD6hgP4Jgxnm+YnA7kB0z0jomk7rOJrfjpzAhIKDO26eGZOU29aUHOT32bPqHv57uJb8MP9Uz4D2MOQfQeADPeliJv/HgYf/S/XmuZrH+e8ddxQ84NPAKEbGyJDwmG1/r/UZGODRGHi8ydnQDi1i4mGSiW/usgjR7JESMJemwcWL9tdKd2pV8tCcp7LOgxSuYqWKgENPz/6RQcEs7Pr8/fD2pYiV4eFvaDUinhwTNYh9dP1phV/y7JKHQ1MEiXuGmmEYHrbNxTmsHipptSND7VyQGgPybklmiJ1Zx+7tOxOWmFVjor71XioHbSVT2Hq/CWeyj6rEZ1RAIWGV5pOYoHN0S9gtLO9i/vbGMjU1v8SuIPivn4vRFsRmlxYBfWak8xZUlvFO+LpJ3jHVggam4olv9bQsxPKr6hiEnrRHsDAkLnj792IFlWxe+Nrjnsh4o/pGH5Oqya6YKsHWz5QiFJQxxKb+H3TWf3NscWUYjD19S9reGLpQt84FiqWioXyBrUyu+COL/JagGWLeNOtj2GY5nX46lOA4lHfkkR61ihIQw7VdIOzmMyodrRl58SPZbEFroO+hu6k+8oPfQgRn+Wfob432kINHPHXxyDpzCxK18zCvRviVYeNOYzCmi1hkMp12GhUCrij5Fb1aja4mpm4oEplQxPCCSgK63G3lofVpw8Wl4Eb+eggYYJh+ohNhjofkbHw/aAz3StfF6GzWaaYDtVPdxIxaPzSTtg5uT6QZlpjDthdDrmZ X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0561517e-a443-41fd-0d2a-08db67dbc6f5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2023 04:49:43.8017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Li+5f6yF0TwKu/2iAwgVp1sKSLfDT1XgW4+WaM88i187+kPHyJ9VymG8sonYttp6oRIi6mthxWRlUzxP6Ej/WA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4461 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-08_02,2023-06-07_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 mlxlogscore=961 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306080038 X-Proofpoint-ORIG-GUID: YGcfT1rEj7fNQjlXYEdK5ati9luQVn-G X-Proofpoint-GUID: YGcfT1rEj7fNQjlXYEdK5ati9luQVn-G X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Indu Bhagat via Binutils From: Indu Bhagat Reply-To: Indu Bhagat Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768108642793635261?= X-GMAIL-MSGID: =?utf-8?q?1768108642793635261?= Hello, This patch set needs review/discussion. I had previously thought that such a change will necessitate symbol versioning for the functions in question (Hence, the question towards the end in the thread https://sourceware.org/pipermail/binutils/2023-May/127441.html). But after some thought, I am inclining towards not keeping versionined APIs for the following functions in the current patch set: - extern int32_t sframe_fre_get_fp_offset (sframe_decoder_ctx *dctx, sframe_frame_row_entry *fre, int *errp); - extern int32_t sframe_fre_get_ra_offset (sframe_decoder_ctx *dctx, sframe_frame_row_entry *fre, int *errp); The reason for not versioning the functions is that the proposed change, in both the functions, is switching a previous error into non-error. This should not break a consumer like stack tracer: The only case of breakage will be when the stack tracer code relies on the APIs returning specific error code. The latter should be unnecessary and rare, IMO. More details in the respective commit logs. (PS: The tone in the commit logs is more decisive than the cover letter here, because it is aligned to what the patches do.) Can you please take a look and let me know what you think ? There is some subjectivity to the matter, hence the request for comments before this is committed. Thanks, Indu Bhagat (2): libsframe: update the semantics of sframe_fre_get_ra_offset libsframe: update the semantics of sframe_fre_get_fp_offset libsframe/sframe-dump.c | 12 ++++++++---- libsframe/sframe.c | 31 ++++++++++++++++++++----------- 2 files changed, 28 insertions(+), 15 deletions(-)