[v2,0/5] Some MIPS changes and testsuite fixes

  In this patchset, we:                                  
1. Set the default arch to 64rN for `mipsisa32rN*-linux-gnu-as -64`
   Set the default arch to 32rN for `mipsisa64rN*-linux-gnu*-as -32`
2. Set the default arch to 32r6 for mips*-img-*.       
3. Fix testsuite for all r6 targets:                   
        mipsisa32r6*/mipsisa64r6*/mips-img-*.          
4. Fix testsuite for all -gnuabi64 targets, which are N64 default.
5. Fix or xfail some testcases for ld if compilers are available.
                                                           
Run testsuite with targets:                            
        mipsisa32-linux-gnu mipsisa32r2-linux-gnu mips-linux-gnu                                                       
        mipsisa32el-linux-gnu mipsisa32r2el-linux-gnu mipsel-linux-gnu
        mipsisa32r6-linux-gnu mipsisa32r6el-linux-gnu  
        mips-img-linux-gnu mipsel-img-linux-gnu        
        mips-img-elf mipsel-img-elf                    
        mips-mti-elf mipsel-mti-elf                    
        mips64-linux-gnu mips64el-linux-gnu            
        mipsisa64-linux-gnu mipsisa64el-linux-gnu      
        mipsisa64r2-linux-gnu mipsisa64r2el-linux-gnu  
        mipsisa64r6-linux-gnu mipsisa64r6el-linux-gnu  
        mips64el-linux-gnuabi64 mips64-linux-gnuabi64  
        mipsisa64-linux-gnuabi64 mipsisa64el-linux-gnuabi64 
        mipsisa64r2el-linux-gnuabi64 mipsisa64r2-linux-gnuabi64
        mipsisa64r6el-linux-gnuabi64 mipsisa64r6-linux-gnuabi64
and                                                    
        x86_64-linux-gnu i686-linux-gnu                
        aarch64-linux-gnu arm-linux-gnueabi arm-none-eabi

YunQiang Su (5):
  MIPS: gas: alter 64 or 32 for mipsisa triples if march is implicit
  MIPS: default r6 if vendor is img
  MIPS: fix r6 testsuites
  MIPS: fix -gnuabi64 testsuite
  MIPS: fix some ld testcases with compiler

 bfd/config.bfd                                |   2 +-
 binutils/testsuite/binutils-all/mips/mips.exp |  94 ++-
 binutils/testsuite/binutils-all/objcopy.exp   |   2 +-
 binutils/testsuite/binutils-all/readelf.r-64  |   2 +
 binutils/testsuite/binutils-all/readelf.s-64  |  10 +-
 .../testsuite/binutils-all/remove-relocs-01.d |   2 +-
 .../testsuite/binutils-all/remove-relocs-04.d |   2 +-
 .../testsuite/binutils-all/remove-relocs-05.d |   2 +-
 .../testsuite/binutils-all/remove-relocs-06.d |   2 +-
 binutils/testsuite/binutils-all/strip-3.d     |   2 +-
 gas/config/tc-mips.c                          | 280 ++++---
 gas/configure                                 |   8 +-
 gas/configure.ac                              |   8 +-
 gas/testsuite/gas/all/assign.d                |   4 +
 gas/testsuite/gas/all/fwdexp.d                |   2 +
 gas/testsuite/gas/all/none.d                  |   2 +
 gas/testsuite/gas/elf/missing-build-notes.d   |   8 +
 gas/testsuite/gas/macros/irp.d                |  12 +
 gas/testsuite/gas/macros/repeat.d             |  72 ++
 gas/testsuite/gas/macros/rept.d               |   6 +
 gas/testsuite/gas/macros/test2.d              |   6 +
 gas/testsuite/gas/macros/vararg.d             |  12 +
 gas/testsuite/gas/mips/align2-el.d            |  10 +-
 gas/testsuite/gas/mips/align2.d               |  10 +-
 gas/testsuite/gas/mips/attr-gnu-abi-fp-1.d    |   2 +-
 gas/testsuite/gas/mips/attr-gnu-abi-fp-5.d    |  21 +
 gas/testsuite/gas/mips/attr-gnu-abi-fp-5.s    |   1 +
 gas/testsuite/gas/mips/attr-gnu-abi-fp-6.d    |  21 +
 gas/testsuite/gas/mips/attr-gnu-abi-fp-6.s    |   1 +
 gas/testsuite/gas/mips/attr-gnu-abi-msa-1.d   |   2 +-
 .../gas/mips/branch-absolute-addend.d         |   2 +-
 gas/testsuite/gas/mips/branch-absolute.d      |   2 +-
 .../gas/mips/branch-addend-micromips.d        |   2 +-
 gas/testsuite/gas/mips/branch-addend.d        |   2 +-
 gas/testsuite/gas/mips/branch-extern-2.d      |   2 +-
 gas/testsuite/gas/mips/branch-extern-4.d      |   2 +-
 gas/testsuite/gas/mips/branch-local-1.d       |   2 +-
 gas/testsuite/gas/mips/branch-local-2.d       |   2 +-
 gas/testsuite/gas/mips/branch-local-3.d       |   2 +-
 gas/testsuite/gas/mips/branch-local-4.d       |   2 +-
 gas/testsuite/gas/mips/branch-local-5.d       |   2 +-
 gas/testsuite/gas/mips/branch-local-6.d       |   2 +-
 gas/testsuite/gas/mips/branch-local-7.d       |   2 +-
 .../gas/mips/branch-local-ignore-2.d          |   2 +-
 .../gas/mips/branch-local-ignore-3.d          |   2 +-
 .../gas/mips/branch-local-ignore-5.d          |   2 +-
 .../gas/mips/branch-local-ignore-6.d          |   2 +-
 gas/testsuite/gas/mips/branch-section-1.d     |   2 +-
 gas/testsuite/gas/mips/branch-section-2.d     |   2 +-
 gas/testsuite/gas/mips/branch-section-3.d     |   2 +-
 gas/testsuite/gas/mips/branch-section-4.d     |   2 +-
 gas/testsuite/gas/mips/branch-weak-1.d        |   2 +-
 gas/testsuite/gas/mips/branch-weak-2.d        |   2 +-
 gas/testsuite/gas/mips/branch-weak-3.d        |   2 +-
 gas/testsuite/gas/mips/branch-weak-4.d        |   2 +-
 gas/testsuite/gas/mips/branch-weak-5.d        |   2 +-
 gas/testsuite/gas/mips/branch-weak-6.d        |   2 +-
 gas/testsuite/gas/mips/branch-weak-7.d        |   2 +-
 gas/testsuite/gas/mips/comdat-reloc-r6.d      |  34 +
 gas/testsuite/gas/mips/comdat-reloc.d         |   2 +-
 gas/testsuite/gas/mips/compact-eh-eb-1.d      |  13 +-
 gas/testsuite/gas/mips/compact-eh-eb-2.d      |  25 +-
 gas/testsuite/gas/mips/compact-eh-eb-3.d      |  17 +-
 gas/testsuite/gas/mips/compact-eh-eb-4.d      |  17 +-
 gas/testsuite/gas/mips/compact-eh-eb-5.d      |  25 +-
 gas/testsuite/gas/mips/compact-eh-eb-6.d      |  17 +-
 gas/testsuite/gas/mips/compact-eh-eb-7.d      |  25 +-
 gas/testsuite/gas/mips/compact-eh-el-1.d      |  13 +-
 gas/testsuite/gas/mips/compact-eh-el-2.d      |  25 +-
 gas/testsuite/gas/mips/compact-eh-el-3.d      |  17 +-
 gas/testsuite/gas/mips/compact-eh-el-4.d      |  17 +-
 gas/testsuite/gas/mips/compact-eh-el-5.d      |  25 +-
 gas/testsuite/gas/mips/compact-eh-el-6.d      |  17 +-
 gas/testsuite/gas/mips/compact-eh-el-7.d      |  25 +-
 gas/testsuite/gas/mips/elf-rel.d              |  12 +-
 gas/testsuite/gas/mips/elf-rel.s              |  36 +-
 gas/testsuite/gas/mips/elf-rel6.d             |   2 +-
 gas/testsuite/gas/mips/elf_ase_micromips-2.d  |   2 +-
 gas/testsuite/gas/mips/elf_ase_micromips.d    |   2 +-
 gas/testsuite/gas/mips/elf_ase_mips16-2.d     |   2 +-
 gas/testsuite/gas/mips/elf_ase_mips16.d       |   2 +-
 gas/testsuite/gas/mips/elfel-rel.d            |  12 +-
 gas/testsuite/gas/mips/fix-rm7000-2.d         |   2 +-
 gas/testsuite/gas/mips/insn-isa-mode.d        |   2 +-
 gas/testsuite/gas/mips/insn-opts.d            |   1 +
 gas/testsuite/gas/mips/jalx-addend.d          |   2 +-
 gas/testsuite/gas/mips/jalx-imm.d             |   2 +-
 gas/testsuite/gas/mips/jalx-local.d           |   2 +-
 gas/testsuite/gas/mips/llpscp-64.d            |   1 +
 gas/testsuite/gas/mips/loongson-2f-2.d        |   2 +-
 gas/testsuite/gas/mips/loongson-2f-3.d        |   6 +-
 gas/testsuite/gas/mips/micromips-b16.d        |   2 +-
 .../mips/micromips-branch-absolute-addend.d   |   2 +-
 .../gas/mips/micromips-branch-absolute.d      |   2 +-
 .../gas/mips/micromips-warn-branch-delay-1.d  |   2 +-
 .../gas/mips/micromips-warn-branch-delay.d    |   2 +-
 .../gas/mips/micromips@fix-rm7000-2.d         |   2 +-
 gas/testsuite/gas/mips/mips-jalx-2.d          |   2 +-
 gas/testsuite/gas/mips/mips-jalx.d            |   4 +-
 gas/testsuite/gas/mips/mips.exp               |  74 +-
 .../gas/mips/mips16-absolute-reloc-0.d        |   2 +-
 .../gas/mips/mips16-absolute-reloc-2.d        |   2 +-
 .../gas/mips/mips16-branch-absolute-1.d       |   2 +-
 .../gas/mips/mips16-branch-absolute-2.d       |   2 +-
 .../mips/mips16-branch-absolute-addend-1.d    |   2 +-
 .../gas/mips/mips16-branch-absolute-addend.d  |   2 +-
 .../gas/mips/mips16-branch-absolute.d         |   2 +-
 .../gas/mips/mips16-branch-addend-0.d         |   2 +-
 .../gas/mips/mips16-branch-addend-1.d         |   2 +-
 .../gas/mips/mips16-branch-addend-2.d         |   2 +-
 .../gas/mips/mips16-branch-addend-3.d         |   2 +-
 .../gas/mips/mips16-branch-addend-4.d         |   2 +-
 .../gas/mips/mips16-branch-addend-5.d         |   2 +-
 .../gas/mips/mips16-branch-reloc-0.d          |   2 +-
 .../gas/mips/mips16-branch-reloc-1.d          |   2 +-
 .../gas/mips/mips16-branch-reloc-2.d          |   2 +-
 .../gas/mips/mips16-branch-reloc-3.d          |   2 +-
 .../gas/mips/mips16-branch-reloc-4.d          |   2 +-
 .../gas/mips/mips16-branch-reloc-5.d          |   2 +-
 .../gas/mips/mips16-branch-unextended-1.d     |   2 +-
 .../gas/mips/mips16-branch-unextended-2.d     |   2 +-
 gas/testsuite/gas/mips/mips16-dwarf2.d        |   2 +-
 gas/testsuite/gas/mips/mips16-e.d             |   2 +-
 gas/testsuite/gas/mips/mips16-extend.d        |   2 +-
 gas/testsuite/gas/mips/mips16-f.d             |   2 +-
 gas/testsuite/gas/mips/mips16-hilo.d          |   2 +-
 .../gas/mips/mips16-insn-length-noargs.d      |   2 +-
 gas/testsuite/gas/mips/mips16-jal-e.d         |   2 +-
 gas/testsuite/gas/mips/mips16-jal-t.d         |   2 +-
 gas/testsuite/gas/mips/mips16-pcrel-relax-0.d |   2 +-
 gas/testsuite/gas/mips/mips16-pcrel-relax-1.d |   2 +-
 gas/testsuite/gas/mips/mips16-pcrel-relax-2.d |   2 +-
 gas/testsuite/gas/mips/mips16-pcrel-relax-3.d |   2 +-
 gas/testsuite/gas/mips/mips16-vis-1.d         |   1 +
 gas/testsuite/gas/mips/mips64-dsp.d           |   2 +-
 gas/testsuite/gas/mips/mipsel16-e.d           |   2 +-
 gas/testsuite/gas/mips/mipsel16-f.d           |   2 +-
 gas/testsuite/gas/mips/module-mfp32.d         |   2 +-
 gas/testsuite/gas/mips/module-mfp64r6-noodd.d |  21 +
 gas/testsuite/gas/mips/module-mfp64r6.d       |  21 +
 .../gas/mips/module-msoft-float-r6.d          |  20 +
 .../gas/mips/module-msoft-float-r6.s          |   3 +
 gas/testsuite/gas/mips/module-msoft-float.d   |   2 +-
 gas/testsuite/gas/mips/nan-2008-3.d           |   1 +
 gas/testsuite/gas/mips/nan-legacy-1.d         |   1 +
 gas/testsuite/gas/mips/nan-legacy-2.d         |   2 +-
 gas/testsuite/gas/mips/nan-legacy-3.d         |   1 +
 gas/testsuite/gas/mips/nan-legacy-4.d         |   2 +-
 gas/testsuite/gas/mips/nan-legacy-5.d         |   1 +
 gas/testsuite/gas/mips/option-pic-1.d         |   2 +-
 gas/testsuite/gas/mips/option-pic-relax-0.d   |   2 +-
 gas/testsuite/gas/mips/option-pic-relax-1.d   |   2 +-
 gas/testsuite/gas/mips/option-pic-relax-3.d   |   4 +-
 gas/testsuite/gas/mips/option-pic-relax-3a.d  |   2 +-
 gas/testsuite/gas/mips/option-pic-relax-4.d   |   2 +-
 gas/testsuite/gas/mips/option-pic-relax-5.d   |   2 +-
 gas/testsuite/gas/mips/org-1.d                |   2 +-
 gas/testsuite/gas/mips/org-10.d               |   2 +-
 gas/testsuite/gas/mips/org-11.d               |   2 +-
 gas/testsuite/gas/mips/org-12.d               |   1 +
 gas/testsuite/gas/mips/org-2.d                |   2 +-
 gas/testsuite/gas/mips/org-3.d                |   1 +
 gas/testsuite/gas/mips/org-4.d                |   2 +-
 gas/testsuite/gas/mips/org-5.d                |   2 +-
 gas/testsuite/gas/mips/org-6.d                |   1 +
 gas/testsuite/gas/mips/org-7.d                |   2 +-
 gas/testsuite/gas/mips/org-8.d                |   2 +-
 gas/testsuite/gas/mips/org-9.d                |   1 +
 gas/testsuite/gas/mips/pcrel-1.d              |   4 +-
 gas/testsuite/gas/mips/pcrel-reloc-1.d        |   2 +-
 gas/testsuite/gas/mips/pcrel-reloc-2.d        |   2 +-
 gas/testsuite/gas/mips/pcrel-reloc-3.d        |   2 +-
 gas/testsuite/gas/mips/pcrel-reloc-4.d        |   2 +-
 gas/testsuite/gas/mips/pcrel-reloc-5.d        |   2 +-
 gas/testsuite/gas/mips/pcrel-reloc-6.d        |   2 +-
 gas/testsuite/gas/mips/set-arch.d             | 722 +++++++++---------
 gas/testsuite/gas/mips/tmips16-e.d            |   2 +-
 gas/testsuite/gas/mips/tmips16-f.d            |   2 +-
 gas/testsuite/gas/mips/tmipsel16-e.d          |   2 +-
 gas/testsuite/gas/mips/tmipsel16-f.d          |   2 +-
 .../gas/mips/unaligned-branch-r6-1.s          |   1 +
 .../gas/mips/unaligned-branch-r6-3.s          |   1 +
 .../gas/mips/unaligned-branch-r6-5.d          |   2 +-
 .../gas/mips/unaligned-jump-mips16-3.d        |   2 +-
 ld/testsuite/config/default.exp               |  20 +-
 ld/testsuite/ld-elf/eh5.d                     |  50 +-
 ld/testsuite/ld-elf/group.ld                  |   2 +-
 ld/testsuite/ld-elf/indirect.exp              |   8 +-
 ld/testsuite/ld-elf/orphan-region.ld          |   2 +-
 ld/testsuite/ld-elf/orphan.ld                 |   2 +-
 ld/testsuite/ld-elf/pr23658-2.rd              |   2 +-
 ld/testsuite/ld-elf/shared.exp                |  12 +-
 ld/testsuite/ld-elfvers/vers.exp              |  12 +-
 ld/testsuite/ld-gc/gc.exp                     |   5 +
 ld/testsuite/ld-mips-elf/attr-gnu-4-01.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-4-11.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-4-40.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-4-41.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-8-00.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-8-01.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-8-02.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-8-10.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-8-11.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-8-20.d      |   1 +
 ld/testsuite/ld-mips-elf/attr-gnu-8-22.d      |   1 +
 ld/testsuite/ld-mips-elf/compact-eh6.d        |   6 +-
 ld/testsuite/ld-mips-elf/emit-relocs-1.d      |   2 +-
 ld/testsuite/ld-mips-elf/got-dump-1.d         |  22 +-
 ld/testsuite/ld-mips-elf/got-page-1.ld        |   2 +-
 ld/testsuite/ld-mips-elf/got-page-3.d         |  11 +-
 ld/testsuite/ld-mips-elf/gp-disp-sym.s        |   2 +-
 ld/testsuite/ld-mips-elf/jaloverflow-2.d      |   2 +-
 ld/testsuite/ld-mips-elf/jalr3.dd             |   2 +-
 ld/testsuite/ld-mips-elf/jalx-1.d             |  12 +-
 ld/testsuite/ld-mips-elf/mips-elf.exp         | 344 +++++----
 ld/testsuite/ld-mips-elf/mips16-1.d           |   4 +-
 .../ld-mips-elf/mips16-and-micromips.d        |   4 +-
 .../ld-mips-elf/mode-change-error-1.d         |   4 +-
 ld/testsuite/ld-mips-elf/n64-plt-1.dd         |   2 +-
 ld/testsuite/ld-mips-elf/n64-plt-4.dd         |   2 +-
 ld/testsuite/ld-mips-elf/nan-legacy.d         |   1 +
 ld/testsuite/ld-mips-elf/nan-mixed-1.d        |   1 +
 ld/testsuite/ld-mips-elf/nan-mixed-2.d        |   1 +
 ld/testsuite/ld-mips-elf/pic-and-nonpic-2.d   |   2 +-
 ld/testsuite/ld-mips-elf/reloc-3.d            |   2 +-
 ld/testsuite/ld-mips-elf/reloc-estimate-1.d   |   4 +-
 ld/testsuite/ld-plugin/lto.exp                |  11 +-
 ld/testsuite/ld-plugin/plugin.exp             |  15 +
 ld/testsuite/ld-scripts/overlay-size.t        |   2 +-
 ld/testsuite/ld-selective/selective.exp       |   2 +-
 ld/testsuite/ld-shared/shared.exp             |   4 +-
 ld/testsuite/ld-undefined/undefined.exp       |   4 +
 232 files changed, 1676 insertions(+), 1018 deletions(-)
 create mode 100644 gas/testsuite/gas/mips/attr-gnu-abi-fp-5.d
 create mode 100644 gas/testsuite/gas/mips/attr-gnu-abi-fp-5.s
 create mode 100644 gas/testsuite/gas/mips/attr-gnu-abi-fp-6.d
 create mode 100644 gas/testsuite/gas/mips/attr-gnu-abi-fp-6.s
 create mode 100644 gas/testsuite/gas/mips/comdat-reloc-r6.d
 create mode 100644 gas/testsuite/gas/mips/module-mfp64r6-noodd.d
 create mode 100644 gas/testsuite/gas/mips/module-mfp64r6.d
 create mode 100644 gas/testsuite/gas/mips/module-msoft-float-r6.d
 create mode 100644 gas/testsuite/gas/mips/module-msoft-float-r6.s
  

On Tue, May 16, 2023 at 10:54:21AM +0800, YunQiang Su wrote:
> Run testsuite with targets:                            
>         mipsisa32-linux-gnu mipsisa32r2-linux-gnu mips-linux-gnu                                                       
>         mipsisa32el-linux-gnu mipsisa32r2el-linux-gnu mipsel-linux-gnu
>         mipsisa32r6-linux-gnu mipsisa32r6el-linux-gnu  
>         mips-img-linux-gnu mipsel-img-linux-gnu        
>         mips-img-elf mipsel-img-elf                    
>         mips-mti-elf mipsel-mti-elf                    
>         mips64-linux-gnu mips64el-linux-gnu            
>         mipsisa64-linux-gnu mipsisa64el-linux-gnu      
>         mipsisa64r2-linux-gnu mipsisa64r2el-linux-gnu  
>         mipsisa64r6-linux-gnu mipsisa64r6el-linux-gnu  
>         mips64el-linux-gnuabi64 mips64-linux-gnuabi64  
>         mipsisa64-linux-gnuabi64 mipsisa64el-linux-gnuabi64 
>         mipsisa64r2el-linux-gnuabi64 mipsisa64r2-linux-gnuabi64
>         mipsisa64r6el-linux-gnuabi64 mipsisa64r6-linux-gnuabi64

I applied your patchset and ran my usual regression tests over some
165 different binutils targets.  mipsisa32r2el-elf, mips-sgi-irix6,
and mipstx39-elf show some new failures.  This doesn't mean I
disapprove the patch, in fact I like it!  Please don't think you must
post another version of the patchset to fix these problems.  It might
be better to solve them with an incremental patch, giving the mips
maintainers a chance to review this patchset first.

Most of the mipsisa32r2el-elf fails are like this:
failed with: <Assembler messages:
Fatal error: selected target format 'elf32-nlittlemips' unknown>
FAIL: MIPS RM7000 workarounds test 2 (micromips)

Similarly, mipstx39-elf fails with
Fatal error: selected target format 'elf32-nbigmips' unknown

This one (one of the two mips-sgi-irix6 fails I saw) also appear with
mipsisa32r2el-elf and mips-sgi-irix6:
mips-sgi-irix6  +FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing

regexp_diff match failure
regexp "^0000000c  0000070a R_MIPS_PC16       00000020   \.L1\^B1$"
line   "0000000c  00000d0a R_MIPS_PC16       00000020   .L1^B1"
regexp_diff match failure
regexp "^00000020  0000080a R_MIPS_PC16       00000018   \.L0\^B1$"
line   "00000020  00000e0a R_MIPS_PC16       00000018   .L0^B1"
FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing

So that one is caused by different symbol table ordering.
  

Alan Modra <amodra@gmail.com> 于2023年5月17日周三 07:23写道：
>
> On Tue, May 16, 2023 at 10:54:21AM +0800, YunQiang Su wrote:
> > Run testsuite with targets:
> >         mipsisa32-linux-gnu mipsisa32r2-linux-gnu mips-linux-gnu
> >         mipsisa32el-linux-gnu mipsisa32r2el-linux-gnu mipsel-linux-gnu
> >         mipsisa32r6-linux-gnu mipsisa32r6el-linux-gnu
> >         mips-img-linux-gnu mipsel-img-linux-gnu
> >         mips-img-elf mipsel-img-elf
> >         mips-mti-elf mipsel-mti-elf
> >         mips64-linux-gnu mips64el-linux-gnu
> >         mipsisa64-linux-gnu mipsisa64el-linux-gnu
> >         mipsisa64r2-linux-gnu mipsisa64r2el-linux-gnu
> >         mipsisa64r6-linux-gnu mipsisa64r6el-linux-gnu
> >         mips64el-linux-gnuabi64 mips64-linux-gnuabi64
> >         mipsisa64-linux-gnuabi64 mipsisa64el-linux-gnuabi64
> >         mipsisa64r2el-linux-gnuabi64 mipsisa64r2-linux-gnuabi64
> >         mipsisa64r6el-linux-gnuabi64 mipsisa64r6-linux-gnuabi64
>
> I applied your patchset and ran my usual regression tests over some
> 165 different binutils targets.  mipsisa32r2el-elf, mips-sgi-irix6,
> and mipstx39-elf show some new failures.  This doesn't mean I
> disapprove the patch, in fact I like it!  Please don't think you must
> post another version of the patchset to fix these problems.  It might
> be better to solve them with an incremental patch, giving the mips
> maintainers a chance to review this patchset first.
>

If there is no objection, I will commit this patchset and go on to solve
the problem Alan pointed out.

> Most of the mipsisa32r2el-elf fails are like this:
> failed with: <Assembler messages:
> Fatal error: selected target format 'elf32-nlittlemips' unknown>
> FAIL: MIPS RM7000 workarounds test 2 (micromips)
>
> Similarly, mipstx39-elf fails with
> Fatal error: selected target format 'elf32-nbigmips' unknown
>
> This one (one of the two mips-sgi-irix6 fails I saw) also appear with
> mipsisa32r2el-elf and mips-sgi-irix6:
> mips-sgi-irix6  +FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing
>
> regexp_diff match failure
> regexp "^0000000c  0000070a R_MIPS_PC16       00000020   \.L1\^B1$"
> line   "0000000c  00000d0a R_MIPS_PC16       00000020   .L1^B1"
> regexp_diff match failure
> regexp "^00000020  0000080a R_MIPS_PC16       00000018   \.L0\^B1$"
> line   "00000020  00000e0a R_MIPS_PC16       00000018   .L0^B1"
> FAIL: MIPS ELF o32 PIC comdat GOT16/LO16 relocation pairing
>
> So that one is caused by different symbol table ordering.
>
> --
> Alan Modra
> Australia Development Lab, IBM
  

On Wed, 31 May 2023, YunQiang Su wrote:

> > I applied your patchset and ran my usual regression tests over some
> > 165 different binutils targets.  mipsisa32r2el-elf, mips-sgi-irix6,
> > and mipstx39-elf show some new failures.  This doesn't mean I
> > disapprove the patch, in fact I like it!  Please don't think you must
> > post another version of the patchset to fix these problems.  It might
> > be better to solve them with an incremental patch, giving the mips
> > maintainers a chance to review this patchset first.
> 
> If there is no objection, I will commit this patchset and go on to solve
> the problem Alan pointed out.

 Well, it does have to be reviewed, especially as there are changes beyond 
just testsuite fixes.

  Maciej
  

On Wed, 31 May 2023, Maciej W. Rozycki wrote:

> > > I applied your patchset and ran my usual regression tests over some
> > > 165 different binutils targets.  mipsisa32r2el-elf, mips-sgi-irix6,
> > > and mipstx39-elf show some new failures.  This doesn't mean I
> > > disapprove the patch, in fact I like it!  Please don't think you must
> > > post another version of the patchset to fix these problems.  It might
> > > be better to solve them with an incremental patch, giving the mips
> > > maintainers a chance to review this patchset first.
> > 
> > If there is no objection, I will commit this patchset and go on to solve
> > the problem Alan pointed out.
> 
>  Well, it does have to be reviewed, especially as there are changes beyond 
> just testsuite fixes.

 I have now reverted these changes, as they were committed unapproved and 
I haven't heard back from you in response to my question sent off list.  

 If you want this patch set in, then please repost it, get reviewed *and*
approved, and only then you can commit it.  Thank you.

  Maciej