mbox series

[V2,0/5] SFrame: add support for .cfi_b_key_frame

Message ID 20221219211406.1443750-1-indu.bhagat@oracle.com
Headers
Series SFrame: add support for .cfi_b_key_frame |

Message

Indu Bhagat Dec. 19, 2022, 9:14 p.m. UTC 
  [Changes from V1]
  - Rebased on latest trunk.
  - Fixed the testcase as we now emit "[s]" marker for both mangled RA in
  register and stack.
[End of changes in V1]

Thanks

----------------------

Hello,

This patchset adds support for handling the .cfi_b_key_frame assembler
directive to the SFrame format: SFrame format representation now allows to
encode which of the pauth A key / B key are used (for signing return
addresses on aarch64), and gas, readelf/objdump now allow for generation
and textual dump of this information.

Testing notes:

- Regression tested cross build of several targets on an x86_64 host and an
aarch64 host using a regression script that checks for failures in gas, ld,
binutils, libctf and libsframe.
- Regression tested native builds on x86_64 and aarch64.
- binutils/gdb try bot showed no new regressions.

Thanks,
Indu Bhagat (5):
  [1/5] sframe.h: add support for .cfi_b_key_frame
  [2/5] gas: sframe: add support for .cfi_b_key_frame
  [3/5] objdump/readelf: sframe: emit marker for SFrame FDE with B key
  [4/5] gas: sframe: testsuite: add testcase for .cfi_b_key_frame
  [5/5] sframe: doc: update documentation for pauth key in SFrame FDE

 gas/gen-sframe.c                              | 26 +++++++++++---
 gas/gen-sframe.h                              |  2 +-
 gas/sframe-opt.c                              |  3 ++
 .../cfi-sframe-aarch64-pac-ab-key-1.d         | 27 ++++++++++++++
 .../cfi-sframe-aarch64-pac-ab-key-1.s         | 36 +++++++++++++++++++
 gas/testsuite/gas/cfi-sframe/cfi-sframe.exp   |  1 +
 include/sframe.h                              | 25 +++++++++----
 libsframe/doc/sframe-spec.texi                |  8 ++++-
 libsframe/sframe-dump.c                       | 19 ++++++++++
 9 files changed, 135 insertions(+), 12 deletions(-)
 create mode 100644 gas/testsuite/gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.d
 create mode 100644 gas/testsuite/gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.s

Comments

Indu Bhagat Dec. 21, 2022, 6:19 p.m. UTC | #1 
PING.

This patch series has not been committed.  I earlier sent the series as 
"[COMMITTED, V2]" by mistake; so this needs an OK before I can commit it.

Thanks

On 12/19/22 13:14, Indu Bhagat wrote:
> [Changes from V1]
>    - Rebased on latest trunk.
>    - Fixed the testcase as we now emit "[s]" marker for both mangled RA in
>    register and stack.
> [End of changes in V1]
> 
> Thanks
> 
> ----------------------
> 
> Hello,
> 
> This patchset adds support for handling the .cfi_b_key_frame assembler
> directive to the SFrame format: SFrame format representation now allows to
> encode which of the pauth A key / B key are used (for signing return
> addresses on aarch64), and gas, readelf/objdump now allow for generation
> and textual dump of this information.
> 
> Testing notes:
> 
> - Regression tested cross build of several targets on an x86_64 host and an
> aarch64 host using a regression script that checks for failures in gas, ld,
> binutils, libctf and libsframe.
> - Regression tested native builds on x86_64 and aarch64.
> - binutils/gdb try bot showed no new regressions.
> 
> Thanks,
> Indu Bhagat (5):
>    [1/5] sframe.h: add support for .cfi_b_key_frame
>    [2/5] gas: sframe: add support for .cfi_b_key_frame
>    [3/5] objdump/readelf: sframe: emit marker for SFrame FDE with B key
>    [4/5] gas: sframe: testsuite: add testcase for .cfi_b_key_frame
>    [5/5] sframe: doc: update documentation for pauth key in SFrame FDE
> 
>   gas/gen-sframe.c                              | 26 +++++++++++---
>   gas/gen-sframe.h                              |  2 +-
>   gas/sframe-opt.c                              |  3 ++
>   .../cfi-sframe-aarch64-pac-ab-key-1.d         | 27 ++++++++++++++
>   .../cfi-sframe-aarch64-pac-ab-key-1.s         | 36 +++++++++++++++++++
>   gas/testsuite/gas/cfi-sframe/cfi-sframe.exp   |  1 +
>   include/sframe.h                              | 25 +++++++++----
>   libsframe/doc/sframe-spec.texi                |  8 ++++-
>   libsframe/sframe-dump.c                       | 19 ++++++++++
>   9 files changed, 135 insertions(+), 12 deletions(-)
>   create mode 100644 gas/testsuite/gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.d
>   create mode 100644 gas/testsuite/gas/cfi-sframe/cfi-sframe-aarch64-pac-ab-key-1.s
>
Nick Clifton Dec. 22, 2022, 8:40 a.m. UTC | #2 
Hi Indu,

> PING.
> 
> This patch series has not been committed.  I earlier sent the series as "[COMMITTED, V2]" by mistake; so this needs an OK before I can commit it.

Oops- sorry - patch series approved - please apply!

Cheers
   Nick