Message ID | 20230408134820.76050-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp884261vqo; Sat, 8 Apr 2023 06:49:05 -0700 (PDT) X-Google-Smtp-Source: AKy350br7Whxa2VzGXtUYbd4jE39pLyG7xZzVU9oOps3MFeHluxRfvB38mETGxIFhXle7Ivn9RW9 X-Received: by 2002:a17:902:d489:b0:1a1:bff4:49e9 with SMTP id c9-20020a170902d48900b001a1bff449e9mr2476770plg.23.1680961745335; Sat, 08 Apr 2023 06:49:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680961745; cv=none; d=google.com; s=arc-20160816; b=vFsNfjVN2QhcHBRd5nfaxebE0UoQctJqTdGnnY0jHmdHWDdEdmO1Fi2I7y3a9E25R/ P4fhY7MPccOC4QxnP8aRw9z2UgPp4LnOBnYAVxNkRvl3V3KLIxRUJJYczeI4X/rGjvc5 mgX1tcGjwBPjPc6zSZ4oo9IiJjH1flHntI4w5osgbE66CwGzvpevWPFqUjc1yW3fOzzI XeYKGiK8AUxxVbYvGj60NlbQsQimevK5HXzYIjmyJqFF84SCvYAMyMMcmF0R0QrrZkkO eOZvP0LXs3KoT34eUJJujzYiGWvT/1bxCD6eVKHb+VxZ3eFvTVlQJxjmE1yJsSnC/U7A FQXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=qgVpXoM81LvyjpE5bx1YbeTvMrqclg4wS/DDLvj8/Zk=; b=rh55aFuqpFWYmz0NQPGfGShvSbLmSGjSZbk9I5wagvumMK5hjB+hu6bq/KnYXgl8jS uC0YlAbULfGPf6Vg2NYTcBr3Zsi6NqTFO9rmERnvSxYG17VjfnxUKkbikT+H8+BhWnJw QeCKCrFnSFdUDTN/KerBXNtHkwNHhEupTcW6wriKuL6tCdsIkUga827qjTcxiZBUGbM8 trrIzb6GoC1toVdIoloA1DZWPDcNpF+BHfbStzHsmRpk958d7oAj7MsfAhm0bQwGPjCA L0k4G8IYPjdpOKfaY1TkVbifugi9h1ERHpFP81x49+keiBovdfqjX4esBcaCst9YZXhW sCSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b15-20020a63e70f000000b005184398f8d9si805393pgi.457.2023.04.08.06.48.52; Sat, 08 Apr 2023 06:49:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229540AbjDHNsc (ORCPT <rfc822;a1648639935@gmail.com> + 99 others); Sat, 8 Apr 2023 09:48:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjDHNs3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 8 Apr 2023 09:48:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94EA276AF; Sat, 8 Apr 2023 06:48:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3044D6142C; Sat, 8 Apr 2023 13:48:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13ABCC433EF; Sat, 8 Apr 2023 13:48:23 +0000 (UTC) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Taniya Das <tdas@codeaurora.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [PATCH 1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock Date: Sat, 8 Apr 2023 15:48:18 +0200 Message-Id: <20230408134820.76050-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762616143128919227?= X-GMAIL-MSGID: =?utf-8?q?1762616143128919227?= |
Series |
[1/3] dt-bindings: clock: qcom,gcc-sm8250: add missing bi_tcxo_ao clock
|
|
Commit Message
Krzysztof Kozlowski
April 8, 2023, 1:48 p.m. UTC
Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom:
sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to
the GCC clock controller, so update the bindings hoping this is really
needed. This fixes warnings like:
sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long
Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Comments
On 8.04.2023 15:48, Krzysztof Kozlowski wrote: > Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom: > sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to > the GCC clock controller, so update the bindings hoping this is really > needed. This fixes warnings like: The initial commit 3e5770921a88 ("clk: qcom: gcc: Add global clock controller driver for SM8250") already consumed it on the .c side, so the bindings were wrong.. > > sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long > > Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks") s/this/98394efb48f5 ("dt-bindings: clock: Add SM8250 GCC clock bindings") Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > index b752542ee20c..ead6665b9a45 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml > @@ -23,11 +23,13 @@ properties: > clocks: > items: > - description: Board XO source > + - description: Board active XO source > - description: Sleep clock source > > clock-names: > items: > - const: bi_tcxo > + - const: bi_tcxo_ao > - const: sleep_clk > > required: > @@ -47,8 +49,9 @@ examples: > compatible = "qcom,gcc-sm8250"; > reg = <0x00100000 0x1f0000>; > clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&rpmhcc RPMH_CXO_CLK_A>, > <&sleep_clk>; > - clock-names = "bi_tcxo", "sleep_clk"; > + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk"; > #clock-cells = <1>; > #reset-cells = <1>; > #power-domain-cells = <1>;
Quoting Krzysztof Kozlowski (2023-04-08 06:48:18) > Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom: > sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to > the GCC clock controller, so update the bindings hoping this is really > needed. This fixes warnings like: > > sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long > > Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Sat, 08 Apr 2023 15:48:18 +0200, Krzysztof Kozlowski wrote: > Without actual explanation commit 76bd127e6ca5 ("arm64: dts: qcom: > sm8250: add bi_tcxo_ao to gcc clocks") added bi_tcxo_ao clock input to > the GCC clock controller, so update the bindings hoping this is really > needed. This fixes warnings like: > > sm8250-xiaomi-elish-csot.dtb: clock-controller@100000: clock-names: ['bi_tcxo', 'bi_tcxo_ao', 'sleep_clk'] is too long > > Fixes: 76bd127e6ca5 ("arm64: dts: qcom: sm8250: add bi_tcxo_ao to gcc clocks") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml index b752542ee20c..ead6665b9a45 100644 --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8250.yaml @@ -23,11 +23,13 @@ properties: clocks: items: - description: Board XO source + - description: Board active XO source - description: Sleep clock source clock-names: items: - const: bi_tcxo + - const: bi_tcxo_ao - const: sleep_clk required: @@ -47,8 +49,9 @@ examples: compatible = "qcom,gcc-sm8250"; reg = <0x00100000 0x1f0000>; clocks = <&rpmhcc RPMH_CXO_CLK>, + <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>; - clock-names = "bi_tcxo", "sleep_clk"; + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk"; #clock-cells = <1>; #reset-cells = <1>; #power-domain-cells = <1>;