[v2] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

Message ID 20221024111902.1338095-1-heiko.thiery@gmail.com
State New
Headers
Series [v2] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc |

Commit Message

Heiko Thiery Oct. 24, 2022, 11:19 a.m. UTC
  The delay is not required and can be remove.

Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
v2:
 - add Fixes tag

 arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Shawn Guo Oct. 29, 2022, 12:23 p.m. UTC | #1
On Mon, Oct 24, 2022 at 01:19:03PM +0200, Heiko Thiery wrote:
> The delay is not required and can be remove.
> 
> Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)

It looks more like a clean-up than bug fix.

Shawn

> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v2:
>  - add Fixes tag
> 
>  arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> index a91c136797f6..21442e04a632 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> @@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
>  		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> -		off-on-delay-us = <20000>;
>  		enable-active-high;
>  	};
>  };
> -- 
> 2.30.2
>
  
Shawn Guo Oct. 29, 2022, 12:28 p.m. UTC | #2
On Sat, Oct 29, 2022 at 8:23 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Oct 24, 2022 at 01:19:03PM +0200, Heiko Thiery wrote:
> > The delay is not required and can be remove.
> >
> > Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
>
> It looks more like a clean-up than bug fix.

Never mind.  Just saw the discussion on v3.

Shawn
  

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
index a91c136797f6..21442e04a632 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
@@ -51,7 +51,6 @@  reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
-		off-on-delay-us = <20000>;
 		enable-active-high;
 	};
 };