diff mbox series

[1/5] arm64: dts: qcom: sc8280xp: label the Soundwire nodes

Message ID 20230405060906.143058-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series [1/5] arm64: dts: qcom: sc8280xp: label the Soundwire nodes |

Commit Message

Krzysztof Kozlowski April 5, 2023, 6:09 a.m. UTC 
  Use labels, instead of comments, for Soundwire controllers.  Naming them
is useful, because they are specialized and have also naming in
datasheet/programming guide.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Konrad Dybcio April 5, 2023, 3:46 p.m. UTC | #1 
On 5.04.2023 08:09, Krzysztof Kozlowski wrote:
> Use labels, instead of comments, for Soundwire controllers.  Naming them
> is useful, because they are specialized and have also naming in
> datasheet/programming guide.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index cd38320dafda..c195a57fd180 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -2497,7 +2497,6 @@ rxmacro: rxmacro@3200000 {
>  			status = "disabled";
>  		};
>  
> -		/* RX */
>  		swr1: soundwire-controller@3210000 {
>  			compatible = "qcom,soundwire-v1.6.0";
>  			reg = <0 0x03210000 0 0x2000>;
> @@ -2572,13 +2571,13 @@ wsamacro: codec@3240000 {
>  			status = "disabled";
>  		};
>  
> -		/* WSA */
>  		swr0: soundwire-controller@3250000 {
>  			reg = <0 0x03250000 0 0x2000>;
>  			compatible = "qcom,soundwire-v1.6.0";
>  			interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&wsamacro>;
>  			clock-names = "iface";
> +			label = "WSA";
>  
>  			qcom,din-ports = <2>;
>  			qcom,dout-ports = <6>;
> @@ -2600,7 +2599,6 @@ swr0: soundwire-controller@3250000 {
>  			status = "disabled";
>  		};
>  
> -		/* TX */
>  		swr2: soundwire-controller@3330000 {
>  			compatible = "qcom,soundwire-v1.6.0";
>  			reg = <0 0x03330000 0 0x2000>;
Bjorn Andersson April 7, 2023, 5:41 p.m. UTC | #2 
On Wed, 5 Apr 2023 08:09:02 +0200, Krzysztof Kozlowski wrote:
> Use labels, instead of comments, for Soundwire controllers.  Naming them
> is useful, because they are specialized and have also naming in
> datasheet/programming guide.
> 
> 

Applied, thanks!

[1/5] arm64: dts: qcom: sc8280xp: label the Soundwire nodes
      commit: f77256439ccb794ec02eb07dfc6f1f96972a8cff
[2/5] arm64: dts: qcom: sm8450: label the Soundwire nodes
      commit: add214009d0632bf3f28158f81e4d202d8c9aa0e
[3/5] arm64: dts: qcom: sc8280xp: simplify interrupts-extended
      commit: 465b99f3b4ca55f25124adff6d6ccac4371f1930
[4/5] arm64: dts: qcom: sm8250: simplify interrupts-extended
      commit: 563065020d9ae67999f3f3f3a6ec3508e17a4d88
[5/5] arm64: dts: qcom: sm8450: simplify interrupts-extended
      commit: d6573b4c202e75edd8b7ffbef6496613a1ef89df

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index cd38320dafda..c195a57fd180 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -2497,7 +2497,6 @@  rxmacro: rxmacro@3200000 {
 			status = "disabled";
 		};
 
-		/* RX */
 		swr1: soundwire-controller@3210000 {
 			compatible = "qcom,soundwire-v1.6.0";
 			reg = <0 0x03210000 0 0x2000>;
@@ -2572,13 +2571,13 @@  wsamacro: codec@3240000 {
 			status = "disabled";
 		};
 
-		/* WSA */
 		swr0: soundwire-controller@3250000 {
 			reg = <0 0x03250000 0 0x2000>;
 			compatible = "qcom,soundwire-v1.6.0";
 			interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&wsamacro>;
 			clock-names = "iface";
+			label = "WSA";
 
 			qcom,din-ports = <2>;
 			qcom,dout-ports = <6>;
@@ -2600,7 +2599,6 @@  swr0: soundwire-controller@3250000 {
 			status = "disabled";
 		};
 
-		/* TX */
 		swr2: soundwire-controller@3330000 {
 			compatible = "qcom,soundwire-v1.6.0";
 			reg = <0 0x03330000 0 0x2000>;