diff mbox series

[bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh

Message ID 1680834090-2322-1-git-send-email-yangtiezhu@loongson.cn
State New
Headers
Series [bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh |

Commit Message

Tiezhu Yang April 7, 2023, 2:21 a.m. UTC 
  After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
it in check-headers.sh too, otherwise we can see the following build
warning:

  diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304050029.38NdbQPf-lkp@intel.com/
Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

commit 1f265d2aea0d ("selftests/bpf: Remove not used headers") is in
bpf-next tree, so I prefer this patch can be applied to bpf-next tree.

 tools/perf/check-headers.sh | 1 -
 1 file changed, 1 deletion(-)

Comments

Jiri Olsa April 7, 2023, 10:27 a.m. UTC | #1 
On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
> After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
> tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
> it in check-headers.sh too, otherwise we can see the following build
> warning:
> 
>   diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304050029.38NdbQPf-lkp@intel.com/
> Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

not sure this should go through Arnaldo's tree instead,
either way is fine with me

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
> 
> commit 1f265d2aea0d ("selftests/bpf: Remove not used headers") is in
> bpf-next tree, so I prefer this patch can be applied to bpf-next tree.
> 
>  tools/perf/check-headers.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index eacca9a..e4a8b53 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -52,7 +52,6 @@ arch/x86/include/uapi/asm/vmx.h
>  arch/powerpc/include/uapi/asm/kvm.h
>  arch/s390/include/uapi/asm/kvm.h
>  arch/s390/include/uapi/asm/kvm_perf.h
> -arch/s390/include/uapi/asm/ptrace.h
>  arch/s390/include/uapi/asm/sie.h
>  arch/arm/include/uapi/asm/kvm.h
>  arch/arm64/include/uapi/asm/kvm.h
> -- 
> 2.1.0
>
Daniel Borkmann April 11, 2023, 5:35 p.m. UTC | #2 
On 4/7/23 12:27 PM, Jiri Olsa wrote:
> On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
>> After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
>> tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
>> it in check-headers.sh too, otherwise we can see the following build
>> warning:
>>
>>    diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Link: https://lore.kernel.org/oe-kbuild-all/202304050029.38NdbQPf-lkp@intel.com/
>> Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> 
> not sure this should go through Arnaldo's tree instead,
> either way is fine with me

Agree, perf tree is better given the script is located there, so:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Arnaldo Carvalho de Melo April 12, 2023, 1:33 p.m. UTC | #3 
Em Tue, Apr 11, 2023 at 07:35:02PM +0200, Daniel Borkmann escreveu:
> On 4/7/23 12:27 PM, Jiri Olsa wrote:
> > On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
> > > After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
> > > tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
> > > it in check-headers.sh too, otherwise we can see the following build
> > > warning:
> > > 
> > >    diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Link: https://lore.kernel.org/oe-kbuild-all/202304050029.38NdbQPf-lkp@intel.com/
> > > Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
> > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > 
> > not sure this should go through Arnaldo's tree instead,
> > either way is fine with me
> 
> Agree, perf tree is better given the script is located there, so:
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Thanks, applied.

- Arnaldo
diff mbox series

Patch

diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index eacca9a..e4a8b53 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -52,7 +52,6 @@  arch/x86/include/uapi/asm/vmx.h
 arch/powerpc/include/uapi/asm/kvm.h
 arch/s390/include/uapi/asm/kvm.h
 arch/s390/include/uapi/asm/kvm_perf.h
-arch/s390/include/uapi/asm/ptrace.h
 arch/s390/include/uapi/asm/sie.h
 arch/arm/include/uapi/asm/kvm.h
 arch/arm64/include/uapi/asm/kvm.h