diff mbox series

memory: mtk-smi: mt8365: Add SMI Support

Message ID 20230407-smi-driver-v1-1-036d6d8e8993@baylibre.com
State New
Headers
Series memory: mtk-smi: mt8365: Add SMI Support |

Commit Message

Alexandre Mergnat April 7, 2023, 8:39 a.m. UTC 
  Add MT8365 SMI common support.

Reviewed-by: Yong Wu <yong.wu@mediatek.com>
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
This serie add MT8365 SMI common driver support only because, to be
bisectable and avoid issue, this driver change and the related change in
the DTS should be applied in the right order (driver first).

Here the related DTS change: [1]

Regards,
Alexandre

[1]: https://lore.kernel.org/all/20230207-iommu-support-v2-7-60d5fa00e4e5@baylibre.com/
---
 drivers/memory/mtk-smi.c | 6 ++++++
 1 file changed, 6 insertions(+)


---
base-commit: ea2dcf9394947d5d8e24cb9d52144923f6645632
change-id: 20230407-smi-driver-782270b6da2e

Best regards,

Comments

Krzysztof Kozlowski April 7, 2023, 8:41 a.m. UTC | #1 
On 07/04/2023 10:39, Alexandre Mergnat wrote:
> Add MT8365 SMI common support.
> 
> Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
> This serie add MT8365 SMI common driver support only because, to be
> bisectable and avoid issue, this driver change and the related change in
> the DTS should be applied in the right order (driver first).
> 
> Here the related DTS change: [1]

1. Where are the bindings? They always come with the driver.
2. Where is the changelog? What happened with requested changes? How a
review tag can appear on v1?


Best regards,
Krzysztof
Alexandre Mergnat April 7, 2023, 9:02 a.m. UTC | #2 
Le ven. 7 avr. 2023 à 10:41, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> a écrit :
>
> On 07/04/2023 10:39, Alexandre Mergnat wrote:
> > Add MT8365 SMI common support.
> >
> > Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> > ---
> > This serie add MT8365 SMI common driver support only because, to be
> > bisectable and avoid issue, this driver change and the related change in
> > the DTS should be applied in the right order (driver first).
> >
> > Here the related DTS change: [1]
>
> 1. Where are the bindings? They always come with the driver.
> 2. Where is the changelog? What happened with requested changes? How a
> review tag can appear on v1?

Thanks for the fast feedback, I fix that right now.

Regards,
Alexandre
diff mbox series

Patch

diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 5a9754442bc7..6523cb510518 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -713,6 +713,11 @@  static const struct mtk_smi_common_plat mtk_smi_sub_common_mt8195 = {
 	.has_gals = true,
 };
 
+static const struct mtk_smi_common_plat mtk_smi_common_mt8365 = {
+	.type     = MTK_SMI_GEN2,
+	.bus_sel  = F_MMU1_LARB(2) | F_MMU1_LARB(4),
+};
+
 static const struct of_device_id mtk_smi_common_of_ids[] = {
 	{.compatible = "mediatek,mt2701-smi-common", .data = &mtk_smi_common_gen1},
 	{.compatible = "mediatek,mt2712-smi-common", .data = &mtk_smi_common_gen2},
@@ -728,6 +733,7 @@  static const struct of_device_id mtk_smi_common_of_ids[] = {
 	{.compatible = "mediatek,mt8195-smi-common-vdo", .data = &mtk_smi_common_mt8195_vdo},
 	{.compatible = "mediatek,mt8195-smi-common-vpp", .data = &mtk_smi_common_mt8195_vpp},
 	{.compatible = "mediatek,mt8195-smi-sub-common", .data = &mtk_smi_sub_common_mt8195},
+	{.compatible = "mediatek,mt8365-smi-common", .data = &mtk_smi_common_mt8365},
 	{}
 };