diff mbox series

fuse: remove unnecessary goto

Message ID 20230406195615.80078-1-frank.li@vivo.com
State New
Headers
Series fuse: remove unnecessary goto |

Commit Message

李扬韬 April 6, 2023, 7:56 p.m. UTC 
  In this case, the error code can be returned directly.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/fuse/inode.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Nitesh Shetty April 7, 2023, 8:26 a.m. UTC | #1 
On 23/04/07 03:56AM, Yangtao Li wrote:
>In this case, the error code can be returned directly.
>
>Signed-off-by: Yangtao Li <frank.li@vivo.com>
>---
> fs/fuse/inode.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
>index d66070af145d..56efcf160513 100644
>--- a/fs/fuse/inode.c
>+++ b/fs/fuse/inode.c
>@@ -1921,10 +1921,8 @@ static int fuse_sysfs_init(void)
> 	int err;
>
> 	fuse_kobj = kobject_create_and_add("fuse", fs_kobj);
>-	if (!fuse_kobj) {
>-		err = -ENOMEM;
>-		goto out_err;
>-	}
>+	if (!fuse_kobj)
>+		return -ENOMEM;
>
> 	err = sysfs_create_mount_point(fuse_kobj, "connections");
> 	if (err)
>@@ -1934,7 +1932,6 @@ static int fuse_sysfs_init(void)
>
>  out_fuse_unregister:
> 	kobject_put(fuse_kobj);
>- out_err:
> 	return err;
> }
>
>-- 
>2.35.1
>
Reviewed by: Nitesh Shetty <nj.shetty@samsung.com>
diff mbox series

Patch

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index d66070af145d..56efcf160513 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1921,10 +1921,8 @@  static int fuse_sysfs_init(void)
 	int err;
 
 	fuse_kobj = kobject_create_and_add("fuse", fs_kobj);
-	if (!fuse_kobj) {
-		err = -ENOMEM;
-		goto out_err;
-	}
+	if (!fuse_kobj)
+		return -ENOMEM;
 
 	err = sysfs_create_mount_point(fuse_kobj, "connections");
 	if (err)
@@ -1934,7 +1932,6 @@  static int fuse_sysfs_init(void)
 
  out_fuse_unregister:
 	kobject_put(fuse_kobj);
- out_err:
 	return err;
 }