| Message ID | 20230406150633.83351-2-nikita@trvn.ru |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1108716vqo;
Thu, 6 Apr 2023 08:22:36 -0700 (PDT)
X-Google-Smtp-Source:
AKy350ZR3BIbOqXEVhm1wM+nBv8e2Bw0ekJZz2D/BJSEQ0K2mC3cEC8AdRj2mMvBn2KxlnS0f7r2
X-Received: by 2002:a17:902:ea0e:b0:1a2:7d:17ea with SMTP id
s14-20020a170902ea0e00b001a2007d17eamr11745579plg.56.1680794555849;
Thu, 06 Apr 2023 08:22:35 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1680794555; cv=none;
d=google.com; s=arc-20160816;
b=j2twgfvoFZaWxlXr9FIkfJpRJQ7QmVLQWaLC9DiOfpMKXFSUL+i+cTqIVeUA/m4Uir
wz1aOBRyJYKr1GsTqkh6kJhoUtqtdRjSQ9mbQSPO0E/jNydmodn6/3wuf2Ubh9ZtWZSQ
ZSb9iOAQXmELsVFAzCJEAn0Js7LTSqVaS7BXjgUL0eK8fEKu5AlTVyB8lM9bsYI59nZN
OER2dRc7bQ2HdR6A91VG6qkdi8IK8utPL7RKsLw/5sV1T840kvQLWo/YbZg3nzhSj774
D2jj9BQMiYMEKSD+ZlsmBEgCWpah45aYFcNGe9sdyN+TzP4yQr1cW6EPipXjR88lV0s/
WOSQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=NN72bZpDjzARU4DKFr24xS5v5SfaOVUJsDMPDamkaYw=;
b=Enb1gYGGqtmMJq7rNtXHvntgTrwr0lqbSoVcDF95l+F9W6uZ1j2ac3As0S/Fisc5V7
aS+4Ls9+XtdFSj6xhKdhn2jFVahIYnb4ueShHjHfG7uS8oxrc683DZSRugABmU3OAiR0
whO6kHaKJvs/geDZw+A8/03rVDYF0gWvdisODn9eHLKOxlrg0B+BFXinpy7zLjqm830m
HE2YVD5bp3uAMGVT/wx3o/Q7+5FKY9YC0fAS2b1F842OjXUMyLsWG8EsNGfiR1NOMA9G
wboUpvnL6EHFuSVx5iuEKJ9eNGxsk93JlB+Z+XfZfL5SUf8j7amUAXDJ0TLu6GUzLgaJ
nYOQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@trvn.ru header.s=mail header.b=VrFxFnsO;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=trvn.ru
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ld5-20020a170902fac500b001a1a22dc9d9si1852961plb.169.2023.04.06.08.22.23;
Thu, 06 Apr 2023 08:22:35 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@trvn.ru header.s=mail header.b=VrFxFnsO;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=trvn.ru
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S239626AbjDFPHY (ORCPT <rfc822;lkml4gm@gmail.com> + 99 others);
Thu, 6 Apr 2023 11:07:24 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57706 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S239601AbjDFPHU (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 6 Apr 2023 11:07:20 -0400
Received: from box.trvn.ru (box.trvn.ru [194.87.146.52])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64D89AD37;
Thu, 6 Apr 2023 08:06:58 -0700 (PDT)
Received: from authenticated-user (box.trvn.ru [194.87.146.52])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(No client certificate requested)
by box.trvn.ru (Postfix) with ESMTPSA id 97DC241848;
Thu, 6 Apr 2023 20:06:54 +0500 (+05)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=trvn.ru; s=mail;
t=1680793615; bh=N6oObUDYJcJKRmHqEIXrt+Eeic0D8f7CSqwLjgqLK6o=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=VrFxFnsOH4oBDgxKjU2ZXbba4nRtm85aNwrA2CzHFX8qVVxvjdZuRZv7miiLZ0BHq
YvcvkXqwi+L7QHIwsbXOepyo3kRWJXo8twZ1oIW8J0dlxC9fRmOaSMh5AZbE/GsT4v
CSGOyIBoWZ2HqypfSShzEKEs11jwjANySLUxX2KXr3WcUdeq/1iuiwo8OnDjBsQmPf
Rl2s6WP+NgDl9CZSA1AgM5EawKibqbMejeK2SR7EVYUzYmTHzLs2U4vyc8q4oD9MVT
brSAoZiDxp50NL0CnBTw2I3fJOuEvBhYn7mgM99bd8di5vYap6CUaIAthfymg4wK+J
fQso5oRdohirg==
From: Nikita Travkin <nikita@trvn.ru>
To: agross@kernel.org, andersson@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
konrad.dybcio@linaro.org, quic_srivasam@quicinc.com,
judyhsiao@chromium.org, mka@chromium.org, dianders@chromium.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Nikita Travkin <nikita@trvn.ru>
Subject: [PATCH v4 1/4] arm64: dts: qcom: sc7180: Don't enable lpass clocks by
default
Date: Thu, 6 Apr 2023 20:06:30 +0500
Message-Id: <20230406150633.83351-2-nikita@trvn.ru>
In-Reply-To: <20230406150633.83351-1-nikita@trvn.ru>
References: <20230406150633.83351-1-nikita@trvn.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1762440832046043219?=
X-GMAIL-MSGID: =?utf-8?q?1762440832046043219?=
|
| Series |
Add Acer Aspire 1
|
|
Commit Message
Nikita Travkin
April 6, 2023, 3:06 p.m. UTC
lpass clocks are usually blocked from HLOS by the firmware and
instead are managed by the ADSP. Mark them as reserved and explicitly
enable in the CrOS boards that have special, cooperative firmware.
Signed-off-by: Nikita Travkin <nikita@trvn.ru>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++
arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++
2 files changed, 12 insertions(+)
Comments
On 6.04.2023 17:06, Nikita Travkin wrote: > lpass clocks are usually blocked from HLOS by the firmware and > instead are managed by the ADSP. Mark them as reserved and explicitly > enable in the CrOS boards that have special, cooperative firmware. > > Signed-off-by: Nikita Travkin <nikita@trvn.ru> > --- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 423630c4d02c..26def6e12723 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -785,6 +785,14 @@ alc5682: codec@1a { > }; > }; > > +&lpasscc { > + status = "okay"; > +}; > + > +&lpass_hm { > + status = "okay"; > +}; > + > &lpass_cpu { > status = "okay"; > _hm should come after _cpu alphabetically w/ that Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 3c799b564b64..6f40301faa1c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 { > power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; > #clock-cells = <1>; > #power-domain-cells = <1>; > + > + status = "reserved"; /* Controlled by ADSP */ > }; > > lpass_cpu: lpass@62d87000 { > @@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 { > > #clock-cells = <1>; > #power-domain-cells = <1>; > + > + status = "reserved"; /* Controlled by ADSP */ > }; > }; >
Konrad Dybcio писал(а) 07.04.2023 00:31: > On 6.04.2023 17:06, Nikita Travkin wrote: >> lpass clocks are usually blocked from HLOS by the firmware and >> instead are managed by the ADSP. Mark them as reserved and explicitly >> enable in the CrOS boards that have special, cooperative firmware. >> >> Signed-off-by: Nikita Travkin <nikita@trvn.ru> >> --- >> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++ >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> index 423630c4d02c..26def6e12723 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi >> @@ -785,6 +785,14 @@ alc5682: codec@1a { >> }; >> }; >> >> +&lpasscc { >> + status = "okay"; >> +}; >> + >> +&lpass_hm { >> + status = "okay"; >> +}; >> + >> &lpass_cpu { >> status = "okay"; >> > _hm should come after _cpu alphabetically > Oops, will fix, thanks! > w/ that > > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Konrad >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index 3c799b564b64..6f40301faa1c 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 { >> power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; >> #clock-cells = <1>; >> #power-domain-cells = <1>; >> + >> + status = "reserved"; /* Controlled by ADSP */ >> }; >> >> lpass_cpu: lpass@62d87000 { >> @@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 { >> >> #clock-cells = <1>; >> #power-domain-cells = <1>; >> + >> + status = "reserved"; /* Controlled by ADSP */ >> }; >> }; >>
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 423630c4d02c..26def6e12723 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -785,6 +785,14 @@ alc5682: codec@1a { }; }; +&lpasscc { + status = "okay"; +}; + +&lpass_hm { + status = "okay"; +}; + &lpass_cpu { status = "okay"; diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 3c799b564b64..6f40301faa1c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 { power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>; #clock-cells = <1>; #power-domain-cells = <1>; + + status = "reserved"; /* Controlled by ADSP */ }; lpass_cpu: lpass@62d87000 { @@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 { #clock-cells = <1>; #power-domain-cells = <1>; + + status = "reserved"; /* Controlled by ADSP */ }; };