[v2,1/8] regulator: dt-bindings: fcs,fan53555: Add support for RK860X

Message ID 20230406171806.948290-2-cristian.ciocaltea@collabora.com
State New
Headers
Series Add support for Rockchip RK860X regulators |

Commit Message

Cristian Ciocaltea April 6, 2023, 5:17 p.m. UTC
  Add compatibles to support Rockchip RK860X regulators.

RK8600/RK8601 are pretty similar to the FAN53555 regulators, while
RK8602/RK8603 are a bit different, having a wider voltage selection
range.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 .../bindings/regulator/fcs,fan53555.yaml      | 22 ++++++++++++++-----
 1 file changed, 16 insertions(+), 6 deletions(-)
  

Comments

Krzysztof Kozlowski April 6, 2023, 6:14 p.m. UTC | #1
On 06/04/2023 19:17, Cristian Ciocaltea wrote:
> Add compatibles to support Rockchip RK860X regulators.
> 
> RK8600/RK8601 are pretty similar to the FAN53555 regulators, while
> RK8602/RK8603 are a bit different, having a wider voltage selection
> range.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  .../bindings/regulator/fcs,fan53555.yaml      | 22 ++++++++++++++-----
>  1 file changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
> index c0dbba843f70..7547c130ff7d 100644
> --- a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
> @@ -14,12 +14,22 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - fcs,fan53555
> -      - fcs,fan53526
> -      - silergy,syr827
> -      - silergy,syr828
> -      - tcs,tcs4525
> +    oneOf:
> +      - items:

Drop items here. It's just an enum.

> +          - enum:
> +              - fcs,fan53555
> +              - fcs,fan53526
> +              - rockchip,rk8600
> +              - rockchip,rk8602
> +              - silergy,syr827
> +              - silergy,syr828
> +              - tcs,tcs4525
> +      - items:
> +          - const: rockchip,rk8601
> +          - const: rockchip,rk8600
> +      - items:
> +          - const: rockchip,rk8603
> +          - const: rockchip,rk8602
>  
>    reg:
>      maxItems: 1

Best regards,
Krzysztof
  
Cristian Ciocaltea April 6, 2023, 7:17 p.m. UTC | #2
On 4/6/23 21:14, Krzysztof Kozlowski wrote:
> On 06/04/2023 19:17, Cristian Ciocaltea wrote:
>> Add compatibles to support Rockchip RK860X regulators.
>>
>> RK8600/RK8601 are pretty similar to the FAN53555 regulators, while
>> RK8602/RK8603 are a bit different, having a wider voltage selection
>> range.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>  .../bindings/regulator/fcs,fan53555.yaml      | 22 ++++++++++++++-----
>>  1 file changed, 16 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
>> index c0dbba843f70..7547c130ff7d 100644
>> --- a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
>> @@ -14,12 +14,22 @@ allOf:
>>  
>>  properties:
>>    compatible:
>> -    enum:
>> -      - fcs,fan53555
>> -      - fcs,fan53526
>> -      - silergy,syr827
>> -      - silergy,syr828
>> -      - tcs,tcs4525
>> +    oneOf:
>> +      - items:
> 
> Drop items here. It's just an enum.

Indeed, sorry, will prepare v3.

Thanks for reviewing,
Cristian
  

Patch

diff --git a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
index c0dbba843f70..7547c130ff7d 100644
--- a/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
+++ b/Documentation/devicetree/bindings/regulator/fcs,fan53555.yaml
@@ -14,12 +14,22 @@  allOf:
 
 properties:
   compatible:
-    enum:
-      - fcs,fan53555
-      - fcs,fan53526
-      - silergy,syr827
-      - silergy,syr828
-      - tcs,tcs4525
+    oneOf:
+      - items:
+          - enum:
+              - fcs,fan53555
+              - fcs,fan53526
+              - rockchip,rk8600
+              - rockchip,rk8602
+              - silergy,syr827
+              - silergy,syr828
+              - tcs,tcs4525
+      - items:
+          - const: rockchip,rk8601
+          - const: rockchip,rk8600
+      - items:
+          - const: rockchip,rk8603
+          - const: rockchip,rk8602
 
   reg:
     maxItems: 1