diff mbox series

[1/4] arm64: dts: qcom: sm6115-j606f: Add ramoops node

Message ID 20230406-topic-lenovo_features-v1-1-c73a5180e48e@linaro.org
State New
Headers
Series Tab P11 features |

Commit Message

Konrad Dybcio April 6, 2023, 3:25 p.m. UTC 
  Add a ramoops node to enable retrieving crash logs.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Dmitry Baryshkov April 6, 2023, 5:54 p.m. UTC | #1 
On 06/04/2023 18:25, Konrad Dybcio wrote:
> Add a ramoops node to enable retrieving crash logs.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>   arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> index 10c9d338446c..fd064899791c 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
> @@ -52,6 +52,17 @@ key-volume-up {
>   			wakeup-source;
>   		};
>   	};
> +
> +	reserved-memory {
> +		ramoops@ffc00000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0xffc00000 0x0 0x100000>;
> +			record-size = <0x1000>;
> +			console-size = <0x40000>;

no ftrace-size?

> +			ecc-size = <16>;
> +			no-map;

I see that other ramoops defines are not marked with no-map. Is there 
any reason for that?

> +		};
> +	};
>   };
>   
>   &dispcc {
>
Konrad Dybcio April 6, 2023, 6:29 p.m. UTC | #2 
On 6.04.2023 19:54, Dmitry Baryshkov wrote:
> On 06/04/2023 18:25, Konrad Dybcio wrote:
>> Add a ramoops node to enable retrieving crash logs.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> index 10c9d338446c..fd064899791c 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
>> @@ -52,6 +52,17 @@ key-volume-up {
>>               wakeup-source;
>>           };
>>       };
>> +
>> +    reserved-memory {
>> +        ramoops@ffc00000 {
>> +            compatible = "ramoops";
>> +            reg = <0x0 0xffc00000 0x0 0x100000>;
>> +            record-size = <0x1000>;
>> +            console-size = <0x40000>;
> 
> no ftrace-size?
It could use some!

> 
>> +            ecc-size = <16>;
>> +            no-map;
> 
> I see that other ramoops defines are not marked with no-map. Is there any reason for that?
Hm, not really. I can get rid of it for v2.

Konrad
> 
>> +        };
>> +    };
>>   };
>>     &dispcc {
>>
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
index 10c9d338446c..fd064899791c 100644
--- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
+++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts
@@ -52,6 +52,17 @@  key-volume-up {
 			wakeup-source;
 		};
 	};
+
+	reserved-memory {
+		ramoops@ffc00000 {
+			compatible = "ramoops";
+			reg = <0x0 0xffc00000 0x0 0x100000>;
+			record-size = <0x1000>;
+			console-size = <0x40000>;
+			ecc-size = <16>;
+			no-map;
+		};
+	};
 };
 
 &dispcc {